BUTTON CHANGES - REPORT PROBLEMS HERE

[Atheistic Freedom]

Sorry, but Bubbles does not work.

It was seriously perfect before whoever decided to mess with it, and I can only fear the same with the Metronome (I'll check up on later).

To move the "cannon," one must now move it by flicking their thumb damn fast in short strokes, because it will only take the scrolling in short increments, not a continuous sweeping motion like before.  And even with the "flicking," the cannon moves literally a hair's width side to side.

In short, it's still (very) broken, and I do not see why the button changes were implemented in the first place.

[JdGordon]

how about saying which target the problem is with?

[Atheistic Freedom]

Darn it, I knew I forgot something vital.

iPod - 5G.

Thank you for looking into it.

[JdGordon]

metronome fixed, fixing my dads laptop then ill grab my sisters nano and sort out the bubbles problem

[MichaelG]

Iriver H120.

In Bookmark History you can delete Bookmarks with Buttons On+Navi. That doesen't work. I have the Last Build working.

MfG Michael

[JdGordon]

yes, bookmark screen is horrible and (imho) needs to be completly refactored.... it will get done when someone can figure out a nice way to do it

bubbles is fixed for the ipod in cvs as of now

[Atheistic Freedom]

Thank you jdgordon for the fixes of both the Metronome and the Bubbles plugins.  I am uploading it on my iPod right now so I can test them out while I wait out in the cold for a Wii  

[Mmmm]

Iriver H120.

In Bookmark History you can delete Bookmarks with Buttons On+Navi. That doesen't work. I have the Last Build working.

MfG Michael

The record button deletes bookmarks, as it says on the screen.

EDIT: Ahh, I see you have sorted your problem here:
http://forums.rockbox.org/index.php?topic=7480.0
Your lang file is out of date.

[slash14]

Thank you jdgordon for the fixes of both the Metronome and the Bubbles plugins.

Hi everyone.

Seems that the Rec button has been disabled in the Metronome plugin, so synchronization can't be performed anymore (latest Rockbox edition and metronome.c v1.34)

Any way to fix this please ? I'm not used to the Rockbox development to correct this myself right now.

Thank you.

[slash14]

An answer to my own previous question:
With the following trick, it works (refers to the very end of metronome.c):

Code: [Select]


#ifdef  METRONOME_TAP
            case METRONOME_TAP:
                tap();
                break;
#endif

#if METRONOME_SYNC
            case METRONOME_SYNC:
                minitick = period;
                break;
#endif

            default:
to become as follows:

Code: [Select]

#ifdef  METRONOME_TAP
            case METRONOME_TAP:
                tap();
                break;
#endif

            case METRONOME_SYNC:
                minitick = period;
                break;

            default:
Do you think it was an error in the original source code, or should I consider myself lucky wih this trick to make it work ? I'm not a very good developper / coder, sometimes I make things work without understanding why

[pabouk]

Your correction works but the correct way should probably be:

Code: [Select]

#ifdef  METRONOME_TAP
            case METRONOME_TAP:
                tap();
                break;
#endif

#ifdef METRONOME_SYNC
            case METRONOME_SYNC:
                minitick = period;
                break;
#endif

            default:I.e. support the option only if the symbol is defined.

[slash14]

Yeah, I also tested it, but it didn't work.

My device is an iHP120.

I also removed the previous #ifdef just before the METRONOME_TAP and it didn't change anything : with or without this #ifdef, tapping the tempo will work ...

Thanks for your answer anyway.

[JdGordon]

Ive just replaced the #if with #iifdef, it should work...
It cant be completly removed because it will causee builds errors in the other targets.

actually, that change shouldnt make any differenece... iif it still doesnt  work let me know and ill try agaain

[pabouk]

Slash14 was right. Unfortunately it still does not work.

[Mmmm]

Not surprising really seeing as METRONOME_SYNC is never defined...