BUTTON CHANGES - REPORT PROBLEMS HERE

[Yotto]

Where do your keypresses get ignored? it all seems to be working fine for me!

I'm gonna just take a guess and say...

after exiting a plugin, or when dealing with FM presets

[Lear]

your both being silly... the fact that thew screens mentined havnt been converted means there is no problems with them!

Not quite true, actually. Check radio.c; the function handle_radio_presets_cb is currently disabled, because the FM screen isn't yet converted, but the menu system is (the menu callback gets action codes, not the button codes the function expects). Someone even wrote "this screen needs fixing!" there. Don't know if it was Linus or you though.

[JdGordon]

that was probably me ;P

[bascule]

So, I'm still a bit confused. If I install the most recent build, is the FM screen likely to work 'OK', 'badly', or 'not at all'?

[JdGordon]

as long as u dont need the presets it works fine

[pabouk]

Presets work for me in the current CVS build but the first keypress is ignored after invoking the list of presets (short press of the Navi button).

[roolku]

as long as u dont need the presets it works fine

...and as long as you don't mind the extra keypress after exiting certain plugins []

[roolku]

Presets work for me in the current CVS build but the firs keypress is ignored after invoking the list of presets (short press of the Navi button).

How do you edit entries? I can scoll and select an entry, but not edit it?

[pabouk]

How do you edit entries? I can scoll and select an entry, but not edit it?

Aaah, I totally forgot about the possibility to edit the presets I have not changed my presets for half a year. Sorry about that, it does not work for me.

[Mmmm]

The radio screen should work now...You need to test it though, I don't use the radio screen much so I'm not sure if it is how it should be...seems good to me though!

[pixelma]

The radio screen should work now...

Nope!
Your commit broke the functionality of the radio screen on my device - an OndioFm - almost completely!

The only thing that works is going through the stations (while in Preset mode or seeking through the frequencies while in Seek mode) - which is even mapped to the "Up" and "Down" keys that were used to adjust volume. No other button presses have an effect except a "Long Press on Off" and it does now... reboot rockbox! I cannot adjust volume and cannot reach the Radio "context" menu that is really important on Ondio (there you can manage your presets, change between Preset and Seek mode,...) due to the lack of buttons.

I know you don't own such a device, and there might be only a few Ondio users, but it would be really nice (or maybe necessary?) if you ask someone to gather information on how it works now and to test such important changes before committing. Things will even get worse as Rockbox is ported to more and more targets and then this statement may apply to other daps as well. I would volunteer of course and am often present in IRC (same nick).

Thanks, pixelma

[Mmmm]

I forgot to add the context types!   How silly. Also, the Ondio settings context doesn't contain all of the buttons that the other targets do, so I've added a couple to the fm context ...  that should fix it...

better now?

[dropandhop]

Thanks for your work Mmmm!

Looking back to roolku's post it looks like these items are still left:
1) plugins not converted
2) recording screen? (not sure about this one)

Is this correct?  
If this is true, I hope some folks are able to find the time to get this going properly.

Thanks everyone,
Aaron

[RaeNye]

I committed some X5 remote key mapping yesterday, and I think I'm going to simply identify each RC button with a main DAP button and have the keymap do the same with both.

Specifically, vol-/+ are mapped to UP/DOWN, rew/ff to LEFT/RIGHT, rec to REC, mode to PLAY, menu to SELECT and play/pause to POWER.
I know these aren't the original 'titles' but it's easier to learn one mapping instead of two different ones.

Any objections/comments?

[Mmmm]

Thanks for your work Mmmm!

Looking back to roolku's post it looks like these items are still left:
1) plugins not converted
2) recording screen? (not sure about this one)

Is this correct?  
If this is true, I hope some folks are able to find the time to get this going properly.

Thanks everyone,
Aaron

I did the recording screen some time ago, although I think there are still a couple of bugs with the trigger function for the archos..I'll be looking into that later.

So it's really just the plugins, and considering each and every one will have to be done seperately, that is a bit of a daunting task!