Adding search keys to the Database Search sub menu

[iPodVT]

I'm trying to add the ability to search for Disc Number and Disc Total in my Database Search sub menu.  After looking at the Tagcache Database Format page in the Rockbox Wiki [https://www.rockbox.org/wiki/TagcacheDBFormat.html] I tried adding the following line to the "Search by..." sub menu code in my tagnavi_user.config file:

"Disc Number" -> discnumber ? discnumber = "" -> album -> title = "fmt_title"

but apparently Rockbox didn't like that because it didn't show up in my menu when I relaunched.  Then I changed discnumber (which is what is specified on the Tagcache Database Format page) to discnum (which is the label displayed by the Show Track Info screen when that tag is present in a track file) and it worked.  So I think that wiki page probably needs to be corrected/updated.

Now my question is:  Is there an ID3 tag search key that will work for finding the Disc Total for a track file (e.g. the '3' in Disc 1 of 3)?  I don't see a spec for it on the Tagcache Database Format page and it doesn't get displayed by the Show Track Info screen so I'm guessing (but hoping I'm wrong) that it isn't currently getting cached in the database.

Thanks.

[iPodVT]

I have to partially correct m

Now my question is:  Is there an ID3 tag search key that will work for finding the Disc Total for a track file (e.g. the '3' in Disc 1 of 3)?  I don't see a spec for it on the Tagcache Database Format page and it doesn't get displayed by the Show Track Info screen so I'm guessing (but hoping I'm wrong) that it isn't currently getting cached in the database.

It turns out that some tracks in my music library are in fact showing "[Discnum] 1/3" in the Show Track Info screen while others that have both a Disc Number and a Disk Total in their ID3 tags are only showing "[Discnum] 1".  So it does seem to indicate that Rockbox is at least sometimes caching a Disk Total value in the database.

[iPodVT]

Initial observations are indicating that the tracks whose Disk Total tags are getting displayed are all mp3s that were encoded with early versions of iTunes (v2.0.4 and v4.7.1), and the tracks whose Disk Total tags are not getting displayed are all AACs that were encoded with later versions of iTunes (v12.8.3.1).

[speachy]

Initial observations are indicating that the tracks whose Disk Total tags are getting displayed are all mp3s that were encoded with early versions of iTunes (v2.0.4 and v4.7.1), and the tracks whose Disk Total tags are not getting displayed are all AACs that were encoded with later versions of iTunes (v12.8.3.1).

Use something like 'exiftool' to dump the tags of those files.  That will be informative.

[iPodVT]

Use something like 'exiftool' to dump the tags of those files.  That will be informative.

Thanks for that suggestion.

In the meantime I have done a brute force visual survey of Show Track Info screens for dozens and dozens and dozens of tracks, and what I have observed so far has been 100% consistent.

With MP3s and AIFFs:
"[Tracknum] x/n" is always displayed.
"[Discnum] x/n" is always displayed if Disc Number and Disc Total are present in the track's ID3 tags.

With AACs and ALACs:
"[Tracknum] x/n" is never displayed - it's always "[Tracknum] x".
"[Discnum] x/n" is never displayed.  If Disc Number and Disc Total are present in the track's ID3 tags, only "[Discnum] x" is displayed.

I don't think I have any WAVs or FLACs in my music library, but that raises the question:  Does Rockbox recognize additional ID3 Tag search keys beyond those that are specified on the Tagcache Database Format page?  In my first post I was looking for something for Disc Total.  Now I'm also looking for something for File Format.  I know that I could search file names for ".wav" or ".m4a", but ".m4a" is used for both AAC and ALAC (which leads me to believe that Rockbox is getting and caching a File Type tag from the track file and not just using the file's extension).

Again, thanks.

[bahus]

If I remember correctly, rockbox doesn't parse discs count tag at all. If you see Disc Number "1/2" - it comes right from metadata and displayed as is.

[bahus]

With AACs and ALACs:
"[Tracknum] x/n" is never displayed - it's always "[Tracknum] x".
"[Discnum] x/n" is never displayed.  If Disc Number and Disc Total are present in the track's ID3 tags, only "[Discnum] x" is displayed.

This one should be addressed with https://gerrit.rockbox.org/r/c/rockbox/+/6607

And I double checked - there is no dedicated field in metatdata for discs total field (and disc_string with "x/n" is not exposed to tag cache too) so no way to search it.

[iPodVT]

With AACs and ALACs:
"[Tracknum] x/n" is never displayed - it's always "[Tracknum] x".
"[Discnum] x/n" is never displayed.  If Disc Number and Disc Total are present in the track's ID3 tags, only "[Discnum] x" is displayed.

This one should be addressed with https://gerrit.rockbox.org/r/c/rockbox/+/6607

Thanks very much for this.  I installed the current dev build a12d8e2171 and all looks good.

And I double checked - there is no dedicated field in metatdata for discs total field (and disc_string with "x/n" is not exposed to tag cache too) so no way to search it.

And thanks, too, for clarifying this.

[iPodVT]

I realize now that in my initial post in this topic I confused the usage of the term "discnumber" (which is the name of an ID3 tag in a track file) with the usage of the term "discnum" (which is apparently the abbreviated name that Rockbox uses for its storage of a discnumber datum in the database).

These terms are used on the wiki's Database page [https://www.rockbox.org/wiki/DataBase.html], on the wiki's Tagcache Database Format page [https://www.rockbox.org/wiki/TagcacheDBFormat.html], and in the Rockbox Manual, and perhaps other places as well, and I hadn't seen all of those references so I didn't get the distinction between them.  My apologies.