Support and General Use > Theming and Appearance Customization
New taller sysfont
Frankenpod:
--- Quote from: iPodVT on March 05, 2025, 04:13:20 PM ---I just now installed the dev build 3539dd5a70 update which reverts the sysfont - thanks.
Now (not at this moment... ;-) I need to go into my theme files and start adding font specifications so as to eliminate the assumptions I have been making re things like sysfont. Thanks very much for bringing this 'better practice' to my attention.
Unrelated to this but brought to my attention by having updated two successive dev builds in fairly rapid succession, I am reminded of two minor Rockbox Utility issues that I've been meaning to report and will do so shortly on the Rockbox Utility forum.
--- End quote ---
Pretty sure some of my themes used the default status bar, and made assumptions about its size. Writing a custom status bar in full every time is just that much more effort, so sometimes would just use the default one.
speachy:
--- Quote from: Frankenpod on March 06, 2025, 08:11:15 PM ---Pretty sure some of my themes used the default status bar, and made assumptions about its size. Writing a custom status bar in full every time is just that much more effort, so sometimes would just use the default one.
--- End quote ---
In of itself this isn't a problem (and is something that was intentionally supported). However, we were in a position where the same theme was being listed as "compatible" with players that use different-sized sysfonts (which means status bar size because the sysfont is used in the default status bar for numeric values), so a theme coded for one will not work correctly on the others.
There are still places in the codebase (mostly plugins and little-used per-target debug code) that are hardcoded to an 8px sysfont size. Correcting this assumption has been ongoing for a _long_ time.
That said, user themes shouldn't be making explicit use of SYSFONT (ie font id 0) for anything. Even use of UIFONT (id 1) is probably questionable.
We haven't come up with a good way to detect these problems in an automated fashion. Once we do, we'll revisit bumping the sysfont size on these players.
iPodVT:
--- Quote from: speachy on March 07, 2025, 07:48:28 AM ---That said, user themes shouldn't be making explicit use of SYSFONT (ie font id 0) for anything. Even use of UIFONT (id 1) is probably questionable.
--- End quote ---
If themes were to stop using UIFONT, then what function would be served by the Font setting at Settings->Theme Settings->Font?
iPodVT:
I assume that many themes already don't use UIFONT or use it only minimally, and I understand both the advantage and necessity of that. I also expect that for many (probably most) users, creating and/or editing themes is not a realistic proposition, and therefore having some theme(s) available with which they could at least alter the font would seem to be desirable. I can well imagine the conflicts that this raises for the devs in keeping things both flexible and robust.
Navigation
[0] Message Index
[*] Previous page
Go to full version