Support and General Use > Audio Playback, Database and Playlists

Trying to play tracks crashes with current dev build on iPod mini 2nd Gen

<< < (3/4) > >>

iPodVT:
You just barely caught me - I was about to hit the hay - but I will give them a whirl and let you know before I turn in.

iPodVT:
This one froze when I tried to play a track from the File Browser:
ipod_mini2g_d5fc0e4cb3_rockbox.zip

These played a track from the File Browser without freezing (I only let them play for about 20 seconds):
Ipod_mini2g_95f4accf45_rockbox.zip
ipod_mini2g_801260dd79_HEAD_rockbox.zip
ipod_mini2g_0847bcc110_.zip

iPodVT:
That set of four tests were all clean-installed.

Now I have used Rockbox Utility to update my full installation of 95f4accf45 with all of my configs etc to 801260dd79 and tracks are playing without freezing.

When you have a free moment can you please give us a word or two of explanation regarding what the problem was?

Thanks.

Bilgus:
What this was was a subtle bug with our lang_id system
it has macros P2STR P2ID and ID2P
P2STR takes any old string and passes it thru but if its a lang string it grabs it from the lang table

P2ID and ID2P do similar conversions

well the way it is used it references an 'invalid' memory location to denote lang strings
on a bunch of the devices this was address '0'

that patch you referenced used P2STR(text) to voice user supplied entries
I caught the end result which was a NULL string referencing LANG_ID 0 and moved the 'Rockbox' string there
Ya know free advertising? :)

But Speachy correctly identified the flip side of it which is the crash you experienced

so to fix it he put the devices using address 0 at address 0 + sizeof(*char) preserving the sanctity of NULL and adding 100-400 bytes to all the bins :)

iPodVT:
Thanks for the explanation.

I'm going to name my next album 'The Sanctity of NULL'.

Navigation

[0] Message Index

[#] Next page

[*] Previous page