Support and General Use > Theming and Appearance Customization

Any possibility for conditional %Cl?

<< < (3/5) > >>

Bilgus:
I think we might be able to get something similar to the original patches functionality out of this one as well

but what I can't find in that original patch is how it decides which tracks album art it is going to display
is it just by virtue of the timing of the call or am I missing something?

Edit: AFAICT its just by virtue of the timing
https://gerrit.rockbox.org/r/c/rockbox/+/839/1/apps/gui/skin_engine/skin_render.c#321

so I wonder how that works with this patch its probably going to pull the next tracks album art but IDK i'll have to get some more album art first


I also don't like the multiple slots I think the current behavior fine as long as you can switch them

Bilgus:
Oh you know what I don't think that patch even does the next track it just allows displaying the same AA more than once

I think the use in its current form would be what they are displaying in the screenshot..
displaying the AA as a background then having a smaller thumbnail

we could actually get something similar out of this patch if we don't clear the previous image area first
 maybe a extra variable on %Cl or %Cd that tells it not to clear the previous would work

RetiredTeacherGuy:
Great, how can I best help?

Bilgus:
Well what I tried was adding a variable to the aa struct that allows not clearing the current AA image by redrawing the previous image
immediately. The issue I see is (probably with the original  patch too) that when you draw the image prior to the viewport getting drawn you sometimes get artifacts
cleared pixels overdrawn data etc.

so probably would need to instead hold onto the previous so you can redraw both

I'm thinking we might be better served with a way to take a 'screenshot' of the current screen to get all or a portion loaded into a new image that you can later display
Code:

%Sc or %sc(id, x,y,w,h, flags)

the flags could allow image transformations maybe something like color to b&w or dithering or even blit mode

then you can display a screen (need to see if this can be done without actually refreshing) make a copy of all or a portion mis it up a bit and display as background or something



--- Quote ---Great, how can I best help?
--- End quote ---

just testing that patched build to see if it works as expected, I haven't seen any issues so far after adding a bunch of tracks back to back using album art

RetiredTeacherGuy:
I tried the build with two %Cl statements, one for play mode at 170 x 170 and one for pause at 140 x 140 as discussed earlier in the thread. The %Cd shows at 140 x 140 in both play and pause, as has been the case in previous versions.


Any other coding I should try? The goal is to be able to make different %Cl requests of the same AA. They don’t need to show at the same time, but display distinct sizes/locations.

Navigation

[0] Message Index

[#] Next page

[*] Previous page