Funky data from the %pv theming tag?

[iPodVT]

At some point after dev build fe78b07db6-241231 was posted (and not including that dev build), my theme seems to have started getting funky data from the %pv tag when the player's volume is greater than or equal to zero.  I'm seeing this on both ipodvideo and ipod6g.  For volumes zero through 9 nothing is getting displayed.  For volumes 10 through 12 on ipod6g only the second digit (0 for 10, 1 for 11, 2 for 12) is getting displayed.  The ipodvideo's volume apparently only goes up to 6.  I don't think my theme's code/syntax/spacing is at fault because all digits for volumes from -1 to -60 (and on to -90 on ipodvideo) are getting correctly displayed.

Did something change with %pv in dev builds subsequent to fe78b07db6-241231 on Dec 31 or later?

[chris_s]

384c35418a /  (2025-01-04) fixed a regression in the behavior of the pv tag that was introduced in 10facef (2021-04-09) where a leading space was inadvertently included for volumes >= 0

https://www.rockbox.org/tracker/task/13537

[iPodVT]

Ah yes, that's it.  My theme was aware of and compensating for the leading space, though I have no memory of it.  At the time I coded it I probably assumed that the leading space was intentional and put there for a reason that was beyond the very limited knowledge I had then.

I also now remember seeing the note for 384c35418a in Code - Recent Activity, but it had already slipped my mind by last night when I observed the problem with the volume display in my status bar so I didn't make the connection.

And, of course, this all raises a question I have wondered about for a long time:  Why is the Volume setting menu ordered with the quietest, lowest value negative numbers at the top and the loudest, largest value positive numbers at the bottom?  Seems unintuitive to me, though I have fully gotten used to it by now.

Thanks yet again.

[chris_s]

Why is the Volume setting menu ordered with the quietest, lowest value negative numbers at the top and the loudest, largest value positive numbers at the bottom?  Seems unintuitive to me, though I have fully gotten used to it by now.

I think that can actually be adjusted using the List Order setting (Settings -> General -> Display -> Scrolling...   

"When set to Ascending, numeric lists such as brightness and volume will be sorted with the smallest value at the top of the list and values increasing down the list. When set to Descending, the order is reversed – the largest value is sorted at the top and values will decrease down the list."

https://download.rockbox.org/daily/manual/rockbox-ipod6g/rockbox-buildch8.html#x15-1520008.5

[iPodVT]

The breadth and depth of Rockbox - and also the Manual - and also the responsiveness of the dev team - never fails to astound me.

Thank you, thank you, thank you.