Rockbox Development > Feature Ideas

Save downscaled album art in database as cache

<< < (4/4)

Yakov5776:
Of course, but I’d like to focus on implementing this in the most ideal way, as getting it working isn’t the only objective.

bahus:

--- Quote from: Yakov5776 on January 01, 2025, 02:27:25 PM ---Of course, but I’d like to focus on implementing this in the most ideal way, as getting it working isn’t the only objective.

--- End quote ---

It seems you sent me a personal email some time ago with the following request:

--- Quote ---if it's possible if I can load music tracks with album art enabled w/o waiting for the art to actually load so the audio starts right away even if it takes some extra time for the art to decode
--- End quote ---

Please use the forum for your requests unless it's a business proposal. At a quick glance, I think the image processing needs to be moved to a separate thread to work smoothly. Currently, it's done in the audio thread, so even if we delay loading album art, the user interface won't be responsive to your actions (volume/pause/next/...) when we come back to processing large album art (though audio playback should be OK as it's done in a different codec thread). I'm not really interested in this functionality to look any deeper.

Here's a quick workaround that simply skips loading large album arts (>2MB, can be adjusted in MAX_AA_SIZE). Maybe it will work for you:
https://github.com/bahusoid/rockbox/commit/612bca1aab1fc41e56316fb9d01bc59afec70eab

If you need a patch file just add .patch to the link above.

Navigation

[0] Message Index

[*] Previous page