Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
translations translations
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Thank You for your continued support and contributions!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Looking for feedback on final Quickscreen theme tags
« previous next »
  • Print
Pages: [1]

Author Topic: Looking for feedback on final Quickscreen theme tags  (Read 2052 times)

Offline Dook

  • Member
  • *
  • Posts: 66
    • D00k.net
Looking for feedback on final Quickscreen theme tags
« on: June 29, 2024, 02:04:28 PM »
Hi folks!

I've been working on adding new theme tags that display the user's quicksettings. Previously, it was possible to obtain the name of the setting a user had put on the quickscreen using %St(qs top) %St(qs left) etc, however it was impossible to get the secondary information like what the default quickscreen can show.

As I'm currently cleaning up and preparing to upload the code for review, I wanted to get some feedback in terms of the chosen tags and how I've implemented the features.

I've added two tags for each Quicksetting direction, so eight in total. For example, the left quicksetting's tags would be %QL and %Ql (lowercase L). The %QL tag displays the name of setting that has been attached to the left button, while the %Ql lowercase tag displays the output of that setting.

I'm wondering what people's thoughts are on this arrangement? Are there any improvements or changes I can make? I do feel that the %QL tag could be seen as redundant considering this information is already accessible with another tag, it does add 40 lines of code to the skin parser which does appear to be a bit large compared to a lot of tags. However having both %QL and %Ql tags provides people with a convention to follow, as well as making the feature easier to access.
Logged

Offline chronicallyoffline

  • Member
  • *
  • Posts: 8
Re: Looking for feedback on final Quickscreen theme tags
« Reply #1 on: July 14, 2024, 05:05:01 PM »
I think it's a great addition. Slightly adjacent question related to the quickscreen - is there currently a way to map a quickscreen option to the scrollwheel for changing values?

I'd personally be really interested in the ability to map "Brightness" to a single Qs entry, click it, then be able to adjust using the wheel, rather than clicking it 10-20 times for the desired level.
Logged

Offline Dook

  • Member
  • *
  • Posts: 66
    • D00k.net
Re: Looking for feedback on final Quickscreen theme tags
« Reply #2 on: July 18, 2024, 11:34:14 AM »
I think a way of changing the setting mapped to the scrollwheel would be an interesting feature. Having it change based on the quickscreen settings though might be a bit too convoluted.
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Looking for feedback on final Quickscreen theme tags
 

  • SMF 2.0.19 | SMF © 2021, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.153 seconds with 21 queries.