The new System->Legal Notices requires two Quits to actually quit

[iPodVT]

Using the new dev build (eaeaac598d-240531) on a 7th Gen iPod Classic, I just now tried viewing the new Legal Notices item listed in the System Menu and found that when I tried to quit once, the Text Viewer plugin would return back to displaying the text.  After choosing Quit a second time the Text Viewer then returned control back to the System Menu.  When I navigated to the same COPYING.txt file in the file browser and clicked on it there, it only required one Quit to exit the Text Viewer plugin.

[speachy]

The legal notices thing shows two different files back to back; the first is the COPYING.txt (ie the GPLv2) that covers most things, but the second is the LICENSES.txt file with everything else that needs to be shown.  (mostly BSD-with-advertising-clause stuff)

It's not the most elegant but I didn't want to create another submenu

[iPodVT]

Oh Gosh - my mistake - I apologize.

[iPodVT]

I've been thinking a lot about this and I have to say that I think a different, more straightforward mechanism should be found for facilitating the display of the two Legal Notices.  How about replacing the single "Legal Notices" menu item with both a "Legal Notice: COPYING.txt" menu item and a "Legal Notice: LICENSES.txt" menu item?  That would increase the menu from five items to six, which is still a fairly short and concise menu, and it would give the user the choice and easy means to read either or both of the Notices.  To my mind, that would be preferable to having a Quit menu item that does anything other than initiate a quit sequence.

[speachy]

I've been thinking a lot about this and I have to say that I think a different, more straightforward mechanism should be found for facilitating the display of the two Legal Notices.  How about replacing the single "Legal Notices" menu item with both a "Legal Notice: COPYING.txt" menu item and a "Legal Notice: LICENSES.txt" menu item?  That would increase the menu from five items to six, which is still a fairly short and concise menu, and it would give the user the choice and easy means to read either or both of the Notices.  To my mind, that would be preferable to having a Quit menu item that does anything other than initiate a quit sequence.

I suspect you've way overthinking this.  Putting two entries into the top-level System menu is unnecessary clutter for something that will only ever be looked at once, if at all.

The only reason I implemented it the way I did was to avoid creating another nested submenu with those two entries.  Showing the filenames is in of itself doesn't really help -- the choices would need to be more descriptive; something like "GNU GPLv2" and "Other Licenses".  Or... simply combine the two files into one.

[iPodVT]

I suspect you've way overthinking this.  Putting two entries into the top-level System menu is unnecessary clutter for something that will only ever be looked at once, if at all.

The only reason I implemented it the way I did was to avoid creating another nested submenu with those two entries.  Showing the filenames is in of itself doesn't really help -- the choices would need to be more descriptive; something like "GNU GPLv2" and "Other Licenses".  Or... simply combine the two files into one.

I think combining the two files into one would be better than 'misusing' the Quit menu item.

[speachy]

I think combining the two files into one would be better than 'misusing' the Quit menu item.

...Except those two files are intentionally separate as they cover different things.

And just to be pedantic, there's no "misuse" of the "Quit" menu item; the textviewer plugin completely quits when it is invoked.

...ah, screw it.  patches welcome.

[iPodVT]

...Except those two files are intentionally separate as they cover different things.

And just to be pedantic, there's no "misuse" of the "Quit" menu item; the textviewer plugin completely quits when it is invoked.

...ah, screw it.  patches welcome.

"Misuse" was unnecessarily harsh on my part.  Sorry.  And also inaccurate:  the plugin completely quits, but then immediately and automatically reruns with the 2nd file.

In any case, I don't want to add "dead horse beater" to "over-thinker" on my rap sheet, so here's my last pitch:

I love Rockbox and I pretty much never use the original Apple firmware on my iPods anymore except for some occasional file system operations.  Rockbox is so much more powerful and useful, so of course it is more complex and has a steeper and longer learning curve than the Apple firmware.  I understand why for many users simpler is preferable and so they want to stick with the simpler firmware.  But it pains me to read posts on the various iPod subreddits that are vehemently negative ("never Rockbox" or "I hate Rockbox") - posts that often imply or outright state that Rockbox does things wrong or badly.  I think that to stick with this non standard behavior of the Quit menu item would give justifying fodder to those "nattering nabobs of negativism" (to ironically quote Spiro Agnew, of all people...).

Of course, I don't have to use the Legal Notices feature - 'problem' solved.  It also occurred to the mischievous part of me that maybe if I rename the LICENSES.txt file Rockbox wouldn't find it and would just quit back to the System menu.  I tried that and Rockbox ended up in the Rockbox Info screen.

However this turns out, I will still use and love Rockbox, and continue to post bug reports, suggestions and general feedback.  LONG LIVE ROCKBOX.