Support and General Use > Plugins/Viewers
The new System->Legal Notices requires two Quits to actually quit
iPodVT:
--- Quote from: speachy on June 02, 2024, 09:07:15 AM ---I suspect you've way overthinking this. Putting two entries into the top-level System menu is unnecessary clutter for something that will only ever be looked at once, if at all.
The only reason I implemented it the way I did was to avoid creating another nested submenu with those two entries. Showing the filenames is in of itself doesn't really help -- the choices would need to be more descriptive; something like "GNU GPLv2" and "Other Licenses". Or... simply combine the two files into one.
--- End quote ---
I think combining the two files into one would be better than 'misusing' the Quit menu item.
speachy:
--- Quote from: iPodVT on June 04, 2024, 02:47:29 PM ---I think combining the two files into one would be better than 'misusing' the Quit menu item.
--- End quote ---
...Except those two files are intentionally separate as they cover different things.
And just to be pedantic, there's no "misuse" of the "Quit" menu item; the textviewer plugin completely quits when it is invoked.
...ah, screw it. patches welcome.
iPodVT:
--- Quote from: speachy on June 04, 2024, 04:04:54 PM ---...Except those two files are intentionally separate as they cover different things.
And just to be pedantic, there's no "misuse" of the "Quit" menu item; the textviewer plugin completely quits when it is invoked.
...ah, screw it. patches welcome.
--- End quote ---
"Misuse" was unnecessarily harsh on my part. Sorry. And also inaccurate: the plugin completely quits, but then immediately and automatically reruns with the 2nd file.
In any case, I don't want to add "dead horse beater" to "over-thinker" on my rap sheet, so here's my last pitch:
I love Rockbox and I pretty much never use the original Apple firmware on my iPods anymore except for some occasional file system operations. Rockbox is so much more powerful and useful, so of course it is more complex and has a steeper and longer learning curve than the Apple firmware. I understand why for many users simpler is preferable and so they want to stick with the simpler firmware. But it pains me to read posts on the various iPod subreddits that are vehemently negative ("never Rockbox" or "I hate Rockbox") - posts that often imply or outright state that Rockbox does things wrong or badly. I think that to stick with this non standard behavior of the Quit menu item would give justifying fodder to those "nattering nabobs of negativism" (to ironically quote Spiro Agnew, of all people...).
Of course, I don't have to use the Legal Notices feature - 'problem' solved. It also occurred to the mischievous part of me that maybe if I rename the LICENSES.txt file Rockbox wouldn't find it and would just quit back to the System menu. I tried that and Rockbox ended up in the Rockbox Info screen.
However this turns out, I will still use and love Rockbox, and continue to post bug reports, suggestions and general feedback. LONG LIVE ROCKBOX.
Navigation
[0] Message Index
[*] Previous page
Go to full version