Sansa E200V2 Bootloader is broken in master

[amachronic]

So it makes my changes in unicode.c unnecessary, doesn't it?

Yes.

Also backtraces are not present in current bootloader release so it's not something we removed from released functionality.

OK, if it's not a regression that's fine with me.

Everything I've done is merged so let me know when you want to merge your changes. I also merged the multiboot v1 patches.

[bahus]

build them on top of his patchsets he isn't going to get upset

Not sure what you meant. But I've already cherry picked amachronic's patches to my local branch and reported results:

Also we don't make new bootloaders often so could you test some of these patches with your builds?

It works for me and adds around 100 bytes to thumb  size (119676 without, 119759 with those patches)

[bahus]

Everything I've done is merged so let me know when you want to merge your changes. I also merged the multiboot v1 patches.

I tested bootloader on top of the latest changes -  it works. So I think it's ready to be merged.

[Bilgus]

Out of curiosity I tested this no thumb build without `usb_storage_disconnect` fix. Still doesn't boot. So it doesn't look like some alignment issue to me. `usb_storage_disconnect` is the cause...

agreed -- thatd be our smoking gun

[bahus]

re unstable sd card try boosting dcdc voltages or force into non HS mode in the sd driver

It's been long time but JFYI. Changing voltage and forcing non HS mode didn't help. What helped - unboosting cpu. Finally found the culprit. Not sure why but with boosted CPU sd writes are pretty fast fail on my e200v2 (only writes, reads are fine - often fails even on bookmark creation). And after cpu_boost(false) gigs are written without any errors.
It's not something sd card specific - I tried two different brands (samsung and sandisk).

[Bilgus]

that could still be pointing to a voltage issue, it could also be a faulty chip could be an issue with our context switching and it could also be clocked wrong because of a wonky multiplier between the cpu and sd controller

[bahus]

Yeah might be. The fact that wide bus doesn't work for amsv1 also suggests some other issue. If you have any ideas what else can be done - let me know. I will happily try your suggestions.