Keep custom audio speed setting during shutdown/reboot

[chris_s]

Yeah, maybe people who actually use the option will chime in.

I could easily be wrong, but my assumption is that audiobook listeners are likely to want the opposite (i.e. make the bookmarked pitch persist). I imagine a typical workflow like this:

1) User listens to music with unadjusted pitch
2) User switches to an audiobook – adjusts the pitch for that
3) At some point they may want to listen to music again, or to some other audiobook, so they create a bookmark (which helpfully saves the pitch setting)
4) User listens to music – resets the pitch for that
5) Sometime later, they go back to listening to their audiobook by loading the bookmark, which also restores the pitch...

...so now, the pitch is restored, but only until the device is rebooted, at which point,  it is required to once again load a bookmark or manually adjust the pitch after resuming.

[Bilgus]

Still working on getting the code to match but here is my current manual entry

The value of the rate, pitch and speed is persistent, i.e. when the player is turned on
it will always be set to the last value set by Pitch Screen or Bookmarks. Selecting
Pitch again will now display a menu with Pitch and Reset Setting. Selecting
Reset Setting will reset the pitch to 100% now and at next boot. However the
rate, pitch and speed information will be stored in any bookmarks you may create
while the pitch is altered and will be restored upon playing back
those bookmarks.

[chris_s]

However the
rate, pitch and speed information will be stored in any bookmarks you may create
while the pitch is altered and will be restored upon playing back
those bookmarks.

"While the pitch is altered" I think you can get rid of and is potentially misleading, unless you're planning on changing the behavior of bookmarks, because even if the pitch hasn't been altered, the unaltered value is stored (and will thus be restored).

[Bilgus]

Ok the latest is now submitted

I'm pretty happy with it and I think should match what we discussed

[Bilgus]

I also fixed my biggest gripe about NVRAM getting corrupted which is tied to the size of the system_status struct

[eugenkss]

I could easily be wrong, but my assumption is that audiobook listeners are likely to want the opposite (i.e. make the bookmarked pitch persist). I imagine a typical workflow like this:

1) User listens to music with unadjusted pitch
2) User switches to an audiobook – adjusts the pitch for that
3) At some point they may want to listen to music again, or to some other audiobook, so they create a bookmark (which helpfully saves the pitch setting)
4) User listens to music – resets the pitch for that
5) Sometime later, they go back to listening to their audiobook by loading the bookmark, which also restores the pitch...

...so now, the pitch is restored, but only until the device is rebooted, at which point,  it is required to once again load a bookmark or manually adjust the pitch after resuming.

Yes, this makes totally sense for me.

It was me who suggested this feature about 9 months ago, so I am very happy to find it realised. Thanks a lot!

[bahus]

> It was me who suggested this feature about 9 months ago

Not sure when it was first suggested but a patch implementing this feature was suggested in 2010: https://www.rockbox.org/tracker/task/11619.

[eugenkss]

> It was me who suggested this feature about 9 months ago

Not sure when it was first suggested but a patch implementing this feature was suggested in 2010: https://www.rockbox.org/tracker/task/11619.

Never mind.
Let me rephrase it then: It was me who started this thread suggesting this feature. 

To me, it is not important who originally suggested it.
I appreciate that is was implemented!