Support and General Use > Plugins/Viewers

Rockboy shows wrong colors on my fuze v2

(1/1)

jsr_278:
A few weeks ago I bought and old sansa fuze v2 and I tried some gameboy color games and the colors displayed were wrong on this player. But they works fine on my other players (fuze v1, fuze+ and clip zip). I tried rockbox 3.13 on my fuze v2 and the games worked fine. So after trying some commits I found in which one the problem started:

https://git.rockbox.org/cgit/rockbox.git/commit/?h=v3.14&id=a1842c04f9cb73210d4cacde61a9e4b115050765

In this file
https://git.rockbox.org/cgit/rockbox.git/diff/apps/plugins/rockboy/lcd.c?h=v3.14&id=a1842c04f9cb73210d4cacde61a9e4b115050765
these lines were removed:

-#if LCD_PIXELFORMAT == RGB565
     c = r|g|b;
-#elif LCD_PIXELFORMAT == RGB565SWAPPED
-    c = swap16(r|g|b);
-#endif

After adding them back to the current build, games work fine again on my fuze v2.

But according to this file
https://git.rockbox.org/cgit/rockbox.git/tree/firmware/export/lcd.h?id=386b6d6bae020b9aafe5f572173a3bfb5d319f6a
there are other values for LCD_PIXELFORMAT like RGB888, XRGB8888, HORIZONTAL_PACKING, VERTICAL_INTERLEAVED,... so maybe the "if" should be written in a different way.

Navigation

[0] Message Index