Sansa E200V2 Bootloader is broken in master

[bahus]

Bootloader built from master doesn't fit in the firmware.

Code: [Select]

./mkamsboot e200pf.bin bootloader-e200v2.sansa e200pf.bin.patched

[ERR]  Packed data (132960 bytes) doesn't fit in the firmware (120860 bytes)

Firmware file: https://mp3support.sandisk.com/firmware/e200/e200v203.01.16f.zip


I found an old issue: https://www.rockbox.org/tracker/task/12380

But suggested workaround with --thumb flag no longer works:

Code: [Select]

[ERR]  Packed data (131229 bytes) doesn't fit in the firmware (120860 bytes)

Any idea how to fix? Ideally I'd like to enable multiboot/boot redirect for this device. Can I somehow disable logo or completely disable any graphic related logic and make it boot only in text mode or something.

[saratoga]

What I would do is grab a .map file for an older build that works (maybe we still have them on the server?) and the map file for your build that's too big and see if any large, new items appear. It is possible something was included that could be be removed or shrunk.

[bahus]

What I would do is grab a .map file for an older build that works.

According to FS#12380 issue is introduced in
https://github.com/Rockbox/rockbox/commit/f443e7bbf7771ce3a79b1c2116b9cf216f15938f

I created build for earlier commit https://github.com/Rockbox/rockbox/commit/6223ad26 and it also fails to fit "as is" but works with --thumb flag. My guess it's due to more recent build tools. Still it's considerably smaller in size and can still be used for inspection:
master - 101 Kb
6223ad26 (with latest build tools) - 84.5 Kb
Official bootloader - 79 Kb

Bootloaders with map/elf files are uploaded here: https://mega.nz/file/1GAznbAJ#ClNdPEILinBuRdbmPbuUzy7MXP1NE4OvxwVlbGrgFHE

[saratoga]

Yes I see in the .map the transparency blending functions take a few kilobytes.  It might make sense to disable that for the bootloader.  You could also disable the logo for the bootloader which is only shown for a split second since the bootloader on the e200v2 barely does anything.  I doubt it would even be noticeable if it weren't loaded since there is no time to see it.

[bahus]

Is it safe to disable the following USB defines for bootloader:

Code: [Select]

#define HAVE_USBSTACK
#define HAVE_BOOTLOADER_USB_MODE

[bahus]

I applied some trimming and enabled multiboot/boot redirect:
https://github.com/bahusoid/rockbox/tree/e200V2Boot

And I still need 6 kilobytes:
Packed data (126895 bytes) doesn't fit in the firmware (120860 bytes)

Here is size comparison with bootloader from 2011.11.08_6223ad26:
https://gist.github.com/bahusoid/d627e4d19e3d99906ba20a7cdfc9872b

What else can be trimmed?

With HAVE_USBSTACK and HAVE_BOOTLOADER_USB_MODE disabled it fits. But is it really safe?

[saratoga]

USB in the bootloader is helpful if you don't have a .rockbox binary or otherwise cannot boot, so disabling it isn't a good idea. 

[bahus]

Ok I've been able to make a build that fits (only --thumb build). Can someone please review my changes to make sure they are safe (at least in theory):
https://github.com/bahusoid/rockbox/tree/e200V2Boot


Max allowed size: 120860
Thumb build: 120256 (fits!)
No thumb: 121842

Disabled:
Logo;
alpha blending capabilities for bitmaps;
Non default locales (only utf-8 and latin left);
Arm stack unwinder (needed for backtrace);

Enabled:
Boot redirect (to allow loading from SD card)

[bahus]

Flashed it and rockbox doesn't boot (black screen with no indications). Luckily dual boot still works.. Will investigate if it's me or some changes in master...

[bahus]

Flashed it and rockbox doesn't boot (black screen with no indications).

It's not me. The same changes applied to 4 years old commit work! Sd card boot also works!
https://github.com/bahusoid/rockbox/tree/e200V2_24.10.2020

[speachy]

Would you consider doing a 'git bisect' on this to narrow down when it breaks?  4 years is a looong time.

(Also, did you use the same toolchains for the new vs old builds?)

[bahus]

Would you consider doing a 'git bisect'

Yes. Offending commit:

commit 3301c5aa6db76832dbb9af8f72d29b348190fd91
Author: Aidan MacDonald <amachronic@protonmail.com>
Date:   Sat Oct 15 23:14:27 2022 +0100

    Remove buflib allocation names, part one
   
    Remove the name handling code, but leave the allocation structure
    otherwise untouched; it's as if all callers provided a NULL name.
    The public API still accepts names but names are no longer stored
    or returned.
   
    Change-Id: I6c4defcdfd255774f02030949a0fd731477e6a54

Full logs here: https://gist.github.com/bahusoid/70f69bb46644851a75fe6db7c45fffab

All builds were made with the same latest toolchains. My guess would be that e200V2 is not the only bootloader that's broken by it.

[Bilgus]

Ah the long tail..

IM way AFK ATM but i can confirm the bootloaders for clip plus and the zip are not affected

I already did a lot to get the clip plus bootloader to fit and some of that can probably be applicable to the e200 can have a look in about a week

[bahus]

IM way AFK ATM but i can confirm the bootloaders for clip plus and the zip are not affected

Just to confirm. Are you saying that bootloader for Sansa Clip+/Zip  built from master still boots Rockbox just fine? As my initial rant was about size.  But I've been able to fit it and it doesn't boot after 3301c5aa (black screen, RB doesn't boot).

[Bilgus]

IM saying that buflib commit hasn't affected the others mentioned

And i went thru those bootloaders previously to make them fit and left some wiggle room

Some of those things might work on the e200 to buy you some space