Rockbox Development > Starting Development and Compiling
Sansa E200V2 Bootloader is broken in master
amachronic:
--- Quote from: bahus on March 31, 2024, 03:38:37 AM ---So it makes my changes in unicode.c unnecessary, doesn't it?
--- End quote ---
Yes.
--- Quote from: bahus on March 31, 2024, 03:38:37 AM ---Also backtraces are not present in current bootloader release so it's not something we removed from released functionality.
--- End quote ---
OK, if it's not a regression that's fine with me.
Everything I've done is merged so let me know when you want to merge your changes. I also merged the multiboot v1 patches.
bahus:
--- Quote from: Bilgus on March 30, 2024, 08:50:05 AM ---build them on top of his patchsets he isn't going to get upset
--- End quote ---
Not sure what you meant. But I've already cherry picked amachronic's patches to my local branch and reported results:
--- Quote from: bahus on March 30, 2024, 03:41:15 AM ---
--- Quote from: Bilgus on March 30, 2024, 12:18:17 AM ---Also we don't make new bootloaders often so could you test some of these patches with your builds?
--- End quote ---
It works for me and adds around 100 bytes to thumb size (119676 without, 119759 with those patches)
--- End quote ---
bahus:
--- Quote from: amachronic on March 31, 2024, 12:53:30 PM ---Everything I've done is merged so let me know when you want to merge your changes. I also merged the multiboot v1 patches.
--- End quote ---
I tested bootloader on top of the latest changes - it works. So I think it's ready to be merged.
Bilgus:
--- Quote from: bahus on March 29, 2024, 05:38:58 AM ---Out of curiosity I tested this no thumb build without `usb_storage_disconnect` fix. Still doesn't boot. So it doesn't look like some alignment issue to me. `usb_storage_disconnect` is the cause...
--- End quote ---
agreed -- thatd be our smoking gun
Navigation
[0] Message Index
[*] Previous page
Go to full version