Rockbox Development > Starting Development and Compiling

Sansa E200V2 Bootloader is broken in master

<< < (5/8) > >>

bahus:
I prepared change requests (a bit cleaned up version):
https://gerrit.rockbox.org/r/c/rockbox/+/5611
https://gerrit.rockbox.org/r/c/rockbox/+/5612


--- Quote from: Bilgus on March 26, 2024, 07:45:15 PM ---try boosting dcdc voltages or force into non HS mode in the sd driver

--- End quote ---

Thanks. Will look into it.

Bilgus:
Amachronic found a few thing to allow this to fit check for the patches up on gerrit
it consists of your changes minus the thumb and removing tracebacks
and then defining DEFAULT_CP_STATIC_ALLOC for unicode

and
--- Code: ---void usb_storage_disconnect(void)
{
#if !defined(BOOTLOADER)
    usb_handle = core_free(usb_handle);
#endif
    (void)usb_handle;
}
--- End code ---
in usb_storage.c

and
--- Code: ---/* Priority in bootloader is wanted */
#if !defined(SANSA_E200V2)
#define HAVE_PRIORITY_SCHEDULING
#endif
--- End code ---
in config.h

Edit:
oh and making lcd_scroll_stop and Lcd_viewport_scroll_stop dummy functions

amachronic:
Yeah, disabling prio scheduling on top of those two patches is actually all you need to make it fit without --thumb: https://gerrit.rockbox.org/r/c/rockbox/+/5615/2

bahus:
Modifying 'usb_storage_disconnect` as you suggested fixed it for me. Now bootloader on top of master is fully functional (thumb build with SD boot 119673 out of  allowed 120860 bytes).
Will you make this change or should I add it to my change request?


--- Quote from: amachronic on March 28, 2024, 06:59:23 PM ---Yeah, disabling prio scheduling on top of those two patches is actually all you need to make it fit without --thumb: https://gerrit.rockbox.org/r/c/rockbox/+/5615/2

--- End quote ---

I'm not personally concerned about thumb or no thumb build. Thumb build now works so I see no point disabling priority handling to make no thumb build fit.

UPDATE

--- Quote from: amachronic on March 28, 2024, 06:59:23 PM ---Yeah, disabling prio scheduling on top of those two patches is actually all you need to make it fit without --thumb: https://gerrit.rockbox.org/r/c/rockbox/+/5615/2

--- End quote ---

Out of curiosity I tested this no thumb build without `usb_storage_disconnect` fix. Still doesn't boot. So it doesn't look like some alignment issue to me. `usb_storage_disconnect` is the cause...

Bilgus:
you have the device. IMO it makes the most sense for you to do a patch

Navigation

[0] Message Index

[#] Next page

[*] Previous page