Support and General Use > Theming and Appearance Customization
What features should be added to theming spec?
speachy:
I'm not a fan of themes having untranslatable strings.
For this specific use case, I wonder if it doesn't make more sense to add a global configuration option to give a given device a unique name (defaulting to "rockbox player" or "ipod4g" or whatever) then give the theme engine access to that? This way it's clear that it's a user-specified string.
iPodVT:
--- Quote from: speachy on June 11, 2023, 12:19:24 PM ---For this specific use case, I wonder if it doesn't make more sense to add a global configuration option to give a given device a unique name (defaulting to "rockbox player" or "ipod4g" or whatever) then give the theme engine access to that? This way it's clear that it's a user-specified string.
--- End quote ---
That sounds good, but I'm not sure I understand the specifics: do you mean there would be something in Settings that would allow the user to specify a piece of text that a theme could retrieve? In any case, I think the mechanism should allow for the possibility that the data might be zero length (either by default or by the user's choice) and then the theme, recognizing the absence, could knowingly do the right thing.
Dook:
--- Quote from: Frankenpod on June 10, 2023, 04:57:17 PM ---Maybe an option when displaying album art to rotate it?
Either in increments of 90degrees in the plane of the screen (i.e. ability to show it sideways or upside down) or (presumably more complex and more work for the device's processor) to display it with a perspective change, as if rotated perpendicular to the screen (kind of like what happens with the Picture Flow plugin or the ipod's original 'cover flow'). Some themes already have a kind of faked perspective rotation effect which really just clips off the edges of the image but doesn't actually change the perspective.
--- End quote ---
Yeah, I'd like to see have a lot more options with album art. I've seen some people try and build a vertical UI for ipods, maybe some kind of different viewport that is drawn at a specific angle could be a solution?
speachy:
--- Quote from: iPodVT on June 11, 2023, 12:45:34 PM ---That sounds good, but I'm not sure I understand the specifics: do you mean there would be something in Settings that would allow the user to specify a piece of text that a theme could retrieve? In any case, I think the mechanism should allow for the possibility that the data might be zero length (either by default or by the user's choice) and then the theme, recognizing the absence, could knowingly do the right thing.
--- End quote ---
Here's a first cut at this. It defaults to the player type (eg 'ipod5g' or whatever), so for it to be blank it has to be explicitly set that way by the user:
https://gerrit.rockbox.org/r/c/rockbox/+/5753
iPodVT:
--- Quote from: speachy on May 31, 2024, 10:37:09 AM ---Here's a first cut at this. It defaults to the player type (eg 'ipod5g' or whatever), so for it to be blank it has to be explicitly set that way by the user:
https://gerrit.rockbox.org/r/c/rockbox/+/5753
--- End quote ---
Thank you very much for this. Is this now available in the most current dev build? I installed it, and looked at [edit] the most current version of the user manual but didn't find anything relating to this. I'll check it all again in the morning to see if it has been posted.
It was a startling coincidence to me that you used the example of "George's iPod" on the gerrit page. My most treasured iPod is a 7th Gen Classic that originally belonged to my father, George, who passed away almost three years ago. It will mean a lot to me to use this new feature on his iPod. Again, thanks very much.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version