Support and General Use > Audio Playback, Database and Playlists

Playlist playback bug

(1/1)

rockbox_dev123:
There is a reproducible bug where:

If I open a playlist (or a file in a folder) and seek in the file, let go of the right seek key, and press the button to skip the track immediately and then seek again in the next track rockbox will jump to the next album in the parent directory if I browsed to an album via Files. Or if I am in a playlist it is jumping to a particular album/folder on disk regardless of if this album exists in the actual playlist!

I am able to reproduce this bug with the latest nightly for the ipod6g with no customisations using cabbiev2.

I've recorded a couple of videos on my phone to illustrate this. Is anyone able to reproduce the bug or able to suggest where I might look in the code base to diagnose further?

bahus:
It's not a bug -  it's a feature :) Next/Prev directory action is mapped to this buttons combination. From the manual:
Short Right + Long Right      Skip to the next directory.
Short Left   + Long Left        Skip to the previous directory

If custom build is not an issue you can disable this behavior by removing the following parts:
https://github.com/Rockbox/rockbox/blob/78c92c5ca85d275e43bacf0d9948ce9b94605f6e/apps/gui/wps.c#L858-L869
and
https://github.com/Rockbox/rockbox/blob/78c92c5ca85d275e43bacf0d9948ce9b94605f6e/apps/gui/wps.c#L876-L885

rockbox_dev123:

--- Quote from: bahus on April 11, 2023, 02:41:45 PM ---It's not a bug -  it's a feature :) Next/Prev directory action is mapped to this buttons combination. From the manual:
Short Right + Long Right      Skip to the next directory.
Short Left   + Long Left        Skip to the previous directory

If custom build is not an issue you can disable this behavior by removing the following parts:
https://github.com/Rockbox/rockbox/blob/78c92c5ca85d275e43bacf0d9948ce9b94605f6e/apps/gui/wps.c#L858-L869
and
https://github.com/Rockbox/rockbox/blob/78c92c5ca85d275e43bacf0d9948ce9b94605f6e/apps/gui/wps.c#L876-L885

--- End quote ---

Thank you very much for the reply bahus. I am maintaining my own fork here so I will comment out the sections that you have highlighted!

chris_s:
It doesn't seem to check whether the current playlist has been modified before discarding it. That part feels like something that should be fixed.

edit: Oh, looks like that's already being addressed by amachronic (g5189, WIP)

Navigation

[0] Message Index