Removing the corner rounding from iPod reFresh themes

[HACKRCHILD]

Hi everyone,

I have stumbled upon what i think is the best theme for the ipod classic, iPod reFresh (one,two,three,four). Huge thanks to the creator, this theme is beautiful without being cluttered.

I have one massive gripe with it though and that is the corner rounding it does. For me personally i prefer to have the whole display used rather than artificial rounding.

Also the rounding on the cover art pops in and out of being square when songs are opened and tracks are changed.

My question is...... is there a way to disable this effect?

Alternatively how hard is it to edit the theme myself to remove this?

And if all of the above fails, how can i get hold of the theme creator? does he go by a differant username on this forum? (Ciprian Dragu)

Many thanks.

[rockbox_dev123]

I already did this 

Attached are the WPS files to remove the rounded corners of the album art for themes one and four.

If you compare/diff the original wps files and my changes it should be obvious how to do it for the other themes.

[rockbox_dev123]

I've attached some more edits I made to this theme and I've included screenshots of the how the changes look.

I recently added ReplayGain to my iPod library and needed a way to see if the tags were being read correctly.

[Dook]

If you're looking to do this for other themes, the most common method is using 4 small images to mask the corners. If you go into the wps, you should be able to find these by looking for their filenames from the theme's asset folder. Remove the %xd functions for these images, and the effect should be removed

[rockbox_dev123]

...the rounding on the cover art pops in and out of being square when songs are opened and tracks are changed.

Dook, are you able to explain how you've managed to avoid this issue with your adwaitapod themes? Its extremely rare to see the loading of the corner masking images after the artwork is displayed on your themes.

I had a read of your blog https://d00k.net/knowledge/ipod_modding/rockbox_theming/overlay_images/ on this subject, but it hasn't helped me in my tests with this issue.

I've tried to preload a conditional viewpoint for the reFresh themes like this:

Code: [Select]

#-- Album art (with round corners)
%?C<%Vd(Album)|>
%Vl(Album,13,30,136,136,-)
%Cl(0,0,136,136)
%Cd
%xd(w)%xd(x)%xd(y)%xd(z)

This also follows the logic of the Wiki defined here:
https://download.rockbox.org/daily/manual/rockbox-ipod6g/rockbox-buildch13.html#x16-40400013.2.2

Under Conditional Viewports.

Images w,x,y,z are defined as:

Code: [Select]

%xl(w,cornerTL.bmp,0,0)
%xl(x,cornerTR.bmp,122,0)
%xl(y,cornerBL.bmp,0,122)
%xl(z,cornerBR.bmp,122,122)

These are the equivalent definitions of the following from adwaitapod:

Code: [Select]

%xl(TLoverlay,WpsTL.bmp)
%xl(TRoverlay,WpsTR.bmp,138,0)
%xl(BLoverlay,WpsBL.bmp,0,138)
%xl(BRoverlay,WpsBR.bmp,138,138)

and it seems you call them like so:

Code: [Select]

%?C<%xd(TLoverlay)%xd(TRoverlay)%xd(BLoverlay)%xd(BRoverlay)
Whats the secret? 

[Dook]

Apologies for the late response! The page on my site on topic is actually pretty old, since then I've changed how I load images.

It's actually not the masking images at fault here, but rather the album art loading. Typically both the masking and album art would be drawn in conflict with each other on the same layer, which is what causes the lag in rounded corners. For adwaitapod, I had to put the album art in the background layer, and the masking on the regular layer, in order to use transparent bitmaps for anti-aliased corners.

I don't think my solution however is the best to copy from. Both me and Chris S were working on the same idea independently, and I believe their implementation in Interpod is far more flexible. Mine is built to be as small as I can make it, but it doesn't work well with full background images. Whereas Chris' does work with a background image (also way easier to read)

So my advice would be to check out how Interpod does it! If I have some time later this week, I might try my hand at adding it to your version of reFresh though.

[philden]

Presumably this assumes the artwork is square? If you have scans of boxed sets or digipack CDs the results may look untidy.

[Dook]

Presumably this assumes the artwork is square? If you have scans of boxed sets or digipack CDs the results may look untidy.

Unfortunately, yes. This is an issue with most themes that use rounding methods, recently I've begun adding toggles to my themes that users can turn off rounding with.

[rockbox_dev123]

Apologies for the late response!

No worries! Thanks for the reply.

If I have some time over a weekend I'll take another look at the background layer rendering and also your suggestion of studying Interpod.