Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
translations translations
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Audio Playback, Database and Playlists
| | |-+  Playlist playback bug
« previous next »
  • Print
Pages: [1]

Author Topic: Playlist playback bug  (Read 987 times)

Offline rockbox_dev123

  • Member
  • *
  • Posts: 161
Playlist playback bug
« on: April 11, 2023, 12:30:01 PM »
There is a reproducible bug where:

If I open a playlist (or a file in a folder) and seek in the file, let go of the right seek key, and press the button to skip the track immediately and then seek again in the next track rockbox will jump to the next album in the parent directory if I browsed to an album via Files. Or if I am in a playlist it is jumping to a particular album/folder on disk regardless of if this album exists in the actual playlist!

I am able to reproduce this bug with the latest nightly for the ipod6g with no customisations using cabbiev2.

I've recorded a couple of videos on my phone to illustrate this. Is anyone able to reproduce the bug or able to suggest where I might look in the code base to diagnose further?
Logged

Offline bahus

  • Member
  • *
  • Posts: 208
Re: Playlist playback bug
« Reply #1 on: April 11, 2023, 02:41:45 PM »
It's not a bug -  it's a feature :) Next/Prev directory action is mapped to this buttons combination. From the manual:
Short Right + Long Right      Skip to the next directory.
Short Left   + Long Left        Skip to the previous directory

If custom build is not an issue you can disable this behavior by removing the following parts:
https://github.com/Rockbox/rockbox/blob/78c92c5ca85d275e43bacf0d9948ce9b94605f6e/apps/gui/wps.c#L858-L869
and
https://github.com/Rockbox/rockbox/blob/78c92c5ca85d275e43bacf0d9948ce9b94605f6e/apps/gui/wps.c#L876-L885
« Last Edit: April 11, 2023, 03:56:28 PM by bahus »
Logged

Offline rockbox_dev123

  • Member
  • *
  • Posts: 161
Re: Playlist playback bug
« Reply #2 on: April 12, 2023, 05:35:23 AM »
Quote from: bahus on April 11, 2023, 02:41:45 PM
It's not a bug -  it's a feature :) Next/Prev directory action is mapped to this buttons combination. From the manual:
Short Right + Long Right      Skip to the next directory.
Short Left   + Long Left        Skip to the previous directory

If custom build is not an issue you can disable this behavior by removing the following parts:
https://github.com/Rockbox/rockbox/blob/78c92c5ca85d275e43bacf0d9948ce9b94605f6e/apps/gui/wps.c#L858-L869
and
https://github.com/Rockbox/rockbox/blob/78c92c5ca85d275e43bacf0d9948ce9b94605f6e/apps/gui/wps.c#L876-L885

Thank you very much for the reply bahus. I am maintaining my own fork here so I will comment out the sections that you have highlighted!
Logged

Offline chris_s

  • Developer
  • Member
  • *
  • Posts: 299
Re: Playlist playback bug
« Reply #3 on: April 16, 2023, 04:06:58 PM »
It doesn't seem to check whether the current playlist has been modified before discarding it. That part feels like something that should be fixed.

edit: Oh, looks like that's already being addressed by amachronic (g5189, WIP)
« Last Edit: April 16, 2023, 05:59:31 PM by chris_s »
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Audio Playback, Database and Playlists
| | |-+  Playlist playback bug
 

  • SMF 2.0.19 | SMF © 2021, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.069 seconds with 22 queries.