Support and General Use > Theming and Appearance Customization
Some 320x240 themes seem to have stopped working on recent dev versions
rockbox_dev123:
--- Quote from: Bilgus on December 08, 2023, 06:54:28 AM ---Did the fix by amachronic not work or did he forget?
--- End quote ---
https://git.rockbox.org/cgit/rockbox.git/tree/apps/settings_list.c?h=refs/heads/master
A search for "eq band 0 cutoff" returns nothing.
Frankenpod:
--- Quote from: Bilgus on December 08, 2023, 06:54:28 AM ---Did the fix by amachronic not work or did he forget?
--- End quote ---
I just noticed it still doesn't work on the most recent builds.
I wasn't clear from the reply if amachronic was explicitly saying they would apply a fix or if he was just saying that that would be the way to fix it at some point (if someone was prepared to do it). I didn't want to press the point too much, as it seems as if I'm the only one who is bothered about the issue!
rockbox_dev123:
--- Quote from: Frankenpod on December 08, 2023, 10:29:14 AM ---
--- Quote from: Bilgus on December 08, 2023, 06:54:28 AM ---Did the fix by amachronic not work or did he forget?
--- End quote ---
I just noticed it still doesn't work on the most recent builds.
I wasn't clear from the reply if amachronic was explicitly saying they would apply a fix or if he was just saying that that would be the way to fix it at some point (if someone was prepared to do it). I didn't want to press the point too much, as it seems as if I'm the only one who is bothered about the issue!
--- End quote ---
He's saying it would be the simplest thing to do to just re-add the removed settings options. This doesn't appear to have been done to master because the themes are broken still.
speachy:
--- Quote from: Frankenpod on December 07, 2023, 10:47:54 AM ---I don't suppose anyone is motivated to modify RB code so as to allow these themes to work again?
--- End quote ---
I'm not personally in favor of bringing the old settings back; instead the theme engine should be fixed and the theme altered as needed.
The fundamental issue here is that the EQ settings are a triplet, and that the skin engine doesn't know how to handle this.
I just hacked something together that _should_ do the trick, but it may be the wrong approach (and I don't know if it's possible to do this in a backwards-compatible manner) To use it the theme will need to be tweaked. See:
https://gerrit.rockbox.org/r/c/rockbox/+/5532
Be warned: I can promise that it compiles, but that's the extent of the testing it's received.
Frankenpod:
Thanks very much.
Can't say I understand the technicalities of it all (how did it work previously, if the parameters being an array is something the theme engine can't handle? Did it just work entirely by accident before?).
Will try modifying some themes to the new syntax - but does this mean I'll need to compile a patched version of RB first?
[Edit] I really struggle to do that - I did have a working development environment running at one point, but then my unix machine had a lot of hardware problems, and when I finally got it working again and tried again I could never again manage to get RB to build successfully, there always seemed to be some glitch or other.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version