Support and General Use > Theming and Appearance Customization

Some 320x240 themes seem to have stopped working on recent dev versions

(1/3) > >>

Noticed that some themes of mine (and also the theme "redbox") have started falling back to the failsafe theme, when used with recent dev versions of RB.  Just checked and they still seem to be working on ipods that have older versions of RB on them (e.g. they work with version dated 210409 but not with 221221).  They seem to work with the simulator also.

(Heh, though the fact that nobody else has complained suggests nobody but me uses them)

I might be barking up the wrong tree (tedious to work it out as the themes still work on the simulators - presumably because they use older versions of RB), but as far as I can narrow it down it seems to be any theme that has a bar-chart for the EQ settings in it.

i.e. the problem seems to be with lines like this:
%St(0,0,-,-,image,eqbar.bmp,vertical,setting,eq band 1 gain)
Seems as if "eq band 1 gain" is no longer recognised as a valid setting value.

Using "eq peak filter 1" instead doesn't crash the theme, but returns three numbers, the third of which I think is the gain, but it doesn't seem possible to retrieve the gain on its own now.

Has something changed in how these values are named, or perhaps the scope of where they can be accessed?  What does "eq band N gain" need to be changed to for this to work again?

It likely broke after those EQ settings were removed by this commit. I'll just put the "deprecated" settings back in - that seems like the simplest solution and won't require changing any themes.

If you think that's the best approach, by all means go with it.  (I think all but one of the themes that have the problem are mine, as it happens)

  Can't say I really know anything about the underlying issue (were there previously two ways, internally, of referring to the same variables?).

I don't suppose anyone is motivated to modify RB code so as to allow these themes to work again?

That is, somehow allow the eq band settings to be accessed by the theme engine again?  Even if it means changing the variable names or something, such that the themes would need amending for new syntax?  At the moment it seems those settings are now entirely inaccessible from the theme engine.

Just hoping some dev might be prepared to at least partly undo the change that broke this feature.

Did the fix by amachronic not work or did he forget?


[0] Message Index

[#] Next page

Go to full version