Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Rockbox Ports are now being developed for various digital audio players!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Some 320x240 themes seem to have stopped working on recent dev versions
« previous next »
  • Print
Pages: [1]

Author Topic: Some 320x240 themes seem to have stopped working on recent dev versions  (Read 185 times)

Offline Frankenpod

  • Member
  • *
  • Posts: 641
Some 320x240 themes seem to have stopped working on recent dev versions
« on: December 25, 2022, 07:12:29 AM »
Noticed that some themes of mine (and also the theme "redbox") have started falling back to the failsafe theme, when used with recent dev versions of RB.  Just checked and they still seem to be working on ipods that have older versions of RB on them (e.g. they work with version dated 210409 but not with 221221).  They seem to work with the simulator also.

(Heh, though the fact that nobody else has complained suggests nobody but me uses them)

I might be barking up the wrong tree (tedious to work it out as the themes still work on the simulators - presumably because they use older versions of RB), but as far as I can narrow it down it seems to be any theme that has a bar-chart for the EQ settings in it.

i.e. the problem seems to be with lines like this:
%St(0,0,-,-,image,eqbar.bmp,vertical,setting,eq band 1 gain)
 
Seems as if "eq band 1 gain" is no longer recognised as a valid setting value.

Using "eq peak filter 1" instead doesn't crash the theme, but returns three numbers, the third of which I think is the gain, but it doesn't seem possible to retrieve the gain on its own now.

Has something changed in how these values are named, or perhaps the scope of where they can be accessed?  What does "eq band N gain" need to be changed to for this to work again?
Logged

Offline amachronic

  • Developer
  • Member
  • *
  • Posts: 271
Re: Some 320x240 themes seem to have stopped working on recent dev versions
« Reply #1 on: December 26, 2022, 07:13:50 AM »
It likely broke after those EQ settings were removed by this commit. I'll just put the "deprecated" settings back in - that seems like the simplest solution and won't require changing any themes.
Logged

Offline Frankenpod

  • Member
  • *
  • Posts: 641
Re: Some 320x240 themes seem to have stopped working on recent dev versions
« Reply #2 on: December 26, 2022, 10:58:53 AM »
If you think that's the best approach, by all means go with it.  (I think all but one of the themes that have the problem are mine, as it happens)

  Can't say I really know anything about the underlying issue (were there previously two ways, internally, of referring to the same variables?).
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Some 320x240 themes seem to have stopped working on recent dev versions
 

  • SMF 2.0.19 | SMF © 2021, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.041 seconds with 17 queries.