Several bugs in 11/22/22 dev release on iPod Video 5.5 Gen

[chris_s]

Seems like something in the plug-ins resets that option to 'always on'.

Yes, that is on purpose. But as far as I can tell, the plugins also reset it back to the user setting, but somehow this doesn't always take effect.

I've had it happen with PictureFlow as well, but I never noticed it anymore after applying my "fix" (which I don't think really fixes it and I don't see how it could...if that makes sense).

Is the content of that menu in any way dependent on any aspect of the actual battery that is in the iPod?

I don't think so.

[Frankenpod]

 I just checked and get the same issue (empty battery capacity menu) with the 23/11 version on a 5th gen.

I didn't _think_ the battery options had anything to do with the actual battery.  The 5th and 6th gens are not the same though, so I suppose it's possible the original error is, for some reason, still present in the 5th gen version of RB?  Could the fix not have been applied to that version?


Hmmm, can't find any other empty menus on the 5th gen.  Does the 5th gen have a different number of options in that battery capacity menu than the 6th gen, and maybe that determines if the error shows up or not?  The screen res is of course the same.

[chris_s]

ok, just figured out why the backlight didn't turn off after quitting Rockblox, specifically. The ifdef was misspelled (HAVE_BACKLIGNT instead of HAVE_BACKLIGHT). Doesn't explain what I used to (sometimes) see with other plugins, like PictureFlow though...

[chris_s]

same issue (empty battery capacity menu) with the 23/11 version on a 5th gen.
...

Does the 5th gen have a different number of options in that battery capacity menu than the 6th gen, and maybe that determines if the error shows up or not?

The increment (and default capacity) is different:

5th/Video:
#define BATTERY_CAPACITY_INC       50 /* capacity increment */

6g:
#define BATTERY_CAPACITY_INC      10 /* capacity increment */

[Frankenpod]

I don't really know about the underlying code, of course.  But there must be some reason why the error with displaying menus that the earlier changes introduced has now been fixed in the 6th gen but seems to still be present in the 5th gen.

  Are the two updated entirely independently, so could it be as simple as the fix simply hasn't been applied for the 5th gen?  Or is it that the error is still there in both but only shows up in the 5th gen for some reason to do with those different battery increments?

[Frankenpod]

ok, just figured out why the backlight didn't turn off after quitting Rockblox, specifically. The ifdef was misspelled (HAVE_BACKLIGNT instead of HAVE_BACKLIGHT). Doesn't explain what I used to (sometimes) see with other plugins, like PictureFlow though...

 
Yeah, I'm pretty sure it happens with Jewels as well.  That and rockblox are the only games I play on them, though.  Could they all have the same typo (the same line having been cut'n'pasted)?

[chris_s]

I don't really know about the underlying code, of course.  But there must be some reason why the error with displaying menus that the earlier changes introduced has now been fixed in the 6th gen but seems to still be present in the 5th gen.

  Are the two updated entirely independently, so could it be as simple as the fix simply hasn't been applied for the 5th gen?  Or is it that the error is still there in both but only shows up in the 5th gen for some reason to do with those different battery increments?

The latter. I'm guessing bilgus will be kind enough to take a look at it when he gets the time.

Yeah, I'm pretty sure it happens with Jewels as well.  That and rockblox are the only games I play on them, though.  Could they all have the same typo (the same line having been cut'n'pasted)?

Jewels doesn't seem to change the backlight timeout at all from what I see at first glance. Would be surprising if it prevented the backlight from turning off after quitting. I didn't find a typo anywhere else so far.

[Bilgus]

Should be fixed as of yesterday maybe try today's build otherwise I might have missed something

Oh you already did I'll look at it this evening

[Bilgus]

Looking at the source the int_setting used is already fixed might try redownloading and renaming your current .rockbox directory and do a clean install by copying the new install to your root

[iPodVT]

Looking at the source the int_setting used is already fixed might try redownloading and renaming your current .rockbox directory and do a clean install by copying the new install to your root

I just now did a clean install on the 5.5 Gen per your instructions, and the Battery Capacity menu is still empty.

[Bilgus]

I found the issue will have a patch in an hour

[Frankenpod]

Yeah, I'm pretty sure it happens with Jewels as well.  That and rockblox are the only games I play on them, though.  Could they all have the same typo (the same line having been cut'n'pasted)?

Jewels doesn't seem to change the backlight timeout at all from what I see at first glance. Would be surprising if it prevented the backlight from turning off after quitting. I didn't find a typo anywhere else so far.

Huh, just tested it (on 221025 version) and it _doesn't_ seem to happen with Jewels (but does with rockblox).  I guess I misremembered that - unless it's an intermittent glitch,  maybe it is in fact only rockblox it happens with, and the typo you found _was_ the cause?

[Bilgus]

IpodVT I think I got this in soon enough to grab from the dev builds page but if not here is a link to the latest
https://www.mediafire.com/file/prv2mvfxcbtyjpv/iPodVideo_80b8b135_rockbox.zip/file

[iPodVT]

IpodVT I think I got this in soon enough to grab from the dev builds page but if not here is a link to the latest
https://www.mediafire.com/file/prv2mvfxcbtyjpv/iPodVideo_80b8b135_rockbox.zip/file

I grabbed it from your link, installed it, and the Battery Capacity menu is once again populated.

Your dedication is heroic - thank you!

[iPodVT]

Actually, heroic dedication seems to be a trait of lots of people around here.  Thank you to everyone who contributes to making Rockbox better and better.  (And it's already great!)