[SHARE] Chiptune codecs collection (and Android port).

[gama]

Hi,  I would like to drop here a link of my private rockbox repo, which contains a set of new videogame music codecs I have been working on during the past months, along with the android changes I uploaded to the rockbox tracker (https://www.rockbox.org/tracker/task/13339).

If anyone is interested feel free to take a look at the sources and make a build on your own.
I have not tested other targets other than Android and simulator.  I use WSL2 in Windows 10, more about this in the tracker link above.

The codecs I worked on are:

  - Update Game_Music_Emu codecs to latest version from kode54 repo.
  - Added new SPC codec based on higan emulation by kode54.
  - Created a DUMB codec.
  - Created a sidplay fp codec by porting the whole sidplayfp library to c.
  - Created a UADE codec using a modified version of libuade.
  - Created a new VGM (s98) codec based on libvgm.
  - Created an sc68 codec based on sc68 library.
  - Created a PSF codec based on libupse.
  - Created a GSF codec based on viogsf.

All these codecs need too much ram (more than 64 MB), and some rely on multi threading to play fine.  So some changes to the codec api where made and I used the tlsf library for dynamic memory allocation.

That is why I created them specifically with the Android port in mind and decided to not upload a patch to the tracker.

If anyone is interested in building the code or talking about the codecs,  feel free to send me a pm or contact me through mail.

The sources link: https://drive.google.com/file/d/18SLmbBHd3_sK-WGkhmiWdnkf8vtyKOEG/view?usp=sharing
1920x1080 apk: https://drive.google.com/file/d/1G_0kraTAlhn1AuidKnzfOPlMnS4m_6Fz/view?usp=sharing
1280x800 apk: https://drive.google.com/file/d/1xNCeI7G9Nj0Mb41k0YBXZyyKv3XyFJaN/view?usp=sharing
Codecs additional data files: https://drive.google.com/file/d/1Egk5xTu0bxWBDm2uoWrhTKRXxJW86iTZ/view?usp=sharing

Long live to rockbox .
gama (gama.coder@gmail.com).

[Milardo]

Hi,  I would like to drop here a link of my private rockbox repo, which contains a set of new videogame music codecs I have been working on during the past months, along with the android changes I uploaded to the rockbox tracker (https://www.rockbox.org/tracker/task/13339).

If anyone is interested feel free to take a look at the sources and make a build on your own.
I have not tested other targets other than Android and simulator.  I use WSL2 in Windows 10, more about this in the tracker link above.

The codecs I worked on are:

  - Update Game_Music_Emu codecs to latest version from kode54 repo.
  - Added new SPC codec based on higan emulation by kode54.
  - Created a DUMB codec.
  - Created a sidplay fp codec by porting the whole sidplayfp library to c.
  - Created a UADE codec using a modified version of libuade.
  - Created a new VGM (s98) codec based on libvgm.
  - Created an sc68 codec based on sc68 library.
  - Created a PSF codec based on libupse.
  - Created a GSF codec based on viogsf.

All these codecs need too much ram (more than 64 MB), and some rely on multi threading to play fine.  So some changes to the codec api where made and I used the tlsf library for dynamic memory allocation.

That is why I created them specifically with the Android port in mind and decided to not upload a patch to the tracker.

If anyone is interested in building the code or talking about the codecs,  feel free to send me a pm or contact me through mail.

https://drive.google.com/file/d/18SLmbBHd3_sK-WGkhmiWdnkf8vtyKOEG/view?usp=sharing

Long live to rockbox .
gama (gama.coder@gmail.com).

Hi gama,

Do you have a precompiled rockbox android build I can try? I can also compile too, if you have complete and clear instructions, thanks in advance.

[amachronic]

...

You've put a lot of effort into this, and IMHO it'd be a shame not to pick up these changes. However, it's going to be very hard to integrate them in the official repo if you do them as a single mega-patch.

Changes to core code, ie. stuff under firmware/ and parts of apps/, need to be reviewed more carefully to make sure they won't cause problems on other devices. If you can roughly split up those changes into smaller patches with a well-defined purpose (this adds XXX... this is a bugfix for YYY...) that would make it much easier to review and merge. This includes any changes to the codec API.

Codecs are fine to take wholesale, but I'd prefer to split them up into one patch per codec. It's okay if they don't run on all targets. Using TLSF in codecs is also fine, some codecs already use it.

I have no experience with the Android port so I'm afraid I can't help much there, but I think once you split the supporting changes out, the truly Android-specific stuff that's left will be small and manageable.

[gama]

Hi gama,

Do you have a precompiled rockbox android build I can try? I can also compile too, if you have complete and clear instructions, thanks in advance.

Yes I was planning to add a link to a couple of files.  I only have precompiled apks for two Android resolutions: 1920x1080 and 1280x800 though.
I will update the original post with the links soon.

[gama]

You've put a lot of effort into this, and IMHO it'd be a shame not to pick up these changes. However, it's going to be very hard to integrate them in the official repo if you do them as a single mega-patch.

Changes to core code, ie. stuff under firmware/ and parts of apps/, need to be reviewed more carefully to make sure they won't cause problems on other devices. If you can roughly split up those changes into smaller patches with a well-defined purpose (this adds XXX... this is a bugfix for YYY...) that would make it much easier to review and merge. This includes any changes to the codec API.

Codecs are fine to take wholesale, but I'd prefer to split them up into one patch per codec. It's okay if they don't run on all targets. Using TLSF in codecs is also fine, some codecs already use it.

I have no experience with the Android port so I'm afraid I can't help much there, but I think once you split the supporting changes out, the truly Android-specific stuff that's left will be small and manageable.

Thanks for your reply amachronic.

Unfortunately the code is kind of a mess right now :S, and takes me a lot of time to create a patch from it. 
But I will try to when I have some time.