Corrupted "Now Playing Theme" UPDATED

[Braverman]

I use Friskey2 as both my base skin and the now playing skin.
Had some major trouble with my 2 e280 Sansa's and now I can not get the Now Playing Skin to be that, but any others will. I've tried re-installing, but I'd like to "uninstall" just that and then re-install, but can't figure out how to do that without uninstalling everything.
Any help would be GREATLY appreciated.
************** UPdate ******************
Won't work with V3.15, will wit V3.14.

Can anyone tell me how to manually install 3.14 in a Sansa e280v2 which needs the Sansa firmware along with Rockbox?

[Frankenpod]

Is it at all possible it's to do with this change?

Looking at that theme, I notice it uses 14-Nimbus, in a viewport that is only 12 pixels high.  Maybe that causes an issue?  If this thread is correct, that would cause some of the text not to appear.  You'd have to change the viewport sizes from 12 to 14, or change the font from 14 to 12 point.

https://forums.rockbox.org/index.php/topic,54008.0.html

Alternatively, could it be that you simply don't have that font installed?  (that would cause the theme to default back to the failsafe theme)

[Braverman]

Is it at all possible it's to do with this change?

THANK YOU for taking the time to answer.
It is the version change, I put 3.14 on a v2 unit - (through the installer - and the screen was fine.
I also have another v2 with 3.15 - not working - and another with 3.14 that IS working.
Make sense?

Looking at that theme, I notice it uses 14-Nimbus, in a viewport that is only 12 pixels high.  Maybe that causes an issue?  If this thread is correct, that would cause some of the text not to appear.  You'd have to change the viewport sizes from 12 to 14, or change the font from 14 to 12 point.

https://forums.rockbox.org/index.php/topic,54008.0.html

I thought of that at first, but the fonts are there and it IS only the "While Playing" screen, the base theme is dandy - very readable for these old eye(s).

Alternatively, could it be that you simply don't have that font installed?  (that would cause the theme to default back to the failsafe theme)

Naw, it's there.

As the installer doesn't allow me to pick an older version (so I could let it take care of the ...) wait a minute - it only needs the Sansa firmware for the bootloader, correct? Not for Rockbox itself. hmmm
I haven't tried a manual install of 3.14 for 2 reasons, 1) bricking it and 2) I can't find the right file for v2 - IN THAT ORDER.

[Frankenpod]

You don't say in exactly what way the WPS isn't working.

The change mentioned in that other thread would mean the text not appearing - is that the problem you are having?  If not, what exactly does the WPS look like?  In what way is it not working?

Is it any better if you change to a smaller font?

[Frankenpod]

I believe to install 3.14 you just download it and unzip it to the player (telling it to overwrite all files if it asks).  But I don't have one of those players myself.

[Braverman]

You don't say in exactly what way the WPS isn't working.

Sorry, it doesn't show up - at all - I get, what I believe is - the Rockbox fail-safe screen.

The change mentioned in that other thread would mean the text not appearing - is that the problem you are having?  If not, what exactly does the WPS look like?  In what way is it not working?

Is it any better if you change to a smaller font?

Obviously see above.

The manual install would be dandy, but, the 3.15 file is called "rockbox-sansae200v2-3.15.zip", all I can find is "rockbox-sansac200v2-3.14.zip".  Note the e200 for V3.15 vs. the c200 for V3.14. Not sure if that okay.

[Bilgus]

Try the latest dev version we don't fix bugs in releases 5 years old

[Braverman]

Try the latest dev version we don't fix bugs in releases 5 years old

I wouldn't expect you to, but FYI I did - same problem.

I just wanna put 3.14 back on a v2.

***************** UPdate **********************

FINALLY found e200_v2 3.14 firmware. Manually installed, then installed fonts and the skin and copied over the config.cfg over and HELLO NURSE!

I'll see in a wee while if it lasts.

[Bilgus]

I don't have a way to update the theme but here is the fix

Friskys2.cfg

Code: [Select]

iconset: /.rockbox/icons/tango_small.bmp
viewers iconset: /.rockbox/icons/tango_small_viewers.bmp


Code: [Select]

#Theme Name: Friskys2 (based on Friskys)
#Author: M. Loster (original Theme: T. Kliemann)
#Platform: Sandisk Sansa E200 (176x220)
#Rockbox version 3.7+
#Version: 1.0, Mar 10, 2011
#Licenced CC-BY-SA 3.0
selector type: bar (gradient)
statusbar: off
scrollbar: right
foreground color: E7E7E7
background color: 000000
line selector start color: ff8605
line selector end color: ff8605
line selector text color: 000000
font: /.rockbox/fonts/14-Nimbus.fnt
wps: /.rockbox/wps/Friskys2.wps
sbs: /.rockbox/wps/Friskys2.sbs
fms: /.rockbox/wps/Friskys2.fms
iconset: /.rockbox/icons/tango_icons.12x12.bmp
viewers iconset: /.rockbox/icons/tango_icons_viewers.12x12.bmp
backdrop: Friskys2.bmp
ui viewport: 5,40,166,146,-,-,-


Friskys2.wps
I'm not sure what the %Sx directive was for but I don't see it in the engine..
FrankenPod figured it out

Code: [Select]

# Filesize / Dir Name
%V(78,136,73,16,1)%Vf(E7E7E7)%Vb(000000)
#%s%ar%fs %Sx(KB)


Code: [Select]

%wd
%X(back.bmp)
%xl(A,travel.bmp,77,20,7)
%xl(B,bat.bmp,5,17,10)
%xl(C,vol.bmp,102,17,10)
%xl(D,play.bmp,70,188)
%xl(E,pause.bmp,70,188)
%xl(F,wind.bmp,70,188)
%xl(G,rewind.bmp,70,188)
%xl(H,hddled.bmp,37,155,8)
%xl(I,lock.bmp,63,153,2)
%xl(J,charge.bmp,50,150,2)
%xl(K,repm.bmp,5,154,5)
%xl(L,shuffle.bmp,21,155,2)
#%xl(X,codec.bmp,20,137,22)
#%?fc<%xd(Xa)|%xd(Xb)|%xd(Xc)|%xd(Xd)|%xd(Xe)|%xd(Xf)|%xd(Xg)|%xd(Xh)|%xd(Xi)|%xd(Xj)|%xd(Xk)|%xd(Xl)|%xd(Xm)|%xd(Xn)|%xd(Xo)|%xd(Xp)|%xd(Xq)|%xd(Xr)|%xd(Xs)|%xd(Xt)|%xd(Xu)|%xd(Xv)>

# Virtual LED
%t(0.2)%?lh<%xd(Hb)|%xd(Ha)>;%t(0.2)%?lh<%xd(Hc)|%xd(Ha)>;%t(0.2)%?lh<%xd(Hd)|%xd(Ha)>;%t(0.2)%?lh<%xd(He)|%xd(Ha)>;%t(0.2)%?lh<%xd(Hf)|%xd(Ha)>;%t(0.2)%?lh<%xd(Hg)|%xd(Ha)>;%t(0.2)%?lh<%xd(Hh)|%xd(Ha)>

# Hold
%?mh<%xd(Ia)|%xd(Ib)>

# Shuffle
%?ps<%xd(Lb)|%xd(La)>

# Charging
%t(0.5)%?bc<%xd(Jb)|%xd(Ja)>;%t(0.5)%?bc<%xd(Ja)|%xd(Ja)>

# Repeat Mode
%?mm<%xd(Ka)|%xd(Kb)|%xd(Kc)|%xd(Kd)|%xd(Ke)>

# Playback Mode
%?mp<|%xd(D)|%xd(E)|%xd(F)|%xd(G)>

# Volume
%?pv<%xd(Ca)|%xd(Cb)|%xd(Cc)|%xd(Cd)|%xd(Ce)|%xd(Cf)|%xd(Cg)|%xd(Ch)|%xd(Ci)|%xd(Cj)>

# Battery
%t(0.5) %?bl<%xd(Ba)|%xd(Bb)|%xd(Bb)|%xd(Bc)|%xd(Bd)|%xd(Be)|%xd(Bf)|%xd(Bg)|%xd(Bh)|%xd(Bi)|%xd(Bj)>;%?bl<%t(0)|%t(0.5)%xd(Ba)|%t(0)|%t(0)|%t(0)|%t(0)|%t(0)|%t(0)|%t(0)|%t(0)|%t(0)>

# Tape Travel - complex ;)
%t(0.1) %?mp<|%xd(Ad)|%xd(Af)|%xd(Ac)|%xd(Aa)>;%t(0.3) %?mp<|%xd(Aa)|%xd(Ad)|%xd(Aa)|%xd(Ac)>;%t(0.3) %?mp<|%xd(Aa)|%xd(Ad)|%xd(Ab)|%xd(Ab)>;%t(0.1) %?mp<|%xd(Ae)|%xd(Ad)|%xd(Ab)|%xd(Ab)>;%t(0.3) %?mp<|%xd(Ad)|%xd(Ad)|%xd(Ac)|%xd(Aa)>;%t(0.3) %?mp<|%xd(Ab)|%xd(Ad)|%xd(Aa)|%xd(Ac)>;%t(0.3) %?mp<|%xd(Ab)|%xd(Ad)|%xd(Ab)|%xd(Ab)>;%t(0.1) %?mp<|%xd(Af)|%xd(Ad)|%xd(Ab)|%xd(Ab)>;%t(0.3) %?mp<|%xd(Ad)|%xd(Ad)|%xd(Ac)|%xd(Aa)>;%t(0.3) %?mp<|%xd(Ac)|%xd(Ad)|%xd(Aa)|%xd(Ac)>;%t(0.3) %?mp<|%xd(Ac)|%xd(Ab)|%xd(Ab)|%xd(Ab)>;%t(0.1) %?mp<|%xd(Ag)|%xd(Ab)|%xd(Ab)|%xd(Ab)>;%t(0.3) %?mp<|%xd(Ad)|%xd(Ab)|%xd(Ac)|%xd(Aa)>

# Battery (Text) / Sleep Timer
%V(6,4,67,12,1)%Vf(60FF05)%Vb(000000)
%s%t(5)%al%bvV%ar%bl%%;%s%t(5)%ac%bt;%?bs<%t(5)%ac%s%Sx(Sleep Timer): %bs|%t(0)>

# Volume (Text) / Clock / Date / Pitch
%V(103,4,67,12,1)%Vf(60FF05)%Vb(000000)
%t(5)%?mv(3)<%alVOL%ar%pvdB|%ac%?cf<%cH:%cM:%cS|%cI:%cM %cP>>;%t(5)%?mv(3)<%alVOL%ar%pvdB|%ac%cy/%cm/%cd>;%?Sp<%t(5)%ac%s%Sx(Pitch): %Sp|%t(0)>

# Title (Filename)
%V(6,40,147,16,1)%Vf(E7E7E7)%Vb(000000)
%s%ar%?it<%it|%Sx(<Untagged>): %fn>

# Artist (Dir name) / Album (../Dir name) / Track / Year
%V(6,57,147,16,1)%Vf(E7E7E7)%Vb(000000)
%t(8)%s%ar%?ia<%ia|%?d(1)<[%d(1)]|[root]>>;%t(6)%s%ar%?id<%id|%?d(2)<%?ia<|../[%d(2)]>|%?ia<|../[root]>>>%?in<%?id< - %Sx(Tracknum) %in|%Sx(Tracknum) %in>|>%?iy< - %iy|>

# Playlist Num / Playlist Name
%V(6,80,147,16,1)%Vf(E7E7E7)%Vb(000000)
%s%ar%# %pp/%pe %?pn<"%pn"|>

# Next Track (Next Filename)
%V(6,97,147,16,1)%Vf(E7E7E7)%Vb(000000)
%s%ar%?It<%Sx(Next:) %It - %?Ia<%Ia|>|%?Fm<%Sx(Next:) %Sx(<Untagged>): %Fm|>>

# Bitrate / Sample Rate / RepGain
%V(6,119,147,16,1)%Vf(E7E7E7)%Vb(000000)
%s%ar%fbk %?fv<VBR|CBR> %fkk %?rg<%Sx(Replaygain): %(%Sx(Off)%)|%Sx(Replaygain): %rg|%Sx(Replaygain): %rg|%Sx(Replaygain): %rg|%Sx(Replaygain): %rg|>

# Filesize / Dir Name
%V(78,136,73,16,1)%Vf(E7E7E7)%Vb(000000)
%s%ar%fs %Sx(KiB)

# Track Time (Current / Total)
%V(78,155,73,16,1)%Vf(E7E7E7)%Vb(000000)
%ar%?mp<%(%pt%)|%t(10)%pc|%t(10)%pc|%pc|%pc>;%ar%?mp<%t(0)|%t(2)%(%pt%)|%t(2)%(%pt%)|%t(0)|%t(0)>

# Codec
%V(6,135,67,15,1)%Vf(60FF05)%Vb(000000)
%ac%fc

# PBar
%V(4,173,168,8,1)%Vf(60FF05)%Vb(000000)
%pb(0,0,168,8,progbar.bmp)

# Peak Meter
%V(7,194,62,20,1)%Vf(60FF05)%Vb(000000)
%pm



[Frankenpod]

IIRC %Sx(text) causes the text in the brackets to be translated to the current language choice.

And if I also remember correctly, if it's used with text that doesn't have a translation listed, it makes the theme fall over.  I remember a long time ago thinking that was unfortunate/awkward and it would be better if it just fell back to using the untranslated English

I don't know if that's the problem the theme is having - because my conversion to 320x240 has that line still in it, and it works on the ipod classic (at least it did when I made it).  It might depend on what translations exist for each version of rockbox - perhaps the sansa with later rockbox versions doesn't have a translation listed for "KB"?


https://forums.rockbox.org/index.php?topic=52219.0

[Bilgus]

oh you know what I think I changed the Kb symbol to Kib around 3.15

and yep that fixes it!

[Bilgus]

Looking into it a little deeper it appears CHECKWPS doesn't act on those errors

I was able to find the logic in skin_parser (l:769) & skin_tokens (l:823)

We could make it output "??" in that case but we can't really get the original string value back at that point
https://gerrit.rockbox.org/r/c/rockbox/+/3894

In reference to your other question:

Code: [Select]

%?if(%Sx(KB), =, <ERR>)<KB|%Sx(KB)>

[Frankenpod]

I think outputting ?? would be preferable to the entire theme just failing.  The trouble is the translation stuff can get changed or updated independent of the theme (or the main WPS code?) and thus retrospectively cause themes to stop working, as here.
And it seems like it also varies by target.

At least if you got "??" you would get an immediate indication as to what the problem was.

Putting an error trap line into the WPS script every single time a theme uses the translation function seems a bit of a chore, but I guess it's a solution.  Maybe the suggestion to do that could be included in the Custom WPS guide?

[Bilgus]

Yes the sim may have different or missing language strings
I liked making %Sx() return '' on error as this makes the conditionals
easy %?Sx{KB)<%Sx(KB),"KB"> but then It makes it hard to catch the error
for old themes

I already find the brittleness of the theme engine quite hard to deal with itd be nicer if it spit out a log with errorThat is
if anyone is volunteering

[Braverman]

Not wanting to get involved with the programming aspect - it's been a LONG time since I programmed seriously, but the fix I see, while a bit confusing as to what constitutes the cfg file, the first set didn't fix this on 3.15.
can you be more specific? I see 2 lines that have changed, but ...

I didn't expect this to be so involved ... but I remember all too well (that's why the wife won't let me install my language machine)