Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Thank You for your continued support and contributions!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Corrupted "Now Playing Theme" UPDATED
« previous next »
  • Print
Pages: 1 [2] 3

Author Topic: Corrupted "Now Playing Theme" UPDATED  (Read 3250 times)

Offline Bilgus

  • Developer
  • Member
  • *
  • Posts: 876
Re: Corrupted "Now Playing Theme" UPDATED
« Reply #15 on: October 12, 2021, 10:24:54 AM »
you need both AFAICT...

the cfg file (/.rockbox/themes/Friskys2.cfg)
cfg file has the wrong icon names just copy paste the whole entry to the file or change the (2) lines

the wps file (/.rockbox/wps/Friskys2.wps)
just needs KiB instead of KB (Line 75)

Idk if i will work in 3.15  (maybe if you don't change the first one (.cfg) file
not sure when those icon sets changed  TBH

I tested with the latest dev version

Ive also made a patch that will make it return <ERR> when it encounters this but its not in yet -- (need to think about it for a bit)



« Last Edit: October 12, 2021, 10:28:49 AM by Bilgus »
Logged

Offline Frankenpod

  • Member
  • *
  • Posts: 641
Re: Corrupted "Now Playing Theme" UPDATED
« Reply #16 on: October 13, 2021, 09:21:14 AM »
@Bilgus


I'm not clear what you are saying.

Are you saying that putting a conditional like "%?if(%Sx(text_to_translate_goes_here), =, <ERR>)<text_to_translate_goes_here|%Sx(text_to_translate_goes_here)>"

into a WPS script will resolve the problem as things are at the moment, or are you saying that you are planning to amend the codebase in a way that will mean that fix will work in future?

To be honest, I stopped bothering to use the translate function, because there didn't seem to be any easy way to know what terms had translations available on any given target.  So a way to properly trap for such errors would seem to be very useful.
« Last Edit: October 13, 2021, 10:27:51 AM by Frankenpod »
Logged

Offline Braverman

  • Member
  • *
  • Posts: 40
Re: Corrupted "Now Playing Theme" UPDATED
« Reply #17 on: October 13, 2021, 09:48:03 AM »
Quote from: Bilgus on October 12, 2021, 10:24:54 AM
you need both AFAICT...

the cfg file (/.rockbox/themes/Friskys2.cfg)
cfg file has the wrong icon names just copy paste the whole entry to the file or change the (2) lines

the wps file (/.rockbox/wps/Friskys2.wps)
just needs KiB instead of KB (Line 75)

Idk if i will work in 3.15  (maybe if you don't change the first one (.cfg) file
not sure when those icon sets changed  TBH

I tested with the latest dev version

Ive also made a patch that will make it return <ERR> when it encounters this but its not in yet -- (need to think about it for a bit)

I appreciate your efforts in regards to this inconsequential problem that seems to affect only me, but the patches do not work. A reinstalled 3.15/Fonts still leaves me with a working base skin and a fail-safe WPS.
 
AND this is ok, you need not - obviously - bang your head on the wall just for this. I can put 3.14 back on with little or no sweat.

BUT I DO APPRECIATE YOUR EFFORTS!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
« Last Edit: October 13, 2021, 09:49:54 AM by Braverman »
Logged

Offline Frankenpod

  • Member
  • *
  • Posts: 641
Re: Corrupted "Now Playing Theme" UPDATED
« Reply #18 on: October 13, 2021, 10:26:15 AM »
@Braverman

My understanding is that Bilgus was suggesting you use the latest Dev version, rather than 3.15
Logged

Offline Braverman

  • Member
  • *
  • Posts: 40
Re: Corrupted "Now Playing Theme" UPDATED
« Reply #19 on: October 13, 2021, 11:48:19 AM »
Quote from: Frankenpod on October 13, 2021, 10:26:15 AM
@Braverman

My understanding is that Bilgus was suggesting you use the latest Dev version, rather than 3.15


As you wish you had NEVER gotten involved with this ...
Nothing works. 3.15, latest DEV build, not changing the cfg file, changing it, changing the wps etc.
AND with the dev version I can not connect the unit to the PC, have to boot into the original F/W and getting into rockbox that way.
JUST to be clear, it's only the WPS screen that screwed.
Logged

Offline Bilgus

  • Developer
  • Member
  • *
  • Posts: 876
Re: Corrupted "Now Playing Theme" UPDATED
« Reply #20 on: October 13, 2021, 12:00:41 PM »
I'll make you a build this evening with that patch I posted, we and I would rather get this fixed than the workaround being going back 2 versions
Logged

Offline Bilgus

  • Developer
  • Member
  • *
  • Posts: 876
Re: Corrupted "Now Playing Theme" UPDATED
« Reply #21 on: October 13, 2021, 12:07:46 PM »
Frankenpod that would be after the patch on Gerrit
Currently it just kills and goes to failsafe when the translation Is missing

After that patch you can trap <ERR>
Logged

Offline Braverman

  • Member
  • *
  • Posts: 40
Re: Corrupted "Now Playing Theme" UPDATED
« Reply #22 on: October 13, 2021, 01:04:38 PM »
Quote from: Bilgus on October 13, 2021, 12:00:41 PM
I'll make you a build this evening with that patch I posted, we and I would rather get this fixed than the workaround being going back 2 versions

If you wish ... This feels odd, as I can't see that this affects anyone but me.

BUT I do appreciate it, as I like to see what I did wrong in changing that.
You did see that I can not get into the player with the latest DEV build that the installer shows - it might just be a quirk with the e280.
« Last Edit: October 13, 2021, 01:07:37 PM by Braverman »
Logged

Offline Bilgus

  • Developer
  • Member
  • *
  • Posts: 876
Re: Corrupted "Now Playing Theme" UPDATED
« Reply #23 on: October 13, 2021, 03:57:51 PM »
TO be clear this is for the e200V2 I assume thats your player if not don't install it.
https://www.mediafire.com/file/gclbyiopdta5q6d/Sansae200V2_FRISKYSTHEMEFIX_rockbox-full.zip/file
to do the install you will hook to USB rename your current .rockbox folder to .rockbox_old (important in case we need to recover)
now simply unzip the .rockbox folder from th zip file to the ROOT of the device
SAFELY EJECT then restart

I copied the fixed theme into the install already

You say you had to go into the OF to use USB with the latest DEV build?
If after restarting on this latest one (with a clean install) you still cannot use USB let me know
We just fixed some issues for usb in the e200 V1 bootloader and while I doubt they are related I'd
like to get to the bottom of it
Clearly we've had a lot of changes since last release and would like to get
as many bugs as possible worked out before the next one

As long as someone is using the software on their device we (the DEVs) don't mind fixing it it'll likely benefit other users too
Logged

Offline Bilgus

  • Developer
  • Member
  • *
  • Posts: 876
Re: Corrupted "Now Playing Theme" UPDATED
« Reply #24 on: October 13, 2021, 04:12:57 PM »
@Frankenpod I played around with the theme engine last night I was able to make it
do what you suggested but if I do that I will need to make another tag like ?%Lx(ID, FALLBACK)
(BTW I have no idea what I need to do to make a new tag either or the fallout)

Idk if its worth the added complexity and code given that we have a viable workaround
albeit a bit verbose it doesn't really make the theme take more ram once parsed
and it is backwards compatible
Logged

Offline Braverman

  • Member
  • *
  • Posts: 40
Re: Corrupted "Now Playing Theme" UPDATED
« Reply #25 on: October 13, 2021, 06:03:13 PM »
Quote from: Bilgus on October 13, 2021, 03:57:51 PM
************ snip *******************

You say you had to go into the OF to use USB with the latest DEV build?
If after restarting on this latest one (with a clean install) you still cannot use USB let me know
We just fixed some issues for usb in the e200 V1 bootloader and while I doubt they are related I'd
like to get to the bottom of it
Clearly we've had a lot of changes since last release and would like to get
as many bugs as possible worked out before the next one

I'm trying but I can not get into the unit via USB. The original problem IS fixed, but this is - obviously - more inportant.

THANK YOU for taking the trouble.

Lemme know what I can do to help fix this.

Quote from: Bilgus on October 13, 2021, 03:57:51 PM
As long as someone is using the software on their device we (the DEVs) don't mind fixing it it'll likely benefit other users too
I appreciate that - I hope others do as well.

OH BTW, with this can I copy over the config.cfg from a 3.14 unit that has all my settings in it - obviously?
« Last Edit: October 13, 2021, 06:05:35 PM by Braverman »
Logged

Offline Bilgus

  • Developer
  • Member
  • *
  • Posts: 876
Re: Corrupted "Now Playing Theme" UPDATED
« Reply #26 on: October 13, 2021, 07:09:00 PM »
@Braverman in regards to the config file.. best answer .. maybe
some settings cause problems --btw if it does act up if you could send me that cfg file
Ive been waiting to see a failing one

For the USB I'm not sure where to begin
you said the USB didn't work in 3.15 either?
First I'll try getting someone with an e200V2 to try a dev version
I'm not sure if there are hardware differences or its more general
if its a hardware issue if you wouldn't mind coming to
IRC I or someone else might be able to spin up some builds
for you to test as we try to narrow down the issue

you might also try another USB port on your pc sometimes device IDs change and cause issues


Logged

Offline Bilgus

  • Developer
  • Member
  • *
  • Posts: 876
Re: Corrupted "Now Playing Theme" UPDATED
« Reply #27 on: October 13, 2021, 09:07:32 PM »
Ill post a few builds for you to try starting from just after 3.15 till present
-- EDIT ALL OF THOSE ARE BROKEN SORRY -

If you would try each till it fails to work..
« Last Edit: October 14, 2021, 09:27:21 AM by Bilgus »
Logged

Offline Braverman

  • Member
  • *
  • Posts: 40
Re: Corrupted "Now Playing Theme" UPDATED
« Reply #28 on: October 14, 2021, 09:17:32 AM »
Quote from: Bilgus on October 13, 2021, 09:07:32 PM
Ill post a few builds for you to try starting from just after 3.15 till present
e280USB_01_278a76b_rockbox-full.zip/file
This allows USB, Theme does NOT work and when at the main menu the top banner is missing, and the backup config.cfg file from my working 3.14 seems to work.
Quote from: Bilgus on October 13, 2021, 09:07:32 PM
/e280USB_02_7c87467b_rockbox-full.zip/
This allows USB, Theme does NOT work and when at the main menu the top banner is missing, and the backup config.cfg file from my working 3.14 seems to work.
Quote from: Bilgus on October 13, 2021, 09:07:32 PM
e280USB_03_018372b_rockbox-full.zip/file
Quote
Allows USB, Theme works (I forgot to set it in the previous 2), the top banner was there it just wasn't what I expected as I hadn't set Friskys2 to be my skin, haven't copied over the config file.
Quote from: Bilgus on October 13, 2021, 09:07:32 PM
e280USB_04_f3f9d1fb_rockbox-full.zip/file
All is well. Copied over the skin and that works well, so does the 3.14 config file.
Quote from: Bilgus on October 13, 2021, 09:07:32 PM
e280USB_05_cb92280e_rockbox-full.zip/file
e280USB_06_99f333c_rockbox.zip/file
e280USB_07_b662ff9_rockbox.zip/file
USB fails, no fonts etc.

Quote from: Bilgus on October 13, 2021, 09:07:32 PM
If you would try each till it fails to work..
I kinda have to post each or I'll just get way too confused.
I can meet yo on IRC after I do these (one thing at a time) - unless I misunderstood the timing. Just give me the server / group. Got a good program for it? I do NOT like Hexchat, or things have changed too much since I prowled around years ago.
Whatever I did, I can not get to these 2 anymore:

e280USB_05_cb92280e_rockbox-full.zip/file
e280USB_06_99f333c_rockbox.zip/file
« Last Edit: October 14, 2021, 02:49:30 PM by Braverman »
Logged

Offline Bilgus

  • Developer
  • Member
  • *
  • Posts: 876
Re: Corrupted "Now Playing Theme" UPDATED
« Reply #29 on: October 14, 2021, 09:36:57 AM »
@Braverman, Apparently this is a know problem we have a patch in the works with potential to fix it
i'll build that for you if you'd like to test

we have a webclient through kiwi IRC up on the page https://www.rockbox.org/irc/
Logged

  • Print
Pages: 1 [2] 3
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Corrupted "Now Playing Theme" UPDATED
 

  • SMF 2.0.19 | SMF © 2021, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.025 seconds with 16 queries.