Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Thank You for your continued support and contributions!

+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  RockBox album art support
« previous next »
  • Print
Pages: [1] 2

Author Topic: RockBox album art support  (Read 1182 times)

Offline awesomunia

  • Member
  • *
  • Posts: 14
RockBox album art support
« on: February 23, 2021, 11:13:26 PM »
The current RockBox does not seem to allow uppercase cases with extensions.
e.g. cover.BMP
Furthermore, since the supported extensions are only jpg and bmp, please support png as well.
Some Japanese mp3 stores have png format album art, so there should be demand.
The cover art I have set is
cover.PNG.
I would like to support png and upper cases such as PNG.
Is there a problem that the png format cannot be supported?
Logged

Offline saratoga

  • Developer
  • Member
  • *
  • Posts: 9136
Re: RockBox album art support
« Reply #1 on: February 24, 2021, 08:34:58 AM »
PNG is hard to support since it needs a lot of memory and CPU to decode.

I'm surprised about capitalization. If that is true that should be very simple to correct.
Logged

Offline awesomunia

  • Member
  • *
  • Posts: 14
Re: RockBox album art support
« Reply #2 on: February 24, 2021, 10:58:46 AM »
From the forums, I found that the image viewer supports png.
Doesn't it support artwork png even if it is a user option?

Only the PNG format of music art purchased from the store needs to support uppercase letters.
I don't know if this is in demand for bmp and jpg.
However, if you edit the tag of the purchased music data directly, the error will be displayed only locally in the purchase history of the store.
I think it's appropriate to let RockBox handle it.
Logged

Offline johnb

  • Member
  • *
  • Posts: 215
Re: RockBox album art support
« Reply #3 on: February 24, 2021, 01:09:51 PM »
saratoga, the Linux targets are case sensitive, e.g. Folder.jpg doesn't work, folder.jpg does.
Logged

Offline saratoga

  • Developer
  • Member
  • *
  • Posts: 9136
Re: RockBox album art support
« Reply #4 on: February 24, 2021, 10:44:20 PM »
If its specific to those devices I don't have any way to test, but I think you could edit try_exts() to check the uppercase versions of the file extensions too:

https://git.rockbox.org/cgit/rockbox.git/tree/apps/recorder/albumart.c

Logged

Offline awesomunia

  • Member
  • *
  • Posts: 14
Re: RockBox album art support
« Reply #5 on: February 24, 2021, 11:50:52 PM »
Does this question reach the evaluation of task validity directly between developers in the discussions in this forum?  Or should I register with tracker?
Logged

Offline bluebrother

  • Developer
  • Member
  • *
  • Posts: 3487
  • creature
Re: RockBox album art support
« Reply #6 on: February 25, 2021, 07:09:52 AM »
Quote from: awesomunia on February 24, 2021, 10:58:46 AM
From the forums, I found that the image viewer supports png.
Doesn't it support artwork png even if it is a user option?

The image viewer is a plugin, which has more resources available (since plugins don't necessarily support playback at the same time.) So what saratoga said still stands.

Quote
Only the PNG format of music art purchased from the store needs to support uppercase letters.

How is Rockbox supposed to know if music art was purchased from some store?

Quote from: saratoga on February 24, 2021, 10:44:20 PM
If its specific to those devices I don't have any way to test, but I think you could edit try_exts() to check the uppercase versions of the file extensions too:

Maybe it would be better to make Rockbox treat the filesystem as case insensitive? (No idea how much that depends on the underlying Linux system) I wouldn't be surprised if that could cause issues with playlists too, since not all OSes consider filesystems to be case sensitive.
Logged

Offline awesomunia

  • Member
  • *
  • Posts: 14
Re: RockBox album art support
« Reply #7 on: February 25, 2021, 12:13:42 PM »
Why does RockBox only support jpg, jpeg and bmp formats?
In particular, jpeg and jpg have the same format, but I would like to know the reason why they support writing conventions but do not support other formats at all.
Logged

Offline saratoga

  • Developer
  • Member
  • *
  • Posts: 9136
Re: RockBox album art support
« Reply #8 on: February 25, 2021, 12:36:23 PM »
PNG is impractical.  What other formats are you looking for?
Logged

Offline bluebrother

  • Developer
  • Member
  • *
  • Posts: 3487
  • creature
Re: RockBox album art support
« Reply #9 on: February 25, 2021, 04:47:47 PM »
Quote from: awesomunia on February 25, 2021, 12:13:42 PM
Why does RockBox only support jpg, jpeg and bmp formats?

Rockbox is running on systems with very limited resources. Some things are simply not feasible. Just to put things into perspective, the Ipods (before the 6G) run at 80MHz. Compare that to your multi-GHz desktop PC.

And last, someone has to do the work. Aside from technical details nobody did it so far. Feel free to step up ...
Logged

Offline Frankenpod

  • Member
  • *
  • Posts: 571
Re: RockBox album art support
« Reply #10 on: February 25, 2021, 05:11:05 PM »
Quote from: awesomunia on February 25, 2021, 12:13:42 PM
Why does RockBox only support jpg, jpeg and bmp formats?
In particular, jpeg and jpg have the same format, but I would like to know the reason why they support writing conventions but do not support other formats at all.

I used some utility to bulk-extract all the embedded art from my music collection, then another utility to mass convert any pngs to jpg, and then the first to re-embed the jpgs.  Fixed the problem once-and-for-all for me.  I think for me it was only iTunes that put .pngs in things, and I no longer use iTunes.

Changing case of extensions could probably be done en-mass with a script as well.
« Last Edit: February 25, 2021, 05:12:44 PM by Frankenpod »
Logged

Offline awesomunia

  • Member
  • *
  • Posts: 14
Re: RockBox album art support
« Reply #11 on: February 25, 2021, 06:39:42 PM »
iPod supports cover art in png format from photo.
RockBox is a great project to extend past players, but it has the negative effect of degenerating relatively new generations of devices in return for supporting all generations.
Will RockBox continue to not support png?
Logged

Offline awesomunia

  • Member
  • *
  • Posts: 14
Re: RockBox album art support
« Reply #12 on: February 25, 2021, 06:40:35 PM »
Also, jpg is a lightweight format, but why does it support bmp?
Logged

Offline saratoga

  • Developer
  • Member
  • *
  • Posts: 9136
Re: RockBox album art support
« Reply #13 on: February 25, 2021, 08:26:58 PM »
Quote from: awesomunia on February 25, 2021, 06:39:42 PM
RockBox is a great project to extend past players, but it has the negative effect of degenerating relatively new generations of devices in return for supporting all generations.
Will RockBox continue to not support png?

It is not about the supporting old hardware, but rather that your hardware is too old to practically support complex formats like PNG for album art.  Buy an iPhone if you want that, they have GBs of memory for that reason.

Quote from: awesomunia on February 25, 2021, 06:39:42 PM
Also, jpg is a lightweight format, but why does it support bmp?

BMP is even more simple than JPG. 
Logged

Offline bluebrother

  • Developer
  • Member
  • *
  • Posts: 3487
  • creature
Re: RockBox album art support
« Reply #14 on: February 26, 2021, 01:44:36 AM »
Quote from: awesomunia on February 25, 2021, 06:39:42 PM
iPod supports cover art in png format from photo.

How do you back this claim? Apple requires you to use Itunes to sync music to your player, and Itunes is known to do things like creating a database file with all tags which is then used by the Ipod to read the tags instead of getting them from the files. Haven't checked this but I'm pretty confident it puts cover files there as well. And since it does some preprocessing anyway, it can also convert the cover files to a different format without you even noticing. It can even go as far as rescaling them to the size the Ipod can display best, offloading all this to the PC. Rockbox does that all on the player and doesn't require you to use some special software to put files on the player.

Again, just compare the processing power of the Ipod with your multi-GHz PC.
Logged

  • Print
Pages: [1] 2
« previous next »
+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  RockBox album art support
 

  • SMF 2.0.18 | SMF © 2021, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.028 seconds with 15 queries.