AIGO EROS Q / AIGO EROS K / IRULU Surfans F20 / AGPTek H3 / HIFI WALKER H2

[mariocco]

Thank you! It works!
Really a great work.
Since you were able to extract it, could you also post the original 1.3 firmware for backup/restore purpose?
Thanks!
Mario

[dconrad]

Just got my player in the mail and got a daily build installed, I'm enjoying trying out all the cool themes!

I think I've found a few issues specific to this port (as far as I can tell), should I post them here or in the bug tracker? They're mostly button behavior related, but one is an issue with audio during playback, so I feel like it's a fairly important one.

I'm trying to get my head around the codebase to see if I can fix one or two myself, but I'm not sure if I'll get anywhere 

Edit: or is this still too new to care about bugs/issues?

[speachy]

I think I've found a few issues specific to this port (as far as I can tell), should I post them here or in the bug tracker? They're mostly button behavior related, but one is an issue with audio during playback, so I feel like it's a fairly important one.

I didn't put a lot of thought into the button maps, so specific suggestions to improve them are welcome.  Non-trivial bugs are best put directly into the tracker, but there's no harm in mentioning things here.

You will need to explain what you mean by "an issue with audio during playback"  The only issue I'm personally aware of is a crackle/dropout during high system load (made much worse by high-bitrate audio files); This same issue affects many (most?) of the "hosted" players, and fixing it requires a non-trivial rewrite of the audio driver.

[fossphile]

speachy, what about the problem, i previously mentioned?:

Sounds like the audio hardware powering off and back on. These amp boards im using need a source connected all the time. Else there is hiss like u get from cable being not being plugged into source device or a bit like the pop sound from jack plug being pushed into device while amp switched on. Quite annoying and not good enough to use as a audio player for events .

I guess its a bug during audio file format change? flac to ogg for example

Perhaps also add setting to keep audio hardware on all the time? so for events, even when not playing music, no audio hardware turn on/off output connect pop.

[speachy]

Unfortunately the audio codec powering off / on is a quirk shared by all of the hibyos-based players.

But if this is happening between track changes (presumably due to changing sample rates) it's nothing we have any control over -- our only recourse is to completly mute the audio output, but that takes ~1-2s to switch, meaning you'll lose gapless playback, have voice prompts cut off, and so forth.

(One thing you could try is fixing the output sample rate; Settings/Playback/Frequency -- it defaults to automatic)

[dconrad]

I think I've found a few issues specific to this port (as far as I can tell), should I post them here or in the bug tracker? They're mostly button behavior related, but one is an issue with audio during playback, so I feel like it's a fairly important one.

I didn't put a lot of thought into the button maps, so specific suggestions to improve them are welcome.  Non-trivial bugs are best put directly into the tracker, but there's no harm in mentioning things here.

You will need to explain what you mean by "an issue with audio during playback"  The only issue I'm personally aware of is a crackle/dropout during high system load (made much worse by high-bitrate audio files); This same issue affects many (most?) of the "hosted" players, and fixing it requires a non-trivial rewrite of the audio driver.

Ok, here goes:

I think I found two different audio bugs - the first one is the one fossphile had mentioned, where there's a click/pop when playing/pausing and switching between tracks. I need to be in a quiet room, but I can definitely hear it with just regular headphones. It does sound like the amp is turning on and off or something, like it's jumping to some DC bias from zero.

It sounds like you already know abut the other one - a crackling during quiet parts of a song or when the volume is extremely low, like one step above off. I thought it was the same thing as the popping between songs to be honest, like the amp is turning on/off really quickly in extremely quiet parts of the song, but that might just be when I notice it. I'll make some different bitrate files to see if it correlates like you say. It's probably the same issue you're already aware of.

It seems to crackle/pop consistently the same every time for the same audio track, at the same volume level. If the volume changes, the pattern changes. I'll try to get an example file.

(One thing you could try is fixing the output sample rate; Settings/Playback/Frequency -- it defaults to automatic)

Setting the frequency to any value doesn't seem to have any effect on the popping or the crackling 

The button stuff is much more trivial:

In the Settings menu and the Context menu, the back button exits to the Main Menu or the While Playing Screen, respectively, instead of going one level up. It works correctly when exiting from a selection dialogue, like if I'm in Crossfeed (Select Off/Simple/Custom), hit back and it goes back to the Crossfeed menu, but if I hit back again, it goes all the way to the main menu instead of Sound Settings.

I can't lock the buttons while anywhere except the while playing screen, I'm not sure if this is intended or a bug. For instance, on the main menu I would think I could hit the power button to lock all buttons just like in the wps, but nothing happens.

If the screen is off and buttons are unlocked, hitting the power button wakes the screen and also locks the buttons. I would kind of expect it to only wake the screen, like when the power button is pushed and the screen is off, check the lock state and only go to unlocked or something.

This one might just be inherently not how Rockbox works, but I would kind of expect the power button to immediately sleep the screen like the original firmware. Not sure if that would be complicated to implement or not.

For that matter, I think I would expect the other buttons to not wake the screen, but volume up/down to work when locked without turning the screen on. I figured out how to get the behavior like I would expect eventually, but it took a lot of digging in the settings and trying to figure out what different settings did. Does Rockbox have kind of a "default setup" for each device type? Maybe those settings could be set up that way by default to mimic something like the original firmware's behavior.

Oof! Sorry for the long post!

EDIT: Completely forgot to note build number - 2743bde09b-210312

[fossphile]

thanks for the replys,speachy & dconrad.
Long posts are good .

trying the fixxed sample rate 44.1khz. hmm does not seam to be poping between track changes.... been so long i forget what files i tested with... try switching between flac, opus, mp3. ill see...

[dconrad]

It seems to crackle/pop consistently the same every time for the same audio track, at the same volume level. If the volume changes, the pattern changes. I'll try to get an example file.

Ok, try this file at -73dB with your most sensitive headphones: https://dconrad.neocities.org/assorted_files/BeginningClip_Glad%20Rags%20-%20Wonder%20Under%20-%2003%20The%20World%20is%20Waiting.flac

I think it demonstrates both popping and crackling (or are they the same thing? I'm not sure!)

[saratoga]

The port uses software volume control (I guess they didn't include an analog gain), so at -73dB you have very little dynamic range left and should expect noise.

[dconrad]

The port uses software volume control (I guess they didn't include an analog gain), so at -73dB you have very little dynamic range left and should expect noise.

That would certainly explain what I'm hearing. So the hardware is running full blast and Rockbox is reducing the volume of the data that it's sending to it?

[dconrad]

In the Settings menu and the Context menu, the back button exits to the Main Menu or the While Playing Screen, respectively, instead of going one level up. It works correctly when exiting from a selection dialogue, like if I'm in Crossfeed (Select Off/Simple/Custom), hit back and it goes back to the Crossfeed menu, but if I hit back again, it goes all the way to the main menu instead of Sound Settings.

I managed to get the Back button to actually go back a level in the Settings menu, but no dice yet in the playlist submenu of the WPS Context menu.

In apps/keymaps/keymap-erosq.c:

Require Back button be held in the mainmenu context, and just-to-be-sure, do ACTION_STD_CANCEL on Back button release in the standard context.

Code: [Select]

/*
 * The format of the list is as follows
 * { Action Code,   Button code,    Prereq button code }
 * if there's no need to check the previous button's value, use BUTTON_NONE
 * Insert LAST_ITEM_IN_LIST at the end of each mapping
 */
static const struct button_mapping button_context_standard[]  = {
    { ACTION_STD_PREV,       BUTTON_SCROLL_BACK,              BUTTON_NONE },
    { ACTION_STD_PREV,       BUTTON_PREV,                   BUTTON_NONE },
    { ACTION_STD_PREVREPEAT, BUTTON_PREV|BUTTON_REPEAT,     BUTTON_NONE },
    { ACTION_STD_NEXT,       BUTTON_SCROLL_FWD,             BUTTON_NONE },
    { ACTION_STD_NEXT,       BUTTON_NEXT,                   BUTTON_NONE },
    { ACTION_STD_NEXTREPEAT, BUTTON_NEXT|BUTTON_REPEAT,     BUTTON_NONE },
    { ACTION_STD_OK,         BUTTON_PLAY|BUTTON_REL,        BUTTON_PLAY },
    { ACTION_STD_CANCEL,     BUTTON_BACK|BUTTON_REL,        BUTTON_BACK },
    { ACTION_STD_CONTEXT,    BUTTON_MENU|BUTTON_REPEAT,     BUTTON_MENU },
    { ACTION_STD_MENU,       BUTTON_MENU|BUTTON_REL,        BUTTON_MENU },

/*    ACTION_STD_QUICKSCREEN,
 *    ACTION_STD_KEYLOCK
 *    ACTION_STD_REC
 *    ACTION_STD_HOTKEY
 */

    LAST_ITEM_IN_LIST
}; /* button_context_standard */

static const struct button_mapping button_context_mainmenu[]  = {
    { ACTION_TREE_WPS,       BUTTON_BACK|BUTTON_REPEAT,     BUTTON_BACK }, // need to hold, otherwise causes
       // back to always go to main menu root

    LAST_ITEM_IN_LIST__NEXTLIST(CONTEXT_TREE),
}; /* button_context_mainmenu as with sansa clip mapping - "back" button returns you to WPS */

I kind of expected the button context in the Settings to be, well, settings, rather than mainmenu. Is that intentional? I had a lot of trouble figuring out what context applied where. Is there an easy way to find that information?

I would put this up on gerrit, but I can't get it to accept my ssh key for some reason.

EDIT: okay, one more thing: The playlist menu appears to also be mainmenu context, however ACTION_STD_CANCEL behaves differently there. I'm not sure why.

[speachy]

In the Settings menu and the Context menu, the back button exits to the Main Menu or the While Playing Screen, respectively, instead of going one level up. It works correctly when exiting from a selection dialogue, like if I'm in Crossfeed (Select Off/Simple/Custom), hit back and it goes back to the Crossfeed menu, but if I hit back again, it goes all the way to the main menu instead of Sound Settings.

This should now be fixed.

I can't lock the buttons while anywhere except the while playing screen, I'm not sure if this is intended or a bug. For instance, on the main menu I would think I could hit the power button to lock all buttons just like in the wps, but nothing happens.

This too (in general)

[saratoga]

The port uses software volume control (I guess they didn't include an analog gain), so at -73dB you have very little dynamic range left and should expect noise.

That would certainly explain what I'm hearing. So the hardware is running full blast and Rockbox is reducing the volume of the data that it's sending to it?

Yeah. I don't know why, but a lot of these hifi players seem to pick fancy DACs but forget that people might want a way to change the volume.

[dconrad]

In the Settings menu and the Context menu, the back button exits to the Main Menu or the While Playing Screen, respectively, instead of going one level up. It works correctly when exiting from a selection dialogue, like if I'm in Crossfeed (Select Off/Simple/Custom), hit back and it goes back to the Crossfeed menu, but if I hit back again, it goes all the way to the main menu instead of Sound Settings.

This should now be fixed.

I can't lock the buttons while anywhere except the while playing screen, I'm not sure if this is intended or a bug. For instance, on the main menu I would think I could hit the power button to lock all buttons just like in the wps, but nothing happens.

This too (in general)

I'm not seeing either of these fix the issues here unfortunately.

Unless I'm not understanding correctly (very real possibility hah), the context in the settings and context menu is mainmenu, and the flow goes mainmenu -> (tree, if enabled) -> list -> standard. I found that the issue was the ACTION_TREE_WPS action in the mainmenu context, if I moved that to a held button then it started working.

EDIT: I added a change in gerrit to fix the above.

I tested out the power button yesterday when I was messing with it and any other action in that context can be assigned to the power button, but ACTION_STD_KEYLOCK doesn't work for some reason.

[dconrad]

Yeah. I don't know why, but a lot of these hifi players seem to pick fancy DACs but forget that people might want a way to change the volume.

Is it that it's just not available in the OS, or that it's not physically hooked up? I hope it's the former!