AIGO EROS Q / AIGO EROS K / IRULU Surfans F20 / AGPTek H3 / HIFI WALKER H2

[dconrad]

After reviewing the code, yes Rolo not working correctly with root redirect appears to be a known issue.

One further question: On the v3 device, if you upload a new build while rockbox is running and it asks you "new firmware found, do you want to reload?" (or something to that effect), does that work correctly, or does the display screw up?

[ZappBranigan2972]

a. Were you reloading from the same location or from a different location?

b. One further question: On the v3 device, if you upload a new build while rockbox is running and it asks you "new firmware found, do you want to reload?" (or something to that effect), does that work correctly, or does the display screw up?

a. Same location as in the Redirect File, also Files->_erosqn_v3/.rockbox/rockbox.erosq, but it was only for the Test, practially seldom used.
The Patch has noting with the 'Rolo-Problem' to do, as an Rolo Test of an 'ancient' archived Rockbox Version: e122243bb0M-240219 (Binary: rockbox.erosq) shows the idcentical Rolo Behavior with redirects. 

b. The V3 Device does a Restart with the Picture inverted (V1/V2 Style)  but the Redirect was followed, see Pic

[dconrad]

Edit: Wait, no - this won't quite work, but maybe something similar. It looks like it will be a little more invasive than that, we might have to add that capability all the way to the write_bootdata() functions... I'll look at it this weekend.

I see - I can make this change when I get home from work, but if you want to try one thing for me which at first glance seems like it may fix the reloading issue, could you try this:

In firmware/rolo.c, rolo_load():

Code: [Select]

#if defined(HAVE_BOOTDATA) && !defined(SIMULATOR)
    /* write the bootdata as if rolo were the bootloader
     * FIXME: this won't work for root redirect... */
    if (!strcmp(filename, BOOTDIR "/" BOOTFILE) && boot_data_valid)
    {
        int volume = 0;

        if (boot_data.version == 0)
            volume = boot_data._boot_volume;
        else if (boot_data.version == 1)
        {
            for (int i = 0; i < NUM_VOLUMES; ++i)
            {
                if (volume_drive(i) == boot_data.boot_drive &&
                    volume_partition(i) == boot_data.boot_partition)
                {
                    volume = i;
                    break;
                }
            }
        }

        write_bootdata(filebuf, filebuf_size, volume);
    }
#endif

Move the write_bootdata() call at the bottom outside of the {} so that it is unconditionally called, like so:

Code: [Select]

#if defined(HAVE_BOOTDATA) && !defined(SIMULATOR)
    /* write the bootdata as if rolo were the bootloader
     * FIXME: this won't work for root redirect... */
    if (!strcmp(filename, BOOTDIR "/" BOOTFILE) && boot_data_valid)
    {
        int volume = 0;

        if (boot_data.version == 0)
            volume = boot_data._boot_volume;
        else if (boot_data.version == 1)
        {
            for (int i = 0; i < NUM_VOLUMES; ++i)
            {
                if (volume_drive(i) == boot_data.boot_drive &&
                    volume_partition(i) == boot_data.boot_partition)
                {
                    volume = i;
                    break;
                }
            }
        }

    }
    write_bootdata(filebuf, filebuf_size, volume);
#endif

I'm not sure if it will work and if it does, what side effects it will have, but... it seems like it might fix the issue?

[dconrad]

a. Were you reloading from the same location or from a different location?

b. One further question: On the v3 device, if you upload a new build while rockbox is running and it asks you "new firmware found, do you want to reload?" (or something to that effect), does that work correctly, or does the display screw up?

a. Same location as in the Redirect File, also Files->_erosqn_v3/.rockbox/rockbox.erosq, but it was only for the Test, practially seldom used.
The Patch has noting with the 'Rolo-Problem' to do, as an Rolo Test of an 'ancient' archived Rockbox Version: e122243bb0M-240219 (Binary: rockbox.erosq) shows the idcentical Rolo Behavior with redirects. 

b. The V3 Device does a Restart with the Picture inverted (V1/V2 Style)  but the Redirect was followed, see Pic

EDIT: Wait, no I think this still won't quite work... I think the version number will reset to the hardcoded version upon using rolo... You could still try it if you want though and confirm my suspicions though.
Edit 2: Ok, now go ahead and try the following. I think it should work now with a v1 build of rockbox on a v3 player with a v3 bootloader.

Ok, if you could try one new build with all the following patches on your v3 player -

With patchsets:

• 5877
• 5892
• 5893

In my testing, this allows bootdata (and, thus our player version) to be passed through rolo.

[ZappBranigan2972]

Ok, if you could try one new build with all the following patches on your v3 player -
With patchsets:

• 5877
• 5892
• 5893

In my testing, this allows bootdata (and, thus our player version) to be passed through rolo.

RB ErosQ V3 g5877 g5892 g5893 Test:

With Redirect File to /_erosqn_v3

1. Build new Bootloader (Target 248) with jztools in Ram -> menu Rockbox Start
     Boot Ok, Bootdata valid 00: 03 01 00 00
2. Install new Bootloader -> Restart
     Boot Ok, Bootdata valid 00: 03 01 00 00

3. Build a new RB (Target 247) installed it -> Reboot
     Boot Ok, Bootdata valid 00: 03 01 00 00
     Boot Path /<microSD0>/_erosqn_v3/.rockbox/rockbox.erosq
4. Build and install a slightly diffent RB install (Target 247),
   copy it,  new firmware found, do you want to reload? YES
     Display reversed/mirrored, Bootdata valid 00: 01 01 00 00 (V1/2 style)
     Boot Path /<microSD0>/_erosqn_v3/.rockbox/rockbox.erosq
     (per Files-><microsd0>/_erosqn_v3/.rockbox/rockbox.erosq self-roloing does the same)

With no Redirect (/.rockbox Standard)                              

5. Boot OK, Bootdata valid  00: 03 01 00 00,
   Boot Path /<microSD0>//.rockbox/rockbox.erosq  (two slashes? But Harmless)
6. Install a slightly diffent RB install (Target 247)
   copy it,  new firmware found, do you want to reload? YES
     Display reversed/mirrored, Bootdata valid 00: 01 01 00 00,
     Boot Path /<microSD0>//.rockbox/rockbox.erosq
     (per Files-><microsd0>/.rockbox/rockbox.erosq self-roloing does the same)

Rolo don't pass the 03 to the Firmware reboot. but without Rolo usage all is OK
-----
p.s.
  x1000 Fixes 454-471, uncluttered / actualized and with comment at begiining of the diffs

[dconrad]

That's frustrating, it definitely worked on my player. 

I'll have to think about it for a minute.

[dconrad]

Their web site is www.eroshifi.com.  Ideally you can get them to supply the original v1.9 firmware as an update file.  We don't know what hardware generation the v1.9 and v2.0 firmwares correspond with.

thanks, i tried emailing them but apparently the email doesnt exist.. think im out of luck here. thanks for the help anyway

From http://www.eroshifi.com/download/firmware/122.html, it kind of sounds like you might be safe to upgrade to the erosQ firmware 2.0, but I'm trying to think of a way to confirm that without the ability to go back to 1.9 if it turns out not. The way they describe it there, it seems like 2.0 is the "old LCD" (what we're calling v2), and 2.1 is the "new LCD" (what we're calling v3). It seems like they have v1.8 and v2.0 available on their support page, but no 1.9 - which is probably why we don't have it either.

[hannahmuffins]

Their web site is www.eroshifi.com.  Ideally you can get them to supply the original v1.9 firmware as an update file.  We don't know what hardware generation the v1.9 and v2.0 firmwares correspond with.

thanks, i tried emailing them but apparently the email doesnt exist.. think im out of luck here. thanks for the help anyway

From http://www.eroshifi.com/download/firmware/122.html, it kind of sounds like you might be safe to upgrade to the erosQ firmware 2.0, but I'm trying to think of a way to confirm that without the ability to go back to 1.9 if it turns out not. The way they describe it there, it seems like 2.0 is the "old LCD" (what we're calling v2), and 2.1 is the "new LCD" (what we're calling v3). It seems like they have v1.8 and v2.0 available on their support page, but no 1.9 - which is probably why we don't have it either.

oh hey i came to the same conclusion from the website and decided to just try it, and its been working fine! just came here to make a post about it too since i thought it'd be useful for others to know. i got the rockbox hosted port running on it now using the patched 2.0 firmware from the wiki after i updated with the 2.0 update from eroshifi

[dconrad]

Good to hear!

[ZappBranigan2972]

@dconrad

Update Roloing Test with 14a8f9a863 + g5877 (Patchlevel 10) It works !!
(Build for Target 247)

ErosQ V3:
Build a new RB Version / install it. / normal Restart
build a slighty different RB Version / install rockbox.erosq
new firmware found, do you want to reload? YES
 Display OK, Bootdata valid 00: 03 01 00 00,  Success for V3 !!!
     Boot Path /<microSD0>/_erosqn_v3/.rockbox/rockbox.erosq
    (per Files-><microsd0>/_erosqn_v3/.rockbox/rockbox.erosq self-roloing does the same right thing)

ErosQ V2:
new RB Version / install it.  / normal Restart
Install a slighty different RB Version / install rockbox.erosq
new firmware found, do you want to reload? YES
 Display OK, Bootdata valid 00: 01 01 00 00,
     Boot Path /<microSD0>/_erosqn/.rockbox/rockbox.erosq
     (per Files-><microsd0>/_erosqn/.rockbox/rockbox.erosq self-roloing does the same  right thing)

The Rockbox Version from where to use Rolo must be equipped with g5877 patch set 10
(The difference from g5877 patch set 8 to 10 makes it work!)

(Is the Devicedata patch now really needed ?)

[dconrad]

@dconrad

Update Roloing Test with 14a8f9a863 + g5877 (Patchlevel 10) It works !!
(Build for Target 247)

ErosQ V3:
Build a new RB Version / install it. / normal Restart
build a slighty different RB Version / install rockbox.erosq
new firmware found, do you want to reload? YES
 Display OK, Bootdata valid 00: 03 01 00 00,  Success for V3 !!!
     Boot Path /<microSD0>/_erosqn_v3/.rockbox/rockbox.erosq
    (per Files-><microsd0>/_erosqn_v3/.rockbox/rockbox.erosq self-roloing does the same right thing)

ErosQ V2:
new RB Version / install it.  / normal Restart
Install a slighty different RB Version / install rockbox.erosq
new firmware found, do you want to reload? YES
 Display OK, Bootdata valid 00: 01 01 00 00,
     Boot Path /<microSD0>/_erosqn/.rockbox/rockbox.erosq
     (per Files-><microsd0>/_erosqn/.rockbox/rockbox.erosq self-roloing does the same  right thing)

The Rockbox Version from where to use Rolo must be equipped with g5877 patch set 10
(The difference from g5877 patch set 8 to 10 makes it work!)

(Is the Devicedata patch now really needed ?)

Excellent, thank you for testing! I'm not sure what made it work this time vs last time though.

I'm going to rework g5877 somewhat to move it away from using bootdata just to make it cleaner, but I'm glad to hear that it behaves correctly this time around. g5893, in which we make rolo write bootdata as long as the existing bootdata is valid, did get merged though.

I think I'll have time to do the rework in the next couple days, so hopefully we can get this sorted out soon.

[dconrad]

Ok, if you wouldn't mind one more test, I think everything is in a good place:

Download the files from here.

There's an "A" and a "B" build which are near-identical, and a v1 and v3 bootloader. These patches use a new "devicedata" structure rather than the existing bootdata, so that we can avoid changing bootdata, and thus entering the possibility of messing with other devices (and having to test lots of bootloaders on various devices).

There is a new "Device Data" screen in the debug menu as well - the first byte should show the LCD version.

These builds should also have a rolo which passes the device data through.

[ZappBranigan2972]

Ok, if you wouldn't mind one more test, I think everything is in a good place:

ErosQ V3
1. jztool in Ram Bootloader (bootloader-erosqnative-v3-0e6481f303-240830.erosq):
  Boot OF -> OK
  Boot RB      (rockbox-erosqnative-0e6481f303-240830-A) -> LCD OK, Boot Data/Device Data makes sense
  Roloing tof  (rockbox-erosqnative-0e6481f303-240830-B) -> LCD OK              "
  Self-Roloing (rockbox-erosqnative-0e6481f303-240830-B) -> LCD OK, Boot data invalid, RB Path not found
                (Build older as 56dd7ead63 ??: rolo: Write bootdata regardless of whether running from root or redirect)
ErosQ V2
2. jztool in Ram Bootloader (bootloader-erosqnative-v1-0e6481f303-240830.erosq):
  Boot OF -> OK
  Boot RB      (rockbox-erosqnative-0e6481f303-240830-A) -> LCD OK Boot Data/Device Data makes sense
  Roloing to   (rockbox-erosqnative-0e6481f303-240830-B) -> LCD OK             "
  Self-Roloing (rockbox-erosqnative-0e6481f303-240830-B) -> LCD OK, Boot data invalid, RB Path not found
                (Build older as 56dd7ead63 ??: rolo: Write bootdata regardless of whether running from root or redirect)

Own Compile (with g5895-pl7, g5877-pl11, RB edd607c392 Yesterday 12:07)

ErosQ V3
3. jztool in Ram Bootloader (bootloader-erosqnative-v3-edd607c392-240830.erosq):
  Boot RB      (rockbox-erosqnative-edd607c392-240830-A) -> LCD OK, Boot Data/Device Data makes sense
  Roloing to   (rockbox-erosqnative-edd607c392-240830-B) -> LCD OK,            "
  Self-Roloing (rockbox-erosqnative-edd607c392-240830-B) -> LCD OK,            "
                (Build included 56dd7ead63)
  Write bootloader-erosqnative-v3-edd607c392-240830.erosq to Flash
  Boot OF, Boot RB, Self-Roloing -> All OK, Boot Data/Device Data makes sense

  Surfans F20 v3.2 Bootloader & Rockbox on newest Patchlevel 20240830...
ErosQ V2
3. jztool in Ram Bootloader (bootloader-erosqnative-v1-edd607c392-240830.erosq):
  Boot RB      (rockbox-erosqnative-edd607c392-240830-A) -> LCD OK, Boot Data/Device Data makes sense
  Roloing to   (rockbox-erosqnative-edd607c392-240830-B) -> LCD OK,            "
  Self-Roloing (rockbox-erosqnative-edd607c392-240830-B) -> LCD OK,            "
                (Build included 56dd7ead63)
  Write bootloader-erosqnative-v1-edd607c392-240830.erosq to Flash
  Boot OF, Boot RB, Self-Roloing -> All OK, Boot Data/Device Data makes sense

  Surfans F20 v2.7 Bootloader & Rockbox on newest Patchlevel 20240830...

[dconrad]

Ok, if you wouldn't mind one more test, I think everything is in a good place:

ErosQ V3
1. jztool in Ram Bootloader (bootloader-erosqnative-v3-0e6481f303-240830.erosq):
  Boot OF -> OK
  Boot RB      (rockbox-erosqnative-0e6481f303-240830-A) -> LCD OK, Boot Data/Device Data makes sense
  Roloing tof  (rockbox-erosqnative-0e6481f303-240830-B) -> LCD OK              "
  Self-Roloing (rockbox-erosqnative-0e6481f303-240830-B) -> LCD OK, Boot data invalid, RB Path not found
                (Build older as 56dd7ead63 ??: rolo: Write bootdata regardless of whether running from root or redirect)
ErosQ V2
2. jztool in Ram Bootloader (bootloader-erosqnative-v1-0e6481f303-240830.erosq):
  Boot OF -> OK
  Boot RB      (rockbox-erosqnative-0e6481f303-240830-A) -> LCD OK Boot Data/Device Data makes sense
  Roloing to   (rockbox-erosqnative-0e6481f303-240830-B) -> LCD OK             "
  Self-Roloing (rockbox-erosqnative-0e6481f303-240830-B) -> LCD OK, Boot data invalid, RB Path not found
                (Build older as 56dd7ead63 ??: rolo: Write bootdata regardless of whether running from root or redirect)

Own Compile (with g5895-pl7, g5877-pl11, RB edd607c392 Yesterday 12:07)

ErosQ V3
3. jztool in Ram Bootloader (bootloader-erosqnative-v3-edd607c392-240830.erosq):
  Boot RB      (rockbox-erosqnative-edd607c392-240830-A) -> LCD OK, Boot Data/Device Data makes sense
  Roloing to   (rockbox-erosqnative-edd607c392-240830-B) -> LCD OK,            "
  Self-Roloing (rockbox-erosqnative-edd607c392-240830-B) -> LCD OK,            "
                (Build included 56dd7ead63)
  Write bootloader-erosqnative-v3-edd607c392-240830.erosq to Flash
  Boot OF, Boot RB, Self-Roloing -> All OK, Boot Data/Device Data makes sense

  Surfans F20 v3.2 Bootloader & Rockbox on newest Patchlevel 20240830...
ErosQ V2
3. jztool in Ram Bootloader (bootloader-erosqnative-v1-edd607c392-240830.erosq):
  Boot RB      (rockbox-erosqnative-edd607c392-240830-A) -> LCD OK, Boot Data/Device Data makes sense
  Roloing to   (rockbox-erosqnative-edd607c392-240830-B) -> LCD OK,            "
  Self-Roloing (rockbox-erosqnative-edd607c392-240830-B) -> LCD OK,            "
                (Build included 56dd7ead63)
  Write bootloader-erosqnative-v1-edd607c392-240830.erosq to Flash
  Boot OF, Boot RB, Self-Roloing -> All OK, Boot Data/Device Data makes sense

  Surfans F20 v2.7 Bootloader & Rockbox on newest Patchlevel 20240830...

Excellent, thank you! I wouldn't worry about the bootdata, we are no longer relying on it.

[dion]

I bought a Surfans F20 recently and it came with firmware 3.3 which isn't listed on the chart. I contacted Surfans and they gave me the firmware file here:
https://drive.google.com/drive/folders/1kjjgM_mzN4b1LxhLORmO8yizG6O94p6E