iconset question

[RetiredTeacherGuy]

Am I correct that rockbox uses the bookmarks icon for shortcuts? Any way around this?

[Bilgus]

not sure what you are asking specifically?

shortcults allow different icons but it all depends on where you are asking about

[RetiredTeacherGuy]

I’ve been working on my own custom iconset, and it doesn’t seem that in the 32 there is a specific icon for the shortcuts menu item. Rather, it looks like the bookmarks icon is applied.

[Bilgus]

https://github.com/Rockbox/rockbox/blob/master/apps/shortcuts.c#L651

Code: [Select]

 
        [SHORTCUT_SETTING] = Icon_Menu_setting,
        [SHORTCUT_SETTING_APPLY] = Icon_Queued,
        [SHORTCUT_DEBUGITEM] = Icon_Menu_functioncall,
        [SHORTCUT_BROWSER] = Icon_Folder,
        [SHORTCUT_PLAYLISTMENU] = Icon_Playlist,
        [SHORTCUT_SEPARATOR] = Icon_NOICON,
        [SHORTCUT_SHUTDOWN] = Icon_System_menu,
        [SHORTCUT_REBOOT] = Icon_System_menu,
        [SHORTCUT_TIME] = Icon_Menu_functioncall,
        [SHORTCUT_FILE] = Icon_NOICON,
^these are the defaults for shortcut


https://github.com/Rockbox/rockbox/blob/master/apps/gui/icon.h#L31
the list of icons

Code: [Select]

    NOICON = -1,
    Icon_NOICON = NOICON, /* Dont put this in a .bmp */
    Icon_Audio,
    Icon_Folder,
    Icon_Playlist,
    Icon_Cursor,
    Icon_Wps,
    Icon_Firmware,
    Icon_Font,
    Icon_Language,
    Icon_Config,
    Icon_Plugin,
    Icon_Bookmark,
    Icon_Preset,
    Icon_Queued,
    Icon_Moving,
    Icon_Keyboard,
    Icon_Reverse_Cursor,
    Icon_Questionmark,
    Icon_Menu_setting,
    Icon_Menu_functioncall,
    Icon_Submenu,
    Icon_Submenu_Entered,
    Icon_Recording,
    Icon_Voice,
    Icon_General_settings_menu,
    Icon_System_menu,
    Icon_Playback_menu,
    Icon_Display_menu,
    Icon_Remote_Display_menu,
    Icon_Radio_screen,
    Icon_file_view_menu,
    Icon_EQ,
    Icon_Rockbox,
    Icon_Last_Themeable,


[Bilgus]

Ah I think I found where you are actually asking about
https://github.com/Rockbox/rockbox/blob/master/apps/root_menu.c#L494

Code: [Select]

MENUITEM_RETURNVALUE(shortcut_menu, ID2P(LANG_SHORTCUTS), GO_TO_SHORTCUTMENU,
                        NULL, Icon_Bookmark);

MENUITEM_RETURNVALUE(file_browser, ID2P(LANG_DIR_BROWSER), GO_TO_FILEBROWSER,
                        NULL, Icon_file_view_menu);
#ifdef HAVE_TAGCACHE
MENUITEM_RETURNVALUE(db_browser, ID2P(LANG_TAGCACHE), GO_TO_DBBROWSER,
                        NULL, Icon_Audio);
#endif
MENUITEM_RETURNVALUE(rocks_browser, ID2P(LANG_PLUGINS), GO_TO_BROWSEPLUGINS,
                        NULL, Icon_Plugin);

MENUITEM_RETURNVALUE(playlist_browser, ID2P(LANG_CATALOG), GO_TO_PLAYLIST_VIEWER,
                        NULL, Icon_Playlist);



[RetiredTeacherGuy]

Ah I think I found where you are actually asking about
https://github.com/Rockbox/rockbox/blob/master/apps/root_menu.c#L494

Code: [Select]

MENUITEM_RETURNVALUE(shortcut_menu, ID2P(LANG_SHORTCUTS), GO_TO_SHORTCUTMENU,
                        NULL, Icon_Bookmark);

MENUITEM_RETURNVALUE(file_browser, ID2P(LANG_DIR_BROWSER), GO_TO_FILEBROWSER,
                        NULL, Icon_file_view_menu);
#ifdef HAVE_TAGCACHE
MENUITEM_RETURNVALUE(db_browser, ID2P(LANG_TAGCACHE), GO_TO_DBBROWSER,
                        NULL, Icon_Audio);
#endif
MENUITEM_RETURNVALUE(rocks_browser, ID2P(LANG_PLUGINS), GO_TO_BROWSEPLUGINS,
                        NULL, Icon_Plugin);

MENUITEM_RETURNVALUE(playlist_browser, ID2P(LANG_CATALOG), GO_TO_PLAYLIST_VIEWER,
                        NULL, Icon_Playlist);



Ah, so it is intentional. Not enough distinct icon slots I guess?