Support and General Use > User Interface and Voice
Viewing entire comments tag in MP3s
Frankenpod:
The ability to see the full comment, neatly formatted, is something that the Original firmware has that Rockbox lacks - and as you say it struck me as particularly important for podcasts. But adding a function to retrieve characters 231-460, would surely not be that complicated, because one could just duplicate with slight changes the existing code that gets the first 230 characters, and give it a different identifier in the WPS engine to the existing comment field (maybe iC2 or iCb rather than iC?). Unfortunately I am not skilled enough to be able to figure out the existing code-base and fear breaking something if I try and meddle with it, so was hoping someone more confident about it might do it for me!
chris_s:
ID3V2_MAX_ITEM_SIZE is defined to be 240 if MEMORYSIZE > 2 (MB) in /lib/rbcodec/metadata/metadata.h
In theory you could simply increase that value and possibly the buffer size for "very" large memory sizes (the iPod video has 64MB, for example) and have it just work.
--- Code: ---#if MEMORYSIZE > 2
#define ID3V2_BUF_SIZE 900
#define ID3V2_MAX_ITEM_SIZE 240
#else
#define ID3V2_BUF_SIZE 300
#define ID3V2_MAX_ITEM_SIZE 90
#endif
--- End code ---
The constraint was only introduced in dedde47 and then again adjusted in 37a9a20
speachy:
It's probably safe to bump this up for targets with >8MB RAM.
Frankenpod:
If I can get my "development environment" working again (on my linux box with the dodgy hard-drive!) I will try compiling a version with that number boosted a bit (where MEMORYSIZE>8MB), and see if it works/makes a difference.
(Not all ipod videos have 64MB, the 30gb models I believe have 32MB, but it sounds as if the string length was set very conservatively to be safe for the lower-end targets?)
I notice the change chris_s found says " Limit the size of each ID3 metadata item to avoid that the metadata buffer is filled by single items"
Does that mean there's a specific, defined "metadata buffer" that would need to be increased in size?
speachy:
--- Quote from: Frankenpod on March 02, 2021, 10:18:00 PM ---(Not all ipod videos have 64MB, the 30gb models I believe have 32MB, but it sounds as if the string length was set very conservatively to be safe for the lower-end targets?)
--- End quote ---
Yep, a _lot_ of rockbox is the way it is in order to keep the memory footprint as small (and runtime as deterministic) as possible.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version