Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Thank You for your continued support and contributions!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  User Interface and Voice
| | |-+  Viewing entire comments tag in MP3s
« previous next »
  • Print
Pages: [1]

Author Topic: Viewing entire comments tag in MP3s  (Read 321 times)

Offline Desertway

  • Member
  • *
  • Posts: 3
Viewing entire comments tag in MP3s
« on: May 17, 2020, 02:28:13 PM »
I hope I'm in the right place for this question. I'm new to Rockbox and looking for a way to view the entire embedded comment field for an MP3. I have seen some themes that incorporate the tag, but it is truncated. Can it be viewed in a way other than the WPS? Thanks very much.
Logged

Offline Bilgus

  • Developer
  • Member
  • *
  • Posts: 537
Re: Viewing entire comments tag in MP3s
« Reply #1 on: May 17, 2020, 07:12:04 PM »
Rockbox internally probably truncates it due to memory constraints

you could parse it yourself in Lua check out the hex viewer example
Logged

Offline Desertway

  • Member
  • *
  • Posts: 3
Re: Viewing entire comments tag in MP3s
« Reply #2 on: May 17, 2020, 08:30:29 PM »
Thanks very much.
Logged

Offline Frankenpod

  • Member
  • *
  • Posts: 414
Re: Viewing entire comments tag in MP3s
« Reply #3 on: May 18, 2020, 04:12:18 AM »
Ideally some smart coding-capable person would be able to modify the main code so as to add an additional function to retrieve the second 230 characters of the comment (the existing function only gives you the first 230 characters).  I could then rewrite my theme below so as to report the full comment.

http://themes.rockbox.org/index.php?themeid=2529&target=ipod6g
Logged

Offline Desertway

  • Member
  • *
  • Posts: 3
Re: Viewing entire comments tag in MP3s
« Reply #4 on: May 18, 2020, 12:57:28 PM »
Quote from: Frankenpod on May 18, 2020, 04:12:18 AM
Ideally some smart coding-capable person would be able to modify the main code so as to add an additional function to retrieve the second 230 characters of the comment (the existing function only gives you the first 230 characters).  I could then rewrite my theme below so as to report the full comment.

http://themes.rockbox.org/index.php?themeid=2529&target=ipod6g

I was looking at your theme. It would be perfect as I primarily listen to podcasts, and they have a lot of notes. A change to expand those limitations in the code would be great. Do you think there is enough interest at this point?
Logged

Offline Frankenpod

  • Member
  • *
  • Posts: 414
Re: Viewing entire comments tag in MP3s
« Reply #5 on: May 19, 2020, 06:25:44 AM »
The ability to see the full comment, neatly formatted, is something that the Original firmware has that Rockbox lacks - and as you say it struck me as particularly important for podcasts. But adding a function to retrieve characters 231-460, would surely not be that complicated, because one could just duplicate with slight changes the existing code that gets the first 230 characters, and give it a different identifier in the WPS engine to the existing comment field (maybe iC2 or iCb rather than iC?).   Unfortunately I am not skilled enough to be able to figure out the existing code-base and fear breaking something if I try and meddle with it, so was hoping someone more confident about it might do it for me!
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  User Interface and Voice
| | |-+  Viewing entire comments tag in MP3s
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.12 seconds with 20 queries.