Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Rockbox Ports are now being developed for various digital audio players!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Audio Playback, Database and Playlists
| | |-+  Different playlist behavior between Rockbox v3.14 and v3.15
« previous next »
  • Print
Pages: [1]

Author Topic: Different playlist behavior between Rockbox v3.14 and v3.15  (Read 1023 times)

Offline Countryman

  • Member
  • *
  • Posts: 8
  • iPod 5G, 6G & 7G. iRiver H10 20GB & 6GB
Different playlist behavior between Rockbox v3.14 and v3.15
« on: December 03, 2019, 03:09:38 PM »
Hi everybody.

I use Rockbox more than 10 years. My players are iPod Video (5g), iPod Classic (6g), iRiver H10 20GB and iRiver H10 6GB.
My way of listening to music is mainly based on different playlists for different occasions.
As I upgraded my players to v3.15, I realized that with that version, if there is a missing file referenced in my playlist (I delete very often tracks that I don't like using the player interface, but I don't refresh so often the playlists), the players stop, and I must press "next" in order to continue the playback.
This is very annoying for me, because I have a lot of deleted tracks. I searched in the settings, hoping that this is a new setting, but I didn't found anything relevant.
As a temporary solution I "cleaned" all my playlists of missing entries with ListFix, but the problem is so annoying to me, that I downgraded to v3.14 all my players except the iPod 6g, because I couldn't find the Rockbox 6g v3.14 firmware to download.

Questions:

1. Is this a known and wanted behavior of v.3.15?
2. Is there a setting in the menu, to activate/deactivate this behavior?
3. Where can I find the 3.14 version for iPod 6g (it was "unsupported", and it is not in the main Rockbox archive)

Thank you a lot for your attention.
« Last Edit: December 03, 2019, 03:14:16 PM by Countryman »
Logged

Offline Bilgus

  • Developer
  • Member
  • *
  • Posts: 720
Re: Different playlist behavior between Rockbox v3.14 and v3.15
« Reply #1 on: December 04, 2019, 08:23:06 AM »
I can confirm the behavior you are describing but I haven't gotten to finding out why it has changed

I agree it is annoying but I assume its been changed to prevent the playlist from just churning through a
bunch of non-existent tracks, I think the better behavior would be to auto skip till the end of the playlist
has been reached
Logged

Offline Countryman

  • Member
  • *
  • Posts: 8
  • iPod 5G, 6G & 7G. iRiver H10 20GB & 6GB
Re: Different playlist behavior between Rockbox v3.14 and v3.15
« Reply #2 on: December 04, 2019, 09:32:53 AM »
If that was the intention, I agree with your suggestion. It would be much better.

P.S. Do you know where can I find the 3.14 version for iPod 6g?
Logged

Offline saratoga

  • Developer
  • Member
  • *
  • Posts: 9137
Re: Different playlist behavior between Rockbox v3.14 and v3.15
« Reply #3 on: December 04, 2019, 11:30:50 AM »
I doubt that was intended, the playlist behavior has been fixed for a long time and generally people were happy with the old way. 
Logged

Offline __builtin

  • Developer
  • Member
  • *
  • Posts: 398
  • iPod 6G, c200v1 (RIP), e200v1 (RIP)
    • FWEI.TK
Re: Different playlist behavior between Rockbox v3.14 and v3.15
« Reply #4 on: December 04, 2019, 11:40:01 AM »
3.14 was never released for ipod6g, since it was still "unstable" at release time.
Logged
No support questions by PM, please.

Offline bobba_mosfet

  • Member
  • *
  • Posts: 54
Re: Different playlist behavior between Rockbox v3.14 and v3.15
« Reply #5 on: December 04, 2019, 03:21:34 PM »
If I had to take a complete stab in the dark, maybe this commit:

Quote
commit dfff938dff089667038041fcb66262c87c3186c2
Author: Michael Sevakis <jethead71@rockbox.org>
Date:   Sun Dec 17 16:12:10 2017 -0500

    Get rid of useless playlist probing and fix up some data types.
   
    Playback checked the files' presence before attempting to buffer
    the track. Just get rid of that and save an extra open/close call.
    It will find out if the path is bad when the metadata fails.
   
    Fix some size_t/off_t conflation. No need to update plugin version
    because no plugin actually uses bufopen().
   
    Change-Id: I3db112449dc0b2eeb91c546f308880ac82494fc7

apps/buffering.c
apps/buffering.h
apps/playback.c
apps/plugin.h

But without some actual testing I can't say.

I stepped through the commits with:
Code: [Select]
git log --name-only v3.14-final..v3.15-finaland searched for references to playlist.

Annoyingly the ui simulator is not great for testing as it can't play any files - presumably because of the how the codecs are compiled for a different platform(?)

I tried to compile a build of 3.14 for you but I'm getting this:
Code: [Select]
git checkout v3.14-final
cd build/
echo 29 | ../tools/configure
make -j8

Quote
In file included from /foo/bar/Workspace/rockbox/rockbox/apps/plugin.h:64,
                 from /foo/bar/Workspace/rockbox/rockbox/apps/plugins/puzzles/rbcompat.h:4,
                 from <command-line>:0:
/foo/bar/Workspace/rockbox/rockbox/firmware/export/font.h:36:21: error: sysfont.h: No such file or directory
In file included from /foo/bar/Workspace/rockbox/rockbox/apps/plugin.h:64,
                 from /foo/bar/Workspace/rockbox/rockbox/apps/plugins/puzzles/rbcompat.h:4,
                 from <command-line>:0:
/foo/bar/Workspace/rockbox/rockbox/firmware/export/font.h:36:21: error: sysfont.h: No such file or directory
In file included from /foo/bar/Workspace/rockbox/rockbox/apps/plugin.h:64,
                 from /foo/bar/Workspace/rockbox/rockbox/apps/plugins/puzzles/rbcompat.h:4,
                 from <command-line>:0:
/foo/bar/Workspace/rockbox/rockbox/firmware/export/font.h:36:21: error: sysfont.h: No such file or directory
In file included from /foo/bar/Workspace/rockbox/rockbox/apps/plugin.h:64,
                 from /foo/bar/Workspace/rockbox/rockbox/apps/plugins/puzzles/rbcompat.h:4,
                 from <command-line>:0:
/foo/bar/Workspace/rockbox/rockbox/firmware/export/font.h:36:21: error: sysfont.h: No such file or directory
In file included from /foo/bar/Workspace/rockbox/rockbox/apps/plugin.h:64,
                 from /foo/bar/Workspace/rockbox/rockbox/apps/plugins/puzzles/rbcompat.h:4,
                 from <command-line>:0:
/foo/bar/Workspace/rockbox/rockbox/firmware/export/font.h:36:21: error: sysfont.h: No such file or directory
make: *** [/foo/bar/Workspace/rockbox/rockbox/apps/plugins/puzzles/puzzles.make:95: /foo/bar/Workspace/rockbox/rockbox/build/apps/plugins/puzzles/src/combi.o] Error 1
make: *** Waiting for unfinished jobs....
make: *** [/foo/bar/Workspace/rockbox/rockbox/apps/plugins/puzzles/puzzles.make:87: /foo/bar/Workspace/rockbox/rockbox/build/apps/plugins/puzzles/rbmalloc.o] Error 1
make: *** [/foo/bar/Workspace/rockbox/rockbox/apps/plugins/puzzles/puzzles.make:95: /foo/bar/Workspace/rockbox/rockbox/build/apps/plugins/puzzles/src/divvy.o] Error 1
make: *** [/foo/bar/Workspace/rockbox/rockbox/apps/plugins/puzzles/puzzles.make:95: /foo/bar/Workspace/rockbox/rockbox/build/apps/plugins/puzzles/src/drawing.o] Error 1
make: *** [/foo/bar/Workspace/rockbox/rockbox/apps/plugins/puzzles/puzzles.make:95: /foo/bar/Workspace/rockbox/rockbox/build/apps/plugins/puzzles/src/blackbox.o] Error 1
Logged

Offline saratoga

  • Developer
  • Member
  • *
  • Posts: 9137
Re: Different playlist behavior between Rockbox v3.14 and v3.15
« Reply #6 on: December 04, 2019, 04:04:14 PM »
Codecs work fine in the simulator, most of them were actually developed in it.
Logged

Offline Countryman

  • Member
  • *
  • Posts: 8
  • iPod 5G, 6G & 7G. iRiver H10 20GB & 6GB
Re: Different playlist behavior between Rockbox v3.14 and v3.15
« Reply #7 on: December 04, 2019, 06:04:02 PM »
Quote from: __builtin on December 04, 2019, 11:40:01 AM
3.14 was never released for ipod6g, since it was still "unstable" at release time.

I had it on my iPod 6g player until before 5 days.
It was installed with the help of RockBox Utility.
Logged

Offline saratoga

  • Developer
  • Member
  • *
  • Posts: 9137
Re: Different playlist behavior between Rockbox v3.14 and v3.15
« Reply #8 on: December 04, 2019, 06:51:51 PM »
Quote from: Countryman on December 04, 2019, 06:04:02 PM
Quote from: __builtin on December 04, 2019, 11:40:01 AM
3.14 was never released for ipod6g, since it was still "unstable" at release time.

I had it on my iPod 6g player until before 5 days.
It was installed with the help of RockBox Utility.

3.14 for the iPod 6g doesn't exist, so you probably had some other build.
Logged

Offline Countryman

  • Member
  • *
  • Posts: 8
  • iPod 5G, 6G & 7G. iRiver H10 20GB & 6GB
Re: Different playlist behavior between Rockbox v3.14 and v3.15
« Reply #9 on: December 04, 2019, 06:54:41 PM »
Daily build, maybe?
Logged

Offline bobba_mosfet

  • Member
  • *
  • Posts: 54
Re: Different playlist behavior between Rockbox v3.14 and v3.15
« Reply #10 on: December 05, 2019, 03:59:31 AM »
Quote from: saratoga on December 04, 2019, 04:04:14 PM
Codecs work fine in the simulator, most of them were actually developed in it.

Just re-compiled 3.15 and sure enough the simulator is playing fine now.

No guarantees but if I have some time I'll see if I can revert the playlist behaviour for 3.15 and get a build working for the ipod6g
Logged

Offline Countryman

  • Member
  • *
  • Posts: 8
  • iPod 5G, 6G & 7G. iRiver H10 20GB & 6GB
Re: Different playlist behavior between Rockbox v3.14 and v3.15
« Reply #11 on: December 05, 2019, 01:43:43 PM »
That would be so nice.
Thank you!
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Audio Playback, Database and Playlists
| | |-+  Different playlist behavior between Rockbox v3.14 and v3.15
 

  • SMF 2.0.18 | SMF © 2021, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.095 seconds with 16 queries.