Fiio M3k

[chris_s]

Please put it on Gerrit, chris_s, I would like to try that. It looks good.

Here you go: https://gerrit.rockbox.org/r/c/rockbox/+/3918

[chris_s]

You may want to also enable the "Screen Scrolls Out of View" option to truly take advantage of horizontal scrolling by long-pressing on the buttons in the upper corners. While it feels pretty weird at first, the ability soon becomes indispensable, in my experience at least.

https://download.rockbox.org/daily/manual/rockbox-fiiom3k/rockbox-buildch8.html#x11-1400008.4

[amachronic]

Really amazing job, amachronic! As for the discussion about keymaps (@cereal_killer and @diegopau), here's what works well for me. My main expectations/requirements were (iirc):

• Be able to stop playback by long pressing the power button from anywhere
• Get back to WPS by pressing Play/Pause
• Be able to scroll menus to the left/right to quickly see longer text strings that get cut off (not supported by the current keymap)
• See current playlist from WPS with single button press
• And be able to change volume by touch
• Return to browser from WPS with single button press
• Consistent activation of context menu in WPS/tree context

I left the Repeat-AB-Start/End button mapping and pretty much everything else unchanged at the moment. If anyone's interested in seeing the keymap, I can put it up on Gerrit. It only requires pretty minor adjustments compared to the current one though..

Your keymap looks pretty good to me, it's a bit more polished and thoughtful than what I spewed out. (Nice graphics, by the way!) I'll play with it a bit more over the weekend, but in all likelihood I'll merge it.

[chris_s]

Really amazing job, amachronic! As for the discussion about keymaps (@cereal_killer and @diegopau), here's what works well for me. My main expectations/requirements were (iirc):

• Be able to stop playback by long pressing the power button from anywhere
• Get back to WPS by pressing Play/Pause
• Be able to scroll menus to the left/right to quickly see longer text strings that get cut off (not supported by the current keymap)
• See current playlist from WPS with single button press
• And be able to change volume by touch
• Return to browser from WPS with single button press
• Consistent activation of context menu in WPS/tree context

I left the Repeat-AB-Start/End button mapping and pretty much everything else unchanged at the moment. If anyone's interested in seeing the keymap, I can put it up on Gerrit. It only requires pretty minor adjustments compared to the current one though..

Your keymap looks pretty good to me, it's a bit more polished and thoughtful than what I spewed out. (Nice graphics, by the way!) I'll play with it a bit more over the weekend, but in all likelihood I'll merge it.

awesome – one additional change that I had forgotten might be useful  and would also enhance consistency, is to be able to directly return  to the main menu from the browser using long-press on the menu button (just like you can from the WPS), specifically when you're at the leftmost scroll position and aren't already in the process of performing a horizontal scroll action. That would require this line to be added to button_context_tree_scroll_lr:

Code: [Select]

{ ACTION_TREE_ROOT_INIT,    BUTTON_LEFT|BUTTON_REPEAT,  BUTTON_LEFT }
but also needs line 757 in apps/gui/list.c to be changed to:

Code: [Select]

*actionptr = ACTION_STD_MENU;
My understanding is such that the latter should be changed anyway to make the code work like it is described in the comment above it (since only the menu action seems to skip to root), but I could be wrong.

[7o9]

thanks for these changes, chris_s.

the only thing i have not gotten used to yet is the 'view playlist' from them wps. i have been using that as play/pause since the start and now miss that. over time, i am sure i will adjust.

[diegopau]

I love all the new key assignations, thanks!!!. I also had a bit of trouble to adjust to not be able to pause/play with a tap in the touchbar but I understand why is done that way, it is the only possible quick access to the playlist with this new assignation.

Is anybody able to get the voice working? I have "voice menus" enabled, i have .talk files everywhere and "spell" set for the "voice filenames" settings. When I was in the old Vortex build it was working but I can't get it to work in this new native ones, maybe something changed in how it should be setup.

[chris_s]

In theory, you could simply not have any button assigned to 'View Playlist'. You'd still be able to access the functionality, by pressing either the WPS hotkey or using the context menu.

That's actually how it's handled by the iPod's current keymap (Select button returns you to browser and WPS hotkey is assigned to a Select+Play button combo. Not sure that's preferable though (I, at least, have modified my iPod's keymap to be able to press the Select button to display the current playlist in the WPS context and press the Menu button to return to the browser or a previous menu).

[diegopau]

I don't know if this is possible, but if the touchbar can have different assignations for sliding up/down and tapping up / tapping down, that would give us 2 extra buttons to assign.

Currently you can change volume by either tapping in the top/bottom area of the touchbar or sliding your finger up/down. I think it would be enough with sliding up/down for the volume, so you could use the tap gesture for other things (accessing the playlist for instance) and then restore the tap in the center for the pause/play which could be nice so you can do pausing with a touch button..

But as I said, it is pretty good at it is, just a possibility.

[amachronic]

I don't know if this is possible, but if the touchbar can have different assignations for sliding up/down and tapping up / tapping down, that would give us 2 extra buttons to assign.

It is possible.

[Sakura90]

Hi

Just installed Rockbox on my M3K. Amazing, next to the simplistic bare-bones OFs you have to suffer with DAPs this thing is magical. Now I can have proper scrolling, configurable as you please. I listen to classical which tends to have very long track names and the OF scrolled at 1px per second, useless. Had to guess for half my tracks. I haven't used Rockbox actively since the Fuze almost a decade ago. How time flies. Thanks to everyone making Rockbox possible

So far so good, no bugs, everything works. Except the screen turning off when locking (press power button to lock the buttons). Iirc the default was the screen turning off when locked but it's not the case here. I looked in the manual and suppousdly there's an option for that. 8.4 Display -> LCD Settings.

Backlight on Hold.
    This setting controls the behavior of the backlight when the Hold switch is toggled. If set to Normal the backlight will behave as usual. If set to Off the backlight will be turned off immediately when the Hold switch is engaged and if set to On the backlight will be turned on and stay on while the Hold switch is engaged.

That option is simply missing from the M3K display menu. The power button just locks the buttons and you have to wait for the screen timeout to turn it off. And long pressing power turns the system off. Any ideas?

[amachronic]

(...) Except the screen turning off when locking (press power button to lock the buttons). Iirc the default was the screen turning off when locked but it's not the case here. I looked in the manual and suppousdly there's an option for that. 8.4 Display -> LCD Settings.

Backlight on Hold. (...)

That option is simply missing from the M3K display menu. The power button just locks the buttons and you have to wait for the screen timeout to turn it off. And long pressing power turns the system off. Any ideas?

I do think that behavior (turning screen off right away) is better but the M3K doesn't have a hold switch, it has a software lock aka. "softlock."  Unfortunately it doesn't work the same way a hold switch does. I had a notion to make it work more like the hold switch but wasn't motivated enough and the code was too confusing. You might want to open a feature request on the bug tracker, just so it doesn't get totally forgotten.

Also, that option shouldn't be in the manual since it's only for devices with a physical hold switch.

[Sakura90]

I do think that behavior (turning screen off right away) is better but the M3K doesn't have a hold switch, it has a software lock aka. "softlock."  Unfortunately it doesn't work the same way a hold switch does. I had a notion to make it work more like the hold switch but wasn't motivated enough and the code was too confusing. You might want to open a feature request on the bug tracker, just so it doesn't get totally forgotten.

Also, that option shouldn't be in the manual since it's only for devices with a physical hold switch.

Interesting. I guess it makes sense from a developer point of view, a switch holding position on/off versus tracking button presses. But from a usability point of view they are essentially the same. In one put the switch to on and buttons lock and screen turns off, switch to off and both go back on. In the other you can have the same behavior with two button presses (just as the OF). I remember old Nokia phones (in the Symbian era) had a hold switch. Then Android came around and it used a button for lock. But both had the same functionality. I haven't seen a hold switch in devices, phones or DAPs, for a long time. It's all buttons now (for better or worse)

I'll open a feature request. Seems like something others might find useful too.

[diegopau]

Hi,

I noticed the following behavior related to the "Default Sleep Timer Duration" setting. This might not be M3k related, but for Rockbox in general, I don't know.

I created a shortcut for that setting. So now I can change it from:
A - Shortcuts => Default Sleep Timer Duration
B - Settings => General Settings => Startup/Shutdown => Default Sleep Timer Duration.

Now, in the case that the timer is already running: If I change the duration from location A, then the change doesn't have effect immediately, i have to stop the timer and start it again. If I change the duration from location B then it applies instantly, so for instance if the timer was running for 30 minutes and now I set the value for 1 hour it will immediately start counting down from 1 hour.
I find this strange so I think it might be considered a bug. Also it is useful if the change is immediate, because I can't add a shortcut to start/stop the timer.

[chris_s]

Hi,

I noticed the following behavior related to the "Default Sleep Timer Duration" setting. This might not be M3k related, but for Rockbox in general, I don't know.

I created a shortcut for that setting. So now I can change it from:
A - Shortcuts => Default Sleep Timer Duration
B - Settings => General Settings => Startup/Shutdown => Default Sleep Timer Duration.

Now, in the case that the timer is already running: If I change the duration from location A, then the change doesn't have effect immediately, i have to stop the timer and start it again. If I change the duration from location B then it applies instantly, so for instance if the timer was running for 30 minutes and now I set the value for 1 hour it will immediately start counting down from 1 hour.
I find this strange so I think it might be considered a bug. Also it is useful if the change is immediate, because I can't add a shortcut to start/stop the timer.

I think that isn't M3K-specific but still might be considered a bug or at least an inconsistency. By the way, in case you aren't aware, it is possible to manually add entries to the Shortcuts file that look like this if you want to start/stop the timer directly from the Shortcuts Menu:

Code: [Select]

[shortcut]
type: time
data: sleep 10
name: Sleep in 10

[shortcut]
type: time
data: sleep 20
name: Sleep in 20

[shortcut]
type: time
data: sleep 0
name: Disable Sleep Timer

[diegopau]

I reported the issue here https://www.rockbox.org/tracker/task/13319

But the trick that chris_s explained it not just awesome but also solves the issue for me. When switching between times in this way it does take effect immediately. Thanks!!