Do the iRiver H300 JOYSTICK LCD remotes work w Rockbox on an H1xx?

[Davide-NYC]

Would there be a way to make this an option in the menu?

General Settings-->System-->Remote Type

• LCD (Default)
• Blind
• Joystick

I'm not sure the 'blind' option is necessary. If the non-LCD remote is a subset of the LCD remote then I'd assume there would be no change programmatically. (Maybe I'm wrong)

Question:
Could this be implemented and committed then I could start bugging other people about fixing their plugins to check remote type and remap buttons accordingly, or better yet I would  attempt it myself as long as someone was willing to check my work. (I still suck at programming)
Correct?

 

[Llorean]

The preferred system is to have the remote type detected automatically.

[Davide-NYC]

OK. That is (of course) better.
As it stands now an H120 Rockbox build is not H300-Joystick-Remote "aware". How can we make it so that it is?
Would this be a CVS commitable patch since the remotes are autodetected?
I consider this core functionality, but maybe others don't.

[Llorean]

The remote doesn't work at all, or just doesn't have proper buttons yet? The word aware is very vague.

[Mmmm]

Hang on hang on....what's going on? Why would you want to manually select which remote you are using?

Doesn't my patch do the job??
I am aware that it breaks the simulator but that is easy to fix. You also wont be able to switch off the remote LCD which is also easy to fix. The plugins should work with this patch (the keys if not the screen) but only on the H300 remotes so that is a bit of a bonus!
EDIT: actually some plugins may not work...it depends on how they check the buttons, if they use button_get() they wont work and will all need to be slightly changed to remote_key_remap(button_get()).

I haven't committed it because I am waiting for the new button code to get committed first (as adding this now would just complicate things for the people working on the button code) and then ill look at it again and commit something.

Or have I just totally misunderstood everything you've said?

[Davide-NYC]

I might be a little over excited about my new remote. 
I had completely forgotten that the underlying button code was being re-written.
Sorry.   :'(

OK,
DLed CVS, applied REP patch, applied 300rem patch, compiled. Breaks the sim (of course) but seems to build fine normal. Will recording a show tonight (if I can get in with my iriver) and report back.

[Mmmm]

I've fixed the sim building and the LCD off button...press -10 to switch off the LCD.

Davide, If you could tell me exactly which plugins don't work with the H300 buttons, (not the LCD, just the buttons, the LCD is a whole new kettle of piranhas ) I can get them working too.

I should be getting my new remote soon (can't wait) so I thought I may as well get this patch going properly (and the button code revision seems to be taking longer than I thought  )


[attachment deleted by admin, too old]

[Mmmm]

Oops...now thats not going to compile is it? 

Here's a better one!

[attachment deleted by admin, too old]

[Davide-NYC]

Fresh CVS DL, your patch and during MAKE SIM got this:

Code: [Select]

LD rockboxui.exe
/home/Administrator/build/sim/apps/recorder/recording.o: In function `recording_
screen':
/home/Administrator/build/apps/recorder/recording.c:501: undefined reference to
`_remote_type'
collect2: ld returned 1 exit status
make[1]: *** [/home/Administrator/build/sim/rockboxui.exe] Error 1
make: *** [all] Error 2

I was using the SDL (default) option. I don't know if this means anything.
Also I'm using CYGWIN on WinXPSP2.
Maybe your source is old? I dunno.

[Mmmm]

Fresh CVS DL, your patch and during MAKE SIM got this:

Code: [Select]

LD rockboxui.exe
/home/Administrator/build/sim/apps/recorder/recording.o: In function `recording_
screen':
/home/Administrator/build/apps/recorder/recording.c:501: undefined reference to
`_remote_type'
collect2: ld returned 1 exit status
make[1]: *** [/home/Administrator/build/sim/rockboxui.exe] Error 1
make: *** [all] Error 2

I was using the SDL (default) option. I don't know if this means anything.
Also I'm using CYGWIN on WinXPSP2.
Maybe your source is old? I dunno.

Hmm weird...does it work with a normal build? have you got the REP installed too? because I dont think that builds for sim!
If you only have this patch installed, try deleting everything in your sim folder and then trying again. If it still doesn't work you'll have to wait till i'm back home in a week or so until I can fix it.

I'm using a build with it at the moment (I got my new remote just in time to go on holiday with it) so it should work in a normal build.

[Davide-NYC]

I use a fresh CVS DL with only the remote patch.
It does work with a NORMAL build. I was just reporting the broken SIM build.

When I do patch testing I do one patch at a time so that I can see what causes what problem.
So I actually do three (now two since disktidy has been commited!) separate builds.
If all single patch builds work then I go ahead and try another patch on top.

I also generally attempt a SIM build before a NORMAL build. So that would be six compiles (now reduced to four) before I even start combining patches.

I wish I was a better programmer, I'd set up a batch process and walk away.
As it is now I just multi-task as best I can.

Let me know if you need me to test something specific.

IN CASE ANYONE IS LOOKING FOR ONE OF THESE REMOTES:
http://cgi.ebay.com/ws/eBayISAPI.dll?ViewItem&item=180015706977
http://cgi.ebay.com/ws/eBayISAPI.dll?ViewItem&item=270016077241