Support and General Use > Audio Playback, Database and Playlists

Database list size (e.g. artists/albums) > global_settings.max_files_in_dir

<< < (3/3)

chris_s:
Hey William,

I’ve now noticed another issue introduced (or brought to light) by this commit.

Directly after selecting another theme (while a file must be playing), you may see the entries for the list of themes vanishing or being filled  with content that obviously doesn’t belong there (see attachment) – sometimes seemingly random assortment of characters or memory content.


The problem goes away after changing line 1045 from


--- Code: ---ptrdiff_t diff = (int32_t *) new - (int32_t *) current;
--- End code ---

to


--- Code: ---ptrdiff_t diff = new - current;
--- End code ---

Bilgus:
Huh I find it odd that casting them to int32* would cause issues how did you decide to try removing the casts?

I'll update the code

chris_s:

--- Quote from: Bilgus on February 06, 2019, 11:35:33 PM ---Huh I find it odd that casting them to int32* would cause issues how did you decide to try removing the casts?

I'll update the code

--- End quote ---
Honestly, I just saw that there was previously no casting, and didn't see it in other places in the codebase with similar pointer arithmetic (which i really only have basic experience with). I assumed it was worth a shot after other code changes couldn't explain the effect. I (unfortunately) don't have a good explanation.

Bilgus:
Thanks for the testing/update the new build should be up within the hour

chris_s:
Sure thing. Thank you! In case you figure out the explanation at some point, please let me know.

Navigation

[0] Message Index

[*] Previous page