Support and General Use > Audio Playback, Database and Playlists
Crossfade broken?
jhMikeS:
I know exactly what's happening now. Yes, it's due to short tracks not being handled gracefully. PCMBUF sees an auto skip (end of playlist is always auto skip), and the file is short enough that the crossfade is still active at the time, so it bails out (apps/pcmbuf.c line 703). It's not specifically end-of-playlist; having three files in the directory after the two provided will cause a bail on the second and transition to the third.
So, I got this one and have a couple more bugs in the heap that need to be handled. I've been derelict lately.
chrisjj:
--- Quote from: jhMikeS on December 27, 2016, 08:27:24 PM ---Yes, it's due to short tracks not being handled gracefully ... the file is short enough that the crossfade is still active at the time
--- End quote ---
Note that the fail occurs even when the 8s crossfade is (or should not be) still active at the time of the end of the 10s file, e.g. https://www.dropbox.com/s/ror2v8gwxbeqjwi/RB%20Crossfade%20fail%20on%20immediate%20skip.mpg?dl=0 .
But yes I do see the fail does not occur with 20s files: https://www.dropbox.com/s/hbwwuizqrqg28ym/RM%20Crossfade%20fail%20absent%20on%2020s%20files.mpg?dl=0
BTW, here's another case for verifying the fix. Instead of a Next, Files Select: https://www.dropbox.com/s/q1vxhibvb3b4f7w/RB%20Crossfade%20fail%20on%20Files%20Select%20second%20track.mpg?dl=0
jhMikeS:
Let's just say I know for a fact it's running that line in pcmbuf.c which will discard any PCM on the buffer. Selecting from the file browser is just a manual skip to playback.
chrisjj:
Fix seen here https://git.rockbox.org/?p=rockbox.git;a=commitdiff;h=6c837394ca6d7a988bfbdc9e97630e69f0bc2025 .
Thanks. Looking forward to trying it!
jhMikeS:
NP. I was going to put something here about it but the forums weren't responding so I figured I'd try again later.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version