Crossfade broken?

[chrisjj]

Is it just me, or is Crossfade broken?

I've tested it on Creative ZEN simulator (from rasher) and device (lcd_fix by pamaury).

I've followed the manual example https://archive.is/KEfsp#selection-515.0-520.0 giving this .cfg http://pastebin.com/w2zUp6aw , but look what happens when I play one track then click Right to skip to the next.

https://www.dropbox.com/s/i6zatmh2x38fxyu/Crossfade%20fail%20with%20keyclick.mpg?dl=0

I don't get the crossfade. I don't get the second track at all! Instead RB jumps back to the file browser, as if it had reached the Current Playlist end.

[Frankenpod]

Just tried using crossfade on ipod classic (build 161118, though its one I built myself with my own plug-in added, so not sure if that changes the build name), set to 'crossfade manual skip only', and it works fine in that case when I manually skip.

[chrisjj]

Thanks. Useful info.

Which iPod model of these http://rasher.dk/rockbox/simulator/

And what audio format?

[jhMikeS]

How long are each of the files? It's possible we would introduce nicer behavior for very short files. Can you post the very ones you were using?

[Frankenpod]

Thanks. Useful info.

Which iPod model of these http://rasher.dk/rockbox/simulator/

And what audio format?

Well, none of those (as I said) ipod Classic (informally known as 7.5 gen).  Actual hardware, not the simulator.  Though the ipod Video simulator is phenomenologicaly(!) the same.

mp3.

Works perfectly.

Are you sure its the crossfade that is the bug?  And what build of rockbox are you using?  Occurs to me, perhaps its because its only a two-track playlist.  Maybe its not seeing the final track of the playlist for some reason, so it thinks there's only one track?  What happens if you use a longer playlist?

[chrisjj]

Thanks for replying.

How long are each of the files?

10s. This is evident in the video.

It's possible we would introduce nicer behavior for very short files.

I've seen the behaviour for short files and it was reasonable. It skipped some fade, but never any audio.

Can you post the very ones you were using?

I lost the precise installation shown in my video, but I recreated it enough to reproduce the problem. Here are the files: https://www.dropbox.com/s/pkethfym31tkmuc/RB%20Crossfade%20fail%20tracks.zip?dl=0

Plus the whole installation (pruned of rocks and fonts) in case it helps: https://www.dropbox.com/s/si71db02cy4lotu/RB%20Crossfade%20fail%20on%20creativezen-sim-w32%205b52ff2-161212.zip?dl=0

[chrisjj]

Thanks. Useful info.

Which iPod model of these http://rasher.dk/rockbox/simulator/

And what audio format?

Well, none of those (as I said) ipod Classic (informally known as 7.5 gen).  Actual hardware, not the simulator.  Though the ipod Video simulator is phenomenologicaly(!) the same.

mp3.

Works perfectly.

Thanks. Good to hear.

Are you sure its the crossfade that is the bug?

No. hence the question :-) But if I turn off Crossfade, the problem disappears.

And what build of rockbox are you using?

The simulator is creativezen-sim-w32 5b52ff2-161212.

Occurs to me, perhaps its because its only a two-track playlist.  Maybe its not seeing the final track of the playlist for some reason, so it thinks there's only one track?  What happens if you use a longer playlist?

If I repeat Track 1 as Track 3, there's no change to the fail on Track 2, and Track 3 plays as expected.

Likewise if I repeat Track 2 as Track 3, there's no change to the fail on Track 2, and Track 3 plays as expected.

[jhMikeS]

10s. This is evident in the video.

As we know, we couldn't see the second one.

I've seen the behaviour for short files and it was reasonable. It skipped some fade, but never any audio.

It's just an idea of what's happening. Hence, the file request.

I lost the precise installation shown in my video, but I recreated it enough to reproduce the problem. Here are the files: ...

Thanks!

[chrisjj]

10s. This is evident in the video.

As we know, we couldn't see the second one.

We couldn't see the second one for long! :-) The second's duration shows as the 'time to go' number when its track title appears.



But perhaps we should not believe it, given at this point the track counter remains at 1 of 2, and when it does advance to 2 of 2, 'time to go' changes to zero -- on what looks like a bogus update.



This bogus update doesn't occur if I don't click Next, so perhaps it is a clue to the cause of the loss of the second track.

Also this bogus update doesn't occur with Crossfade off (regardless of whether I click Next), so perhaps it is independent (though related) issue with Crossfade.

[jhMikeS]

I've got it narrowed down to notice that it happens when manual skip fade is enabled without any automatic fading. Weird, but at least it suggests it's not due to short track length and not a major glitch in the pcmbuf mixing. I also noticed playback ends abruptly even though the pcm buffer still has many seconds of audio remaining of the final track.

[Frankenpod]

Thanks. Useful info.

Which iPod model of these http://rasher.dk/rockbox/simulator/

And what audio format?

Well, none of those (as I said) ipod Classic (informally known as 7.5 gen).  Actual hardware, not the simulator.  Though the ipod Video simulator is phenomenologicaly(!) the same.

mp3.

Works perfectly.

Thanks. Good to hear.

Are you sure its the crossfade that is the bug?

No. hence the question :-) But if I turn off Crossfade, the problem disappears.

And what build of rockbox are you using?

The simulator is creativezen-sim-w32 5b52ff2-161212.

Occurs to me, perhaps its because its only a two-track playlist.  Maybe its not seeing the final track of the playlist for some reason, so it thinks there's only one track?  What happens if you use a longer playlist?

If I repeat Track 1 as Track 3, there's no change to the fail on Track 2, and Track 3 plays as expected.

Likewise if I repeat Track 2 as Track 3, there's no change to the fail on Track 2, and Track 3 plays as expected.

I'm not clear what this means.  Are you saying with three tracks (and cross-fade enabled) it just skips the middle-track entirely?  Does it fade from the first to the third track?  Or just no fade effect at all, but it jumps straight from 1 to 3?

[Frankenpod]

I've got it narrowed down to notice that it happens when manual skip fade is enabled without any automatic fading. Weird, but at least it suggests it's not due to short track length and not a major glitch in the pcmbuf mixing. I also noticed playback ends abruptly even though the pcm buffer still has many seconds of audio remaining of the final track.

Is this only with the zen (or the zen simulator) or with any player?  Does it happen with all formats or only flacs?

Still seems to be working on my ipod, though have only tried it with very long playlists of mp3s (and shuffle play enabled). 

[chrisjj]

I've got it narrowed down to notice that it happens when manual skip fade is enabled without any automatic fading. Weird, but at least it suggests it's not due to short track length and not a major glitch in the pcmbuf mixing. I also noticed playback ends abruptly even though the pcm buffer still has many seconds of audio remaining of the final track.

I've found a third Crossfade issue which seems related and hence may help you to know.

Without Crossfade (settings http://i.imgur.com/Gakuydi.png ) , Files Select wihle track 1 playing start play on track 1, as expected:

1 In Files http://i.imgur.com/Rpperbk.png , press Select - see http://i.imgur.com/t0d2EJr.png
2 Press Select
3 In Files, http://i.imgur.com/kPc7V8U.png , press Select - see http://i.imgur.com/7lQcNhv.png . I see track 1.

With Crossfade (same settings as above http://i.imgur.com/2ZN8F9S.png ) Files Select during track 1 can start play on track 2.

1 In Files http://i.imgur.com/nFZi3kz.png , press Select - see http://i.imgur.com/sJXYorY.png .
2 Press Select
3 In Files, http://i.imgur.com/Ehcqi32.png, press Select - see http://i.imgur.com/7lQcNhv.png . I expected track 1. I see track 2.

[chrisjj]

If I repeat Track 1 as Track 3, there's no change to the fail on Track 2, and Track 3 plays as expected.

Likewise if I repeat Track 2 as Track 3, there's no change to the fail on Track 2, and Track 3 plays as expected.

I'm not clear what this means.  Are you saying with three tracks (and cross-fade enabled) it just skips the middle-track entirely?

Yup.

Does it fade from the first to the third track?  Or just no fade effect at all, but it jumps straight from 1 to 3?

It jumps straight from 1 to 3.

Is this only with the zen (or the zen simulator) or with any player?  Does it happen with all formats or only flacs?

It's not just on ZEN - it is on iPod 4g simulator too. I haven't tried others.

It's not just on the WAV format of the instance in my report - it is on MP3 too. I've not tried others.

[chrisjj]

Mike,

A longer playlist shows this track fail repeats.

With crossfade on manual track skip enabled, and manual track skip performed, every even-numbered track fails to play: https://www.dropbox.com/s/vo02h6l2pubh27m/RB%20Crossfade%20fail%20on%20long%20list%20-%20manual%20track%20skip%20performed%20%3D%20fail.mpg?dl=0

With no manual track skip performed, every track plays -- as expected.  https://www.dropbox.com/s/oi1bdiq50foto2r/RB%20Crossfade%20fail%20on%20long%20list%20-%20no%20manual%20track%20skip%20performed%20%3D%20no%20fail.mpg?dl=0

This bug can fail the odds too. https://www.dropbox.com/s/l5zi1e0kivl2tto/RB%20Crossfade%20fail%20on%20long%20list%20-%20manual%20track%20skip%20performed%20%3D%20fail%2C%20odd.mpg?dl=0

Interesting to see that crossfade code must have a state variable that's unintentionally hanging over somehow.