Selective Backlight and Advanced Softlock w/Autolock - TESTING NEEDED

[Bilgus]

Selective Backlight and Softlock

General Settings>Display>LCD Options>Selective Backlight:
Allows users to select actions that when within WPS or FMS will not activate the backlight

Backlight Options:

• Volume
• Play
• Seek
• Skip
• Disable Unmapped Buttons
  Buttons that do not call a setting will be ignored (some still do and will get fixed as they are found)
• Disable on External Power
  When plugged goes back to regular behavior

General Settings>System>Advanced Softlock: (Devices without a hold button)
Allows users to select actions that when within WPS or FMS will not be blocked by the screen lock

Softlock Options:

• Volume
• Play
• Seek
• Skip
• Auto Lock
  When the backlight turns off, softlock will lock the screen,
  Activates when you press the lock key and if you manually lock again
  while active it then disables autolock (currently only for devices with backlight)
  
  • (Lock Button Pressed #1) >Auto Lock On (device still unlocked till backlight timeout)
  • (Lock Button Pressed #2) >Auto Lock Off (device locked)
  • (Lock Button Pressed #3) >(device unlocked)
• Disable Touch
  Blocks touch screen buttons like the original (only for touch devices)
• Disable Notify
  Doesn't notify 'Buttons Locked' (still will if power button is pressed)

Source is on Gerrit
http://gerrit.rockbox.org/r/#/c/1417/

(All Sansa, IPOD, Archos, Creative, etc. 73 in all )
I have a bunch of compiled firmware built with the latest build here:
 
http://www.mediafire.com/?tl0828dq7lq1c THIS FEATURE IS IN 3.14

If you don't see your player and would like a build let me know and I will add it to the list.
Edit: All the firmware is in above link

Thanks Johnb, TorC, Pamaury, __Builtin, Chrisjj[/list][/list][/list][/list][/list]

[johnb]

Hi Bilgus,

I feel I still need to understand the use case for "Disable Unknown"...

For instance, on my FuzeV2 when this is turned on, if I click the Select, Menu or Home button the BL stays off, but it takes me into the respective menu (without really knowing, especially if it was not intended). As soon as I use the scroll wheel or any other button, BL turns on and a real selection might have happened already.

So what is it good for?

[Bilgus]

The Idea was to prevent an unmapped action from turning on the backlight.
For instance hitting select and up (or vol up and select) which doesn't map to an action turns on the backlight.

If this Is causing problems then I'll have to look into it I'm probably overriding the conditional that turns on BL on context change, if it becomes too much of a pain I'll remove it.
Thanks

Edit:
Fixed on Gerrit, Ill add updated firmware soon New Firmware is up

[johnb]

So it's only about unintended concurrent clicks of some keys like my earlier (Vol+ & Vol-)? ;-)

I just installed the latest version ...

[johnb]

FuzeV2: the behaviour I described above is gone with that build.

But I believe I found another bug:
Situation:
SelBL is on, all in Settings have been active but Seek.

When I go into Settings and activate Seek and back out, I am asked whether I want to save, which I confirm.
But now Seek still activates BL. Shutting down the player and restarting, it works as expected.

I managed to do this several times, but it's not always reproducible.

[Bilgus]

That would be the settings menu missing the activation of the new settings, it happens when you use the cancel button to exit the menu, I actually thought I fixed that already :/
I imagine the selective softlock menu will do it as well.

Fixed Ill add it once I get a few other things to add

[Bilgus]

I fixed the menu issue and added an option for Auto Lock to the softlock menu

[johnb]

I assume "Auto Lock" should activate the SL after some timeout. On my clip+ it doesn't ...

[Bilgus]

You have to lock it once to activate then it will auto lock after you unlock Currently it disables when you exit the wps/fms. I really found the disable on exit annoying testing it today so ill probably change it to long press of the key lock disables. Ill probably leave it so locking once activates it though.

[Bilgus]

Latest is on gerrit and link above

Auto lock now activates when you press the lock key and if you lock again while active it then disables autolock
I thought about using long press but since some players might use the power button for keylock I decided that could be bad.

I also fixed a bug where pressing a non filtered key and then pressing a filtered key within the timeout allowed the filtered key through softlock.

[chrisjj]

TEST ENVIRONMENT

Creative ZEN (2Gb, tester's unit P)

TEST PREPARATION

Install https://www.mediafire.com/?tl0828dq7lq1c creativezenmozaic-SEL_BL-SL_-rockbox_Vbf177ae-161210.zip

TEST PROCEDURE

1 Unplug external power
2 Go to Settings, General Settings, Display, LCD Settings, No Backlight on Selected Actions
3 Select Off (changes to On)
4 Under Settings, select Volume, Play, Seek, Skip (each changes to show a + to left)
5 On Now Playing, wait until backlight goes out
6 Do Volume up/down, Play, Seek right, Skip right (Seek left and Skip left are non-operative)
7 Verify backlight does not engage.

8 Go to Settings, General Settings, Display, LCD Settings, No Backlight on Selected Actions, Settings
9 Select 'Disable on External Power' ("When plugged goes back to regular behavior")
10 Plug-in external power
11 On Now Playing, wait until backlight goes out
12 Do Volume up/down, Play, Seek right, Skip right (Seek left and Skip left are non-operative)
13 Verify backlight does engage.

This omits Disable Unknown ("Unknown actions will not turn on the backlight") because I don't know what constitutes an Unknown action.

This omits Selective Softlock and Softlock Options because TMK (in absence of a Rockbox manual for this model) this model does not have a softlock and none is mentioned in the Rockbox manual for another model https://download.rockbox.org/manual/rockbox-sansaclipplus.pdf

TEST RESULT

Success!

FURTHER COMMENT

I suggest the UI labelling could be made a lot more comprehensible. For example, I suggest the Settings mutually exclusive commands Off (that turns the feature on) and On (that turns the feature off) would be better replaced by an On command that turns the feature on and an Off command that turns it off, with a suffixed asterisk on whichever was in effect.

[Bilgus]

Latest firmware is up on mediafire

Scroll wheel is fixed for the Ipod menu names have changed, code has been cleaned up

Testing appreciated

[Bilgus]

Final code is up on Gerrit as are compiled firmware (see link at top)

Barring bugs or some awesome feature I consider this patch done.

There are a few button fixes for Sansa targets as well that haven't been added to the compiled firmware but are on gerrit

Clip, Clip+ ClipZip:
Fix FMS Volume-long press Up and Down button actions for SANSA CLIP derivatives
http://gerrit.rockbox.org/r/#/c/1444/

Fuze, Fuzev2:
Make short press of SELECT in FMS return ACTION_NONE on Sansa Fuze
http://gerrit.rockbox.org/r/#/c/1445/