Rockbox General > Rockbox General Discussion

Rockbox, my master, I am not worthy!

<< < (2/6) > >>

G4Oblivion:

--- Quote from: rbhawaii on April 22, 2016, 08:43:23 PM ---could somebody PLEASE patch the 3.13 build with above patch? PLEASE PLEASE x1000! please!   :)
--- End quote ---

Here you go: ipodvideo-v3.13.zip
I don't own an iPod Video so this is completely untested.

I synced the patch against v3.13-final without all the horrible whitespace changes in case anyone wants to look at it: https://gist.github.com/anonymous/5f3bcab69a01fdfa9f47bac73b74cf10
edit: Whoops. Forgot to remove all the trailing whitespace. Oh well

I suggest you look into what's wrong with your theme when you have time. There were a lot of changes to the skin engine in 2013/2014.
1) Build and run checkwps and use checkwps to check the theme (I'm unsure if there's any recent prebuilts)
2) Look through https://github.com/Rockbox/rockbox/commits/master/apps/gui/skin_engine
3) Use CustomWPS as a reference
4) Test changes in the simulator

If you're still unable to figure it out or suspect it's a bug in Rockbox, you can hop on to Rockbox's IRC channel and ask the developers.
IIRC, JdGordon and [Saint] would probably know the most about themes assuming they're still active.

It's been a long time since I've messed with themes/Rockbox, so some of my information may be incorrect.

rbhawaii:
G4Oblivion - Thank you so much!!! i used your ssd patched 3.13 for close to 2 hours and had ZERO problems, it works perfectly.  My theme works perfectly too now!  It's so great to have this ipod working so well like it this - you have no idea!  I don't think I need to try to fix my wps now because it works perfectly in 3.13 and i don't think 3.14 will ever come out. 

If you are interested in my theme for your player with my custom eq graphic status settings -  i will be happy to send it to you but your simulator will need to be 3.13. it took me many months of trial and error to get the eq settings to display perfectly. Anyway i'm real happy now and I owe you a big thank you!  If you like I have a big collection of channeled audios of higher knowledge I can send you as a sign gratitude!  Lmk


by the way... what is white space and trailing white space?  How does it affect the build if it is not removed? is it worth to redo the build with all the white space removed?

Thanks!

G4Oblivion:
No problem. I already had everything set up so it only took a few minutes to patch, build and upload.

The whitespace changes in the patch have no effect on how the patch functions. They're unnecessary changes that introduce a lot of spaces/tabs in the source code that aren't needed or unnecessarily change line indention. Why is that bad? It makes the patch harder to read and less likely to apply later on due to it changing more lines than necessary.

rbhawaii:
got it. im sure many people will find your patched 3.13 version useful.
thanks again

ecereb:
I have installed the Zheino 256gb from www.zheino.com.  The iPod works flawlessly with the patched version of the 3.13 build.

Though the iPod with the above version of RockBox does work with an SSD, the battery slowly drains out totally dead in about three or four days with it in shutdown.

I booted into the Apple firmware and it was three days and the battery remained fully charged.

Is anyone else experiencing the same issue with their Zheino 256gp or Talent SSDs?

Note.  I swapped out the battery for another one with the same results.

Thanks.

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version