Support and General Use > Hardware
Xduoo x3
speachy:
--- Quote from: saratoga on June 27, 2018, 10:50:50 PM ---Should ask him for his name and add him to the credits.
--- End quote ---
Email sent. I guess we'll see if anything comes back..
Assuming that "vortex" supplies an attributable name, what's next? Push the commits to gerrit for review? (I'm assuming they'll need some further work, and I'm willing to do it..)
speachy:
--- Quote from: pizza on June 28, 2018, 06:42:52 AM ---Email sent. I guess we'll see if anything comes back..
--- End quote ---
I now have the author's real name, and his blessing to get this stuff mainlined.
How should I proceed?
wodz:
Push to gerrit for review. However without device to test I don't think it is worth the hassle.
speachy:
--- Quote from: wodz on June 28, 2018, 10:02:32 AM ---Push to gerrit for review. However without device to test I don't think it is worth the hassle.
--- End quote ---
For some time, I've wanted to meaningfully contribute something back to rockbox, and this seemed like a relatively simple way to get familiar with rockbox's codebase -- and one that will yield both immediately useful results and provide a stepping stone to other ports.
I'm no stranger to working with bare-metal embedded code, low-level OS tinkering, and writing device drivers after reverse-engineering efforts, so this sort of stuff is right up my alley.
I have a few more things to clean up and then I'll push the commits to gerrit so they can be bled on.
speachy:
The patches are now in gerrit:
http://gerrit.rockbox.org/r/1854
http://gerrit.rockbox.org/r/1855
Should I add anyone specifically to do reviews?
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version