Clip+: Begging for Help with My Theme

[Curmudgeon]

Anybody willing to look at my code and spot errors?

Trying to create a theme. Have coded elsewhere (Fortran, VB, C++) for decades and (to best of my ability) have RTFM. (It could be a little more specific in places.)

Trying to run my code in rockboxui simulator. Haven't tried it on actual device yet -- Want to use it regularly!

Should would appreciate a kick in the butt hint what's going on.

[Bryanhoop]

Your viewports in:

# ***************************** AREA IN THE MIDDLE OF THE SCREEN **********************

have an extra '0' value.

Also keep in mind that the screen is divided into 3 parts. 16 yellow rows, 2 dead rows, and 48 cyan rows.

[Curmudgeon]

Thank you, Bryanhoop. I've corrected the viewports. That was easy. However, based on your info re: yellow/dead/cyan rows, I have to re-think my entire layout. That's going to take a while, but I'll be back, when that's done.

BTW, I tried to find the specs concerning the Clip+ display, but failed. Where was it hiding? Further, what was Sansa thinking when they designed it this way?

[saratoga]

Theres detailed datasheets for the display on google (you can buy it for your own projects if you want), but its a monochrome display (1 bit per pixel), 128x64 pixels divided into two different color sections like Bryan said. 

[Curmudgeon]

Successful progress report:
Bryanhoop pointed out two coding errors, plus info on the specifics of display screen. This forced me to rearrange my usage of the display's "real estate".  Also, it let me proceed to a point that revealed that, for the larger fonts I wanted, I had too many things on the screen, forcing me to reduce my expectations. Result: I've gotten very close to a theme that functions well for me.

Saratoga further discussed the details of the display. This encouraged me to dig deeper on the web. Results:
1. The display is essentially two displays in one.
2. It is up eight 'pages', each 8-pixel 'rows' high, yielding 64 rows of pixels.
3. Two pages (16 rows) at the top of the display, monochrome yellow.
4. Four pages (48 rows) at the bottom of the display, monochrome cyan.
5. Between the top and bottom, there's an unusable black gap.
     a. It consumes none of the 64 rows.
     b. I think it's there for efficient manufacture of the display.
6. When coding, it's possible to have a viewport that crosses the black bar, but it's distracting (to me, anyway).
To confirm this, I added the following to a .wps:
   %pb(2,1,123,4,pb-128x64x1.bmp) # thank you, cabbiev2.wps
   %V(2,17,124,1,1)
   %xd(b)
   %V(2,18,124,1,1)
   %xd(b)
The two lines appear on the display.

SO, CASE CLOSED --------------- i think