Support and General Use > Theming and Appearance Customization

Cover Art on barebones 1080x1920 WPS

(1/4) > >>

AidanSonoda:
Thanks to [Saint] and ZincAlloy's assistance in the Unsupported Builds section I've got Rockbox working fairly well (just a few outstanding issues) on my Galaxy S5. I can't seem to get my barebones wps to display cover art though. (screencap and wps attached).

I do not believe that the art itself is the issue. It is embedded art, but it displays just fine in the notification tray (screen cap attached) so on some level rockbox can certainly access it. I also tried tossing in a simple cover.bmp and that too displayed in the notification tray, but not my WPS.

I tried the suggestions outlined -here- … namely a super simple %Cl(0,0,500,500) and placing the %Cl & %Cd at the bottom of the file - without any luck.

I surely hope someone can set me straight! I've had a lot of fun learning about customizing rockbox trying to get it working on this device.

[Saint]:

--- Quote from: AidanSonoda on February 20, 2015, 02:22:07 AM ---Thanks to [Saint] and ZincAlloy's assistance in the Unsupported Builds section I've got Rockbox working fairly well...

--- End quote ---

Speak of the devil, or the saint, as it were...jere I am!

I can't remember what I did, but if it helped you - well, that's just swell. I'm happy for you.

Now regarding album art in your WPS, were I to put my speculation hat on (its my favourite hat), I would say that the issue is almost certainly overflowing the fixed buffer space. Now, I could get into a deep and meaning{ful|less} conversation about why having a static buffer allocation for all application targets, regardless of screen resolution is a hilariously bad idea, but I won't.

I will, however, point you to this gerrit task (Increase memorysize for Android build.) which attempts to alleviate this issue by way of allocating (still static - but its an improvement) buffers based on target resolution. 8MB for 540p or less, 16MB for greater than 540p and less than 720p, and 32MB for greater than 720p.

Which this still isn't ideal, this is a vast improvement over the current situation, which seems short sighted but one must keep in mind the fact that at the time this application target port was created current flagship devices were 480p, and the most common resolution for Android devices at that point in time was 240x320, which made the buffer allocations a little on the small side but still largely adequate.

If you require some assistance compiling RaaA, either with this patch installed, or in general, I would be more than happy to oblige you.

Push come to shove, I could even supply you with a patched build directly, though I would rather teach a man/woman/gender-agnostic-meat-sack to fish - as the analogy goes...

Let me know either way, I will be more than happy to assist you.

PS: the other scenario is that you may or may not be trying to display progressive jpeg images, which Rockbox does not support.


[Saint]

AidanSonoda:
I'm very willing to learn to fish (or try anyway). I run Debian so I think I can manage the compilation assuming this guide is accurate. I've got no idea how to go about integrating that patch though.

If you're willing to give me the idiots guide treatment for the whole thing that would be absolutely great, but if you don't really have the time I think I can limp through everything but the patching on my own.

Thanks in advance,

Aidan

P.S. I'm thinking that the failure to load the bmp I tried means it isn't a progressive jpg issue?

[Saint]:
The guide you linked is accurate.

We also have an fairly well established development section in the wiki (the aforementioned guide is a part of it), a portion of which details working with patches.

You will notice in the gerrit task I linked, that there are four buttons checkout, pull, cherry-pick, and patch. Each prints a different command to be entered into the command line, and each depends vastly on what it is precisely you're wanting to do. The easiest option would be to use 'patch', and to pipe that directly to a text file.

For your convenience, I shall add the command required to do so here:

--- Code: ---git fetch git://git.rockbox.org/rockbox refs/changes/56/956/2 && git format-patch -1 --stdout FETCH_HEAD > ~/increase_memory_size_for_android_build.patch
--- End code ---

Which (when run from the top level of your Rockbox git checkout) will drop the file 'increase_memory_size_for_android_build.patch' in your user's $HOME directory.

To apply the patch, you would then use this command (again, to be run from the top level of your Rockbox git checkout):

--- Code: ---patch -p 1 < ~/increase_memoery_size_for_android_build.patch
--- End code ---

If you run into a snag, or have any more questions, I would be happy to answer them for you.


[Saint]

AidanSonoda:
Ok, had a crack at this, but got hung up trying to run the setup script "rockboxdev.sh"


--- Quote ---aidan@SonodaPC:~/rockbox/tools$ sudo ./rockboxdev.sh
ROCKBOXDEV: "libtool" is required for this script to work.
ROCKBOXDEV: Please install "libtool" and re-run the script.
--- End quote ---

clear enough, unfortunately libtool is already installed:


--- Quote ---aidan@SonodaPC:~/rockbox/tools$ sudo apt-get install libtool
Reading package lists... Done
Building dependency tree       
Reading state information... Done
libtool is already the newest version.
0 upgraded, 0 newly installed, 0 to remove and 81 not upgraded.
--- End quote ---

not sure what my next troubleshooting step should be. Sorry for my, most likely infuriating, ignorance.

Navigation

[0] Message Index

[#] Next page

Go to full version