3.0 release: remote support for h1xx

[TiMiD]

For the virtual keyboard, I think a complete rewrite would be the best option, using same code for both screens of course with the list of letters scrolling when the screen is too small.

As for the missing screens, it's very simple to guess where some work is needed ; doing a "grep -r lcd_ *|grep -v plugin" gives the list of the applications still using the old display functions

There are also some displays done in the firmware part of the code (for example rolo).
In that case I think the better way would be to rewrite the application to split it into a kernel code part and user space code part since anyway kernel code doesn't have to interract directly with the user, this is a conception error.

[Hansmaulwurf]

"2 Jul 12:28   Kevin   added support remote support for the id3 infos screen (had to slightly change the list engine to use it here as well), corrected a mistake in the french translation"


I cant exit the id3 info screen with remote Buttons. I can scroll the list, and shut down the Player with remote-buttons, but cant exit the screen.

Using CVS build 2006-07-02 12:28:46 with H120 Player and remote.

[TiMiD]

Ooops I forgot remote buttons

[PPP]

I don't know, if it would be a new feature and if it's possible, but it would be great to have an own font for the remote.
i use the player primarly in my car, and the small fonts for the WPS are too small. If i change the font to a big one,
the standard WPS looks broken.

[Mmmm]

Woo hoo...remote support for virtual keyboard done!!!

PHEW!!! That was a challenge!

http://www.rockbox.org/tracker/task/5628

The only thing missing is page flip while in morse mode but that isn't that important I don't think.....or maybe it is.....Anyway, I need a breather before I think about that...

So that should complete remote support for V3.0 I think....  

[TiMiD]

I looked at your patch and I don't think it's the way to go
first it adds code a lot of complexity and reduces lisibility a lot (there are more clever ways to implement the remote support for a module (in my opinion) than to "just" wrap drawing related instructions with a FOR_NB_SCREENS, even if this would of course requires to change the code structure a lot more)
also I don't like the fact to have the 2 keyboards desynchronized, I mean differents layouts for each screen

PS : Don't take this personnaly, but I really think it's important for this project to have a readable and reusable code over all.

[Mmmm]

also I don't like the fact to have the 2 keyboards desynchronized, I mean differents layouts for each screen

But surley if the screens are the same then we are loosing the advantage of having a large main display. The way I have done it the main screen and the remote behave as if they are different players -but giving the same output  (the small remote screen being dealt with just as any other small screened unit).

Or maybe you mean the fact that each screen doesn't necessarily have the same letter highlighted? The select button on the unit/remote only 'looks' at the screen the button is on, so there would be no confusion whichever screen you were using....only if you were looking at one screen and using the buttons on the other!

PS : Don't take this personnaly, but I really think it's important for this project to have a readable and reusable code over all.

Don't worry I'm not offended.... I did my best but I don't think I would be able to totally re-write the code from scratch so I won't be trying!

[Dwyloc]

So that should complete remote support for V3.0 I think....  

Thanks for putting the required effort into remote support, as someone how uses the remote a lot it is very frustrating when I have to use the main unit to load bookmarks when I am out and about so I am really looking forward to your remote bookmark support patch being committed.

I am also very happy to see your other remote patches being added as each one that is committed reduces the chance of me and other users getting stuck in an unsupported screen when we are using our remotes and also makes Rockbox look even more professional to other potential users.

[TiMiD]

For the virtual keyboard, I think it would be nice to have a scrolling keymap, to display large alphabets on smalls screens (I'm thinking about japanese kanas on the remote for example)

Also about your patch, it can be commited, as it would be good for the users anyway.

If I find some willpower I will try to rewrite this part from scratch (it was the solution I choosed for some other gui component) but somehow I feel boring when coding ...

So let's see what will happen

[Mmmm]

Thanks for putting the required effort into remote support, as someone how uses the remote a lot it is very frustrating when I have to use the main unit to load bookmarks when I am out and about so I am really looking forward to your remote bookmark support patch being committed.

I am also very happy to see your other remote patches being added as each one that is committed reduces the chance of me and other users getting stuck in an unsupported screen when we are using our remotes and also makes Rockbox look even more professional to other potential users.

Glad this is going to make things easier for you Dwyloc, and glad you like the patches, Cheers!

For the virtual keyboard, I think it would be nice to have a scrolling keymap, to display large alphabets on smalls screens (I'm thinking about japanese kanas on the remote for example)

If you press the mode button on the remote (and on the main screen if the character set is large) it will flip screens! So if you were to load japanese Kanas it should work already!

Also about your patch, it can be commited, as it would be good for the users anyway.

Good stuff!

If I find some willpower I will try to rewrite this part from scratch (it was the solution I choosed for some other gui component) but somehow I feel boring when coding ...

So let's see what will happen

I know what you mean...It's hard to get started, but once you start it's hard to stop and once you stop (and it works), it feels oh so good!

[Mmmm]

Hmmm I've been compiling with the virtual keyboard for all targets just to test if everything is ok...Found a few bodge ups and fixed them but for the Archos FM Recorder (3) and  the Archos Recorder V2 (4) I get the following compiling error:

Code: [Select]

LD rombox.elf
/home/Martin/crscomp-sh1/bin/../lib/gcc-lib/sh-elf/3.3.6/../../../../sh-elf/bin/ld: region FLASH is full (/home/Martin/build/rockbox/compiled/apps/rombox.elf section .rodata)
collect2: ld returned 1 exit status
make[1]: *** [/home/Martin/build/rockbox/compiled/apps/rombox.elf] Error 1
make: *** [all] Error 2
At a guess I'd say it looks like the code is just too much for their tiny flash memories! How on earth are you supposed to get around this? Does anybody know?

[petur]

didn't know they had remotes... ?

amiconn will be pleased to see you're filling the flash, good for you he doesn't read the forums much :p

I'd say, try to optimize the code a bit?

[Llorean]

How much does your code increase the size by, that it pushes rombox over?

[Mmmm]

Ta for the suggestions...Amiconn came up with the answer: I was using an old cross compiler which churns out elephant binaries!  Shame on me!

So it was a false alarm, the patch is fine...hoorah! \0/

[fizze]

well I use a H300, but the H100 LCD remote. its working like a charm, with paulheu's experimental build and some patches, albeit.
I donno how many of those patches made it into CVS recently.