Support and General Use > Hardware
3.0 release: remote support for h1xx
TiMiD:
I looked at your patch and I don't think it's the way to go
first it adds code a lot of complexity and reduces lisibility a lot (there are more clever ways to implement the remote support for a module (in my opinion) than to "just" wrap drawing related instructions with a FOR_NB_SCREENS, even if this would of course requires to change the code structure a lot more)
also I don't like the fact to have the 2 keyboards desynchronized, I mean differents layouts for each screen
PS : Don't take this personnaly, but I really think it's important for this project to have a readable and reusable code over all.
Mmmm:
--- Quote from: TiMiD on July 03, 2006, 09:40:13 AM ---also I don't like the fact to have the 2 keyboards desynchronized, I mean differents layouts for each screen
--- End quote ---
But surley if the screens are the same then we are loosing the advantage of having a large main display. The way I have done it the main screen and the remote behave as if they are different players -but giving the same output (the small remote screen being dealt with just as any other small screened unit).
Or maybe you mean the fact that each screen doesn't necessarily have the same letter highlighted? The select button on the unit/remote only 'looks' at the screen the button is on, so there would be no confusion whichever screen you were using....only if you were looking at one screen and using the buttons on the other! :D
--- Quote ---PS : Don't take this personnaly, but I really think it's important for this project to have a readable and reusable code over all.
--- End quote ---
Don't worry I'm not offended.... I did my best but I don't think I would be able to totally re-write the code from scratch so I won't be trying! :)
Dwyloc:
--- Quote from: Mmmm on July 03, 2006, 08:30:26 AM ---So that should complete remote support for V3.0 I think.... :) 8)
--- End quote ---
Thanks for putting the required effort into remote support, as someone how uses the remote a lot it is very frustrating when I have to use the main unit to load bookmarks when I am out and about so I am really looking forward to your remote bookmark support patch being committed.
I am also very happy to see your other remote patches being added as each one that is committed reduces the chance of me and other users getting stuck in an unsupported screen when we are using our remotes and also makes Rockbox look even more professional to other potential users.
TiMiD:
For the virtual keyboard, I think it would be nice to have a scrolling keymap, to display large alphabets on smalls screens (I'm thinking about japanese kanas on the remote for example)
Also about your patch, it can be commited, as it would be good for the users anyway.
If I find some willpower I will try to rewrite this part from scratch (it was the solution I choosed for some other gui component) but somehow I feel boring when coding ...
So let's see what will happen :)
Mmmm:
--- Quote from: Dwyloc on July 03, 2006, 07:47:34 PM ---Thanks for putting the required effort into remote support, as someone how uses the remote a lot it is very frustrating when I have to use the main unit to load bookmarks when I am out and about so I am really looking forward to your remote bookmark support patch being committed.
I am also very happy to see your other remote patches being added as each one that is committed reduces the chance of me and other users getting stuck in an unsupported screen when we are using our remotes and also makes Rockbox look even more professional to other potential users.
--- End quote ---
Glad this is going to make things easier for you Dwyloc, and glad you like the patches, Cheers! :)
--- Quote from: TiMiD on July 03, 2006, 10:25:44 PM ---For the virtual keyboard, I think it would be nice to have a scrolling keymap, to display large alphabets on smalls screens (I'm thinking about japanese kanas on the remote for example)
--- End quote ---
If you press the mode button on the remote (and on the main screen if the character set is large) it will flip screens! So if you were to load japanese Kanas it should work already!
--- Quote ---Also about your patch, it can be commited, as it would be good for the users anyway.
--- End quote ---
Good stuff!
--- Quote ---If I find some willpower I will try to rewrite this part from scratch (it was the solution I choosed for some other gui component) but somehow I feel boring when coding ...
So let's see what will happen :)
--- End quote ---
I know what you mean...It's hard to get started, but once you start it's hard to stop and once you stop (and it works), it feels oh so good! :D
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version