Rockbox Development > Feature Ideas

lrcplayer: ignored prefixes and suffixes in file names

<< < (3/3)

saratoga:
I think you vastly overestimate how many users have this problem.  But perhaps someone will take an interest in changing the lyrics plugin. In the meantime I suggest you take saints advice.

[Saint]:

--- Quote from: GCRaistlin on January 05, 2015, 05:23:32 PM ---
--- Quote from: [Saint] on January 05, 2015, 04:21:43 PM ---Where is it that you are getting this estimation of 'many users' from?

--- End quote ---
That's simply. Do many users get their media collections from torrent trackers? Yes. Would many users like to update their media collections with higher quality ones if possible? Yes. Are there uploaders who doesn't take trouble to fill Lyrics tag? Yes. Does every uploader have his/her own opinion of the ideal torrent file structure? Yes.
Summarizing all of the above gives the answer: many users (of those who bother about the lyrics, of course) should work somehow with their lyrics collections after updating their media collections.

--- End quote ---

I won't bother going into the reasons why its wrong to extrapolate in this fashion.



--- Quote from: GCRaistlin on January 05, 2015, 05:23:32 PM ---
--- Quote from: [Saint] on January 05, 2015, 04:21:43 PM ---My count puts the amount of people who have ever seen this as an issue at precisely one, yourself.

--- End quote ---
I'm just the one who took trouble to give the idea how to resolve the issue :)

--- End quote ---

This in an indirect way of backing up my statement, not adding weight to yours. You and you alone (to my knowledge, and the knowledge of at least one other), in the 8 going on 9 years that this has been possible, are the only person who has bothered to put this much effort into thinking about this. Which honestly I don't find at all surprising, given your slightly weird use case.



--- Quote from: GCRaistlin on January 05, 2015, 05:23:32 PM ---
--- Quote from: [Saint] on January 05, 2015, 04:21:43 PM ---I would posit that in most instances, in your stated use case of replacing a given low bitrate/quality album with a given high bitrate/quality album, that they would simply cut/copy and paste over the top of the original, which would leave any user generated files such as lyrics, bookmarks, playlists, album art etc. in place.

--- End quote ---
Yes - provided that file names and directory structure are the same. Do I have to say that it's not very likely scenario in case of different uploaders?

--- End quote ---

As stated prior, this would not be an issue at all if the user bothered to take what is quite literally a minute out of their time to run the media through any number of auto-taggers, such as the one I linked earlier.

Additionally I find it somewhat hard to believe that someone who would care about having lyrics files, would not care about their media collection having random and/or incorrect metadata, and/or various different file name and directory structure styles.



--- Quote from: GCRaistlin on January 05, 2015, 05:23:32 PM ---
--- Quote from: [Saint] on January 05, 2015, 04:21:43 PM ---That's a bold statement. My metadata is certainly correct. I posit that this is the case for a great many of our user base.

--- End quote ---
We're still saying about lyrics, aren't we? The main issue here is that's hard to say is lyrics correct or not. For example, lyrics printed in CD booklets is used to lack punctuation marks. In this case, what lyrics is correct - "official" without commas or "literate" with them? Who guarantees that you won't change your mind about this one day? Who guarantees that you won't find a typo in your metadata one day? The correct lyrics isn't a state, but a process.

--- End quote ---

Why are you even talking about this?

For the sake of this conversation the contents of the lyrics file is completely irrelevant, I quite literally could not care less. This has absolutely nothing to do with the issue you presented initially.

Please, stop confusing the issue.



--- Quote from: GCRaistlin on January 05, 2015, 05:23:32 PM ---
--- Quote from: [Saint] on January 05, 2015, 04:21:43 PM ---As I stated in a prior post, I highly recommend MusicBrainz Picard for all metadata creation/editing/removal/etc.

--- End quote ---
I do know where to get the metadata. But I prefer not to change downloaded files. Why? Well, there is no reliable media. Backup is good, but it's much easier to backup corrected lyrics in txt files than a lot of music files the only difference of which from the original (downloaded) ones is corrected embedded metadata. We can consider torrent trackers as a kind of backup, can't we? If you use original torrent files and someday your HDD dies suddenly, all you have to do is to buy a new one and to download torrent again. But if there were changed files on that HDD you've got the problem. And anyway, even you have a backup, you have to process all files again in case of appearing the torrent with the higher quality files.

--- End quote ---

I normally wouldn't expect to ever have to tell someone this, but that is an incredibly odd use case.

You honestly think that the fleeting, transient nature of torrent files, their associated trackers, and magnet links (which you haven't actually mentioned but I thought I would throw in anyway) are a more reliable "backup" (quoted to add sarcastic emphasis because it makes me almost physically ill thinking about it) solution than physical media?

Seriously?

...I...just...wow. I don't even know what to say to that.

I have a very hard time believing that anyone who thinks themselves to be even vaguely well informed could ever possibly believe that to be true. At this point I'm starting to think that you're just pulling my leg for the fun of it, or flailing around desperately moving the goal posts every time someone points out a portion of reality that invalidates your claims or use case.


[Saint]

Edited to add:

I should point out that no one is going to stop you from presenting a patch for review on our Rockbox Gerrit Code Review instance. I can't say as to whether or not it would be committed into the upstream code base of course, but there's nothing preventing you from doing so.

Doing so is likely the fastest way of you achieving the stated goal, as there is no sense of urgency for this task from anyone I'm aware of on our side of the fence.

Navigation

[0] Message Index

[*] Previous page