Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Rockbox Ports are now being developed for various digital audio players!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Rockdroid - 720x1280 touch screen theme
« previous next »
  • Print
Pages: 1 [2] 3

Author Topic: Rockdroid - 720x1280 touch screen theme  (Read 15971 times)

Offline zzw83

  • Member
  • *
  • Posts: 8
Re: Rockdroid - 720x1280 touch screen theme
« Reply #15 on: December 28, 2014, 06:00:11 PM »
Quote from: [Saint] on December 28, 2014, 05:35:32 PM
Quote from: zzw83 on December 28, 2014, 04:16:27 PM
I am not using a phone with a 768x1280 display. Can I just edit the theme files for the 720 theme to work with the 768 resolution?

Sure.

The lazy route, the absolute minimum you could get away with, is kludging 48px of empty space onto the bottom of the sbs and wps backdrops because the backdrop images must match the device's framebuffer exactly. That would 'Just Work' with zero additional changes but would leave a large-ish area of empty space on the bottom of the theme.

The slightly more technical route if you wanted to even that empty space out slightly, and what I would probably do with this, is to add 24px to the bottom of each backdrop image and 24px to the top of each backdrop image (but underneath the status bar strip), and then to drop the y axis down 24px for all the affected viewports and touch areas. Effectively distributing the 48px of additional empty space across two areas half the size.

However, honestly I don't think that taking the 'lazy route' described above would look that bad at all or even be particularly noticeable.

Looking at the theme source just now, either are very simple tasks.


[Saint]

EDIT: looking at it again, the album art could probably be adjusted to absorb the additional 24px of 'extra' space, it could even be adjusted to absorb the entire 48px of extra space, but that does two things. It worsens the memory requirements, and makes adjusting the theme to suit a bit more complex than simply pushing everything down 24px.

Wow. Thanks for that quick and detailed reply.
I will definitely give this a try.
I would have to add the space on the sides of the image not the bottom.

EDIT: It worked! :D
I just extended the two backgrounds to 768 and it works perfectly. The theme is shifted towards the top left but it's barely noticeable with only 48 extra pixels.

Thank you so much and you too ZincAlloy for this!
Rockbox is absolutely the best player for android (especially sound wise). I flat out refuse to use anything else.
« Last Edit: December 28, 2014, 06:39:23 PM by zzw83 »
Logged

Offline ZincAlloy

  • Member
  • *
  • Posts: 488
Re: Rockdroid - 720x1280 touch screen theme
« Reply #16 on: December 29, 2014, 10:49:52 AM »
Quote from: zzw83 on December 28, 2014, 04:16:27 PM
Quote from: ZincAlloy on December 26, 2014, 04:10:12 PM
Interesting. On my Galaxy S3 playback stops after a couple of seconds when I have album art enabled.

I was using a galaxy nexus and playback was fine although some albumart did not load.
I am not using a phone with a 768x1280 display. Can I just edit the theme files for the 720 theme to work with the 768 resolution?

I updated Rockbox and it works for me as well. Funny. I don't think this issue was supposed to be fixed  ;D
I've updated my first post. Album art is enabled now.
Logged

Offline JapaneseDrunkard

  • Member
  • *
  • Posts: 19
Re: Rockdroid - 720x1280 touch screen theme
« Reply #17 on: March 03, 2015, 06:53:31 AM »
I would like to make the rockbox rockdroid bundle.

It is a single apk file that consists of:

1. latest rockbox
2. rockdroid 720x1280 (your excellent theme!)
3. japanese font

Is it OK?
Logged

Offline ZincAlloy

  • Member
  • *
  • Posts: 488
Re: Rockdroid - 720x1280 touch screen theme
« Reply #18 on: March 04, 2015, 12:27:09 PM »
Sure.
Do you have a suitable antialiased font in the correct sizes?
Logged

Offline JapaneseDrunkard

  • Member
  • *
  • Posts: 19
Re: Rockdroid - 720x1280 touch screen theme
« Reply #19 on: March 04, 2015, 02:10:09 PM »
Thanks.

Yes, I have one.
Take a look at the screen shots.

Letter 'g' has a problem under the baseline,
but it is not a big problem for us Japanese :-)

* Screenshot_2015-03-04-20-19-37.png (29.73 kB, 720x1280 - viewed 292 times.)

* Screenshot_2015-03-04-20-18-46.png (59.24 kB, 720x1280 - viewed 371 times.)
Logged

Offline [Saint]

  • Rockbox Expert
  • Member
  • *
  • Posts: 1662
  • Hayden Pearce
    • Google+
Re: Rockdroid - 720x1280 touch screen theme
« Reply #20 on: March 04, 2015, 04:42:06 PM »
JapaneseDrunkard,

Am I to understand that you are a fluent native speaker of Japanese?

If so, how would you feel about me asking you to help to complete the string translations for the Japanese lang file and get rid of the few remaining English strings?

If you would like to be a part of this, please head on over to the Japanese language section of our string translator and submit the remaining entries, if you are willing and able to.

No pressure, do what you can, when you can, if you can.

Help us make Rockbox a better place for our international users.

After completing the translation wizard to the best of your ability or the state of your willingness, hit the "Finish translating" button at the bottom of the page at which point you will be given a patch to upload to either our Flyspray bug/patch tracker or (preferably) our Gerrit instance.

Please use your full given name, in a Firstname Lastname format, to ensure correct attribution is given for the sake of licensing, and because you're important to us!


[Saint]
Logged
Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline ZincAlloy

  • Member
  • *
  • Posts: 488
Re: Rockdroid - 720x1280 touch screen theme
« Reply #21 on: March 07, 2015, 01:09:31 PM »
Quote from: JapaneseDrunkard on March 04, 2015, 02:10:09 PM
Thanks.

Yes, I have one.
Take a look at the screen shots.

Letter 'g' has a problem under the baseline,
but it is not a big problem for us Japanese :-)

It's not antialiased. And that "g" sure is a size issue..
Also you've only replaced the larger of the two fonts. Ideally you'd want to replace both with something that has japanese characters.
Logged

Offline [Saint]

  • Rockbox Expert
  • Member
  • *
  • Posts: 1662
  • Hayden Pearce
    • Google+
Re: Rockdroid - 720x1280 touch screen theme
« Reply #22 on: March 07, 2015, 07:00:24 PM »
Just looks like someone forgot about or didn't know about the ascent/descent (in particular, the latter) flags when generating the font.


[Saint]
Logged
Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline JapaneseDrunkard

  • Member
  • *
  • Posts: 19
Re: Rockdroid - 720x1280 touch screen theme
« Reply #23 on: March 09, 2015, 08:34:17 AM »
Quote from: [Saint] on March 04, 2015, 04:42:06 PM
how would you feel about me asking you to help to complete the string translations for the Japanese lang file and get rid of the few remaining English strings?

Sorry for the late reply.
I will try gerrit http://www.rockbox.org/wiki/UsingGit#Setting_up_Gerrit again tomorrow.
I made my account for Flyspray,
but I cannot log in and I don't know why.

Quote from: ZincAlloy on March 07, 2015, 01:09:31 PM
It's not antialiased. And that "g" sure is a size issue..
Also you've only replaced the larger of the two fonts. Ideally you'd want to replace both with something that has japanese characters.

I understood that I didn't understand what the antialias is.
Please let me make corrections.
I don't have a pre-antialiased bitmap Japanese font.

I can replace the smaller font with Japanese one the next time.

Quote from: [Saint] on March 07, 2015, 07:00:24 PM
Just looks like someone forgot about or didn't know about the ascent/descent (in particular, the latter) flags when generating the font.

I have never cared about the ascent/descent flags
when I generated the bitmap font from the truetype font.

There is a still long way to go.
Logged

Offline JapaneseDrunkard

  • Member
  • *
  • Posts: 19
Re: Rockdroid - 720x1280 touch screen theme
« Reply #24 on: March 10, 2015, 01:51:05 AM »
Quote from: [Saint] on March 04, 2015, 04:42:06 PM
how would you feel about me asking you to help to complete the string translations for the Japanese lang file and get rid of the few remaining English strings?

Done.
My first change to be reviewed is now on top of gerrit :-)
Logged

Offline [Saint]

  • Rockbox Expert
  • Member
  • *
  • Posts: 1662
  • Hayden Pearce
    • Google+
Re: Rockdroid - 720x1280 touch screen theme
« Reply #25 on: March 10, 2015, 05:16:42 PM »
Hi JapaneseDrunkard,

Just wanted to say how much I appreciate your contribution! Thank you for helping to provide a better experience for our international user base.

 :)

Rockbox, in a sense, is a holistic project. Many small parts, which when combined make a whole that is greater than the sum of those parts.


[Saint]
Logged
Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline JapaneseDrunkard

  • Member
  • *
  • Posts: 19
Re: Rockdroid - 720x1280 touch screen theme
« Reply #26 on: March 11, 2015, 04:38:05 AM »
Hi ZincAlloy,

Quote from: ZincAlloy on March 07, 2015, 01:09:31 PM
It's not antialiased. And that "g" sure is a size issue..
Also you've only replaced the larger of the two fonts. Ideally you'd want to replace both with something that has japanese characters.

[problems]
1. The font is not antialiased.
2. The descent part of 'g' is not displayed properly.
3. The smaller font is not replaced with the Japanese one.

2 & 3 are solved.
Please find attached the new screenshots.

I don't have a solution of 1 now,
so I will keep it in mind :-)

Thank you for pointing it out.

* Screenshot_2015-03-11-12-37-14.png (43.26 kB, 720x1280 - viewed 308 times.)

* Screenshot_2015-03-11-12-37-27.png (20.87 kB, 720x1280 - viewed 243 times.)
Logged

Offline JapaneseDrunkard

  • Member
  • *
  • Posts: 19
Re: Rockdroid - 720x1280 touch screen theme
« Reply #27 on: March 14, 2015, 03:24:44 AM »
Quote from: ZincAlloy on March 07, 2015, 01:09:31 PM
It's not antialiased.

Now the both fonts are antialiased.
Thanks a lot :-)

* Screenshot_2015-03-14-16-01-30.png (46.55 kB, 720x1280 - viewed 255 times.)

* Screenshot_2015-03-14-16-01-20.png (71.02 kB, 720x1280 - viewed 256 times.)
« Last Edit: March 14, 2015, 03:55:48 AM by JapaneseDrunkard »
Logged

Offline ZincAlloy

  • Member
  • *
  • Posts: 488
Re: Rockdroid - 720x1280 touch screen theme
« Reply #28 on: March 14, 2015, 07:48:54 AM »
Much better! That will make a nice bundle for japanese speaking users.
Logged

Offline JapaneseDrunkard

  • Member
  • *
  • Posts: 19
Re: Rockdroid - 720x1280 touch screen theme
« Reply #29 on: March 24, 2015, 01:57:09 AM »
ZincAlloy,

I converted your theme to 480 x 854 resolution.
And I would like to upload rockdroid_480x854 to http://themes.rockbox.org/ .
Is it OK with you?
Logged

  • Print
Pages: 1 [2] 3
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  Rockdroid - 720x1280 touch screen theme
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.09 seconds with 17 queries.