Rockbox Development > Feature Ideas
Cover in radio stations
skip252:
My experience with radio artwork is that it works in the way described in the manual. I have a Fuze+. Using the Rockbox Utility been it's updated to 8375b69-140403. I have the Googley-FuzePlus-Storm theme loaded. When place a .jpg with the same name as a FM preset in the .rockbox/fmpresets/ folder the images display.
I first used the Preset context menu to rename the presets. I find using the virtual keyboard awkward even with a custom keyboard. To make future changes easier I opened the saved .fmr file as a text file on my PC. I noted the changes saving the .fmr file had made and used the same pattern to make changes to my other presets. Once I did and added .jpg files named the same as the presets the radio artwork displays as expected.
The size of the artwork doesn't seem to matter as long as it's reasonable. I think of reasonable as no larger than the smallest dimension of the screen. Larger dimensions and file sizes work but I don't see a reason to eat up space using files that don't add to the display quality.
I'm not much of a radio listener but I find the ability to quickly identify which preset is active by the artwork displaying very helpful. I'd like to thank the people that did the coding and maker of the theme for their efforts in extending the capabilities of my Fuze+.
Julian67:
I had a look at various themes I've used. Some don't include any fms file, some include one but the author didn't add the relevant section for displaying cover art, only a single specific backdrop. Some themes didn't include a fully featured fms but have later been updated to do so. It's not a consistent experience and I can see why it "just works" in some cases and appears to be broken in others. If you have a theme with a well written fms it works just like in the manual and if you don't it doesn't. So I copied a cover art section to the fms I'm using and indeed cover art did work after a reboot (full reboot, not just unmounting from USB) .
MadkaT I don't know what player or theme you are using but check the file .rockbox/wps/<your_theme>.fms and if it doesn't include a section like:
--- Code: ---# Cover Artwork
%V(0,0,240,240,-)
%Cl(0,0,240,240,c,c)
%Cd
--- End code ---
Then that is why you aren't seeing the covers. Don't copy that example directly. Look at your theme's .wps file and it probably has a suitable cover art section you can copy to the .fms file. Possibly you need to edit it for width/height. See the Rockbox manual if unsure how this works.
[Saint]:
Well...that was an impressively quick change.
"It doesn't work, ever, insert rant and claims about people quoting from manuals yet not knowing what they're taking about here"
...
"Ohhhhh, the theme has to support it - well...carry on, nothing to see here".
[Saint]
Julian67:
--- Quote from: [Saint] on April 04, 2014, 11:15:59 PM ---Well...that was an impressively quick change.
"It doesn't work, ever, insert rant and claims about people quoting from manuals yet not knowing what they're taking about here"
...
"Ohhhhh, the theme has to support it - well...carry on, nothing to see here".
[Saint]
--- End quote ---
It's nice to be appreciated, especially by the saintly.
There's more to it than "the theme has to support it" because themes can have bugs too. Some themes don't work as described unless/until someone notices and fixes it (the big theme change a couple of years ago gave a lot of opportunities for this). For example in the theme I use on the Fuze+ (grayfog) cover art in the radio screen had never worked despite it being supported (until yesterday when I saw this thread and was curious enough to revisit the issue and fix it).
Just now I checked the theme section of the site and in the theme description notice there is now an updated version, tagged "Fixed FM Radio artwork..."
It is perfectly possible to install bootloader, firmware and theme using the official installer onto fully working hardware, configure and use it exactly as described in the manual and for it to still not work in every aspect. That has been precisely my experience on more than one theme and on more than one player, and the fact that the same feature didn't work on my two different colour screen players certainly gave a damn good impression of the feature not working. Like I said earlier I didn't care enough about radio cover art to do any more than think "oh well" and carry on, but I do know how puzzling it can be if you're new to something, you follow the instructions to the letter, it doesn't work yet everyone keeps telling you it does.
Anyone might hit upon a combination of hardware/firmware/config that does not do what it is supposed to do in every aspect. The OP described the problem very clearly and posted his file names and presets demonstrating that he is apparently doing it by the book and it still doesn't work. Saying "sure it works" doesn't strike me as a diagnostic technique because it doesn't allow for the possibility of a bug being present.
Thank you for your blessings.
[Saint]:
You just phrased "the theme has to support it" for me in a very long winded fashion.
"Not having user introduced bugs" is part of "supporting" this feature.
Users often forget that these themes are user submitted and no guarantee is given of their functionality. The theme site is perhaps a bit misleading, possibly adding to this confusion. We can't actually reliably say "Works with Current Build", as we have little idea of what "works" is, as intended by the author. "Works" is a pseudonym for "parses", really. We can tell the syntax is intact, no needless duplication of files is happening, and that no irrelevant files are included, but that's it. Being syntactically valid doesn't necessarily mean it functions as originally intended by the author.
[Saint]
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version